because if I return the same name, it will be removed after that.

The rename function in index.js uses obj.hasOwnProperty, which is not defined when the object does not inherit from Object.prototype. In the most basic example, this would fail with TypeError: obj.hasOwnProperty is not a function:

const input = Object.create(null);
input.a = 0;
require('rename-keys')(input, key => key);

A more realistic example would be trying to rename the keys of an object returned from querystring, which in Node v6 stopped inheriting from Object.prototype.

const querystring = require('querystring'),
    rename = require('rename-keys');

rename(querystring.parse('a=1'), key => key);

Live example of the same

Instead it should just skip that key, so don't do return, do continue

Can there be a way to immutably rename the keys? ie: returns a new object instead of mutating the source?

Hello Jon,

I ran into an issue when trying to return 0 from the rename function since it evaluates to false.

Although falsey values are valid object keys they are incompatible with the current implementation.

I am assuming here that your intention was probably to handle an undefined return value from the rename function by keeping the original key.

Maybe the tradeoff is to explicitly look for undefined when returning the original by default?

I've solved my problem by just starting my keys from 1 but I thought it was worth discussion anyways.

Cheers,

Scott

Care if I submit a PR to add a recursive option?