joomla-framework / http Goto Github PK

Should also be changed in the framework

Originally posted by @PhilETaylor in joomla/joomla-cms#35568 (comment)

Hello @mbabker

Would be cool to have protocol version support.
Made a http client adapter, and thats the only thing thats missing.
https://github.com/saxulum/saxulum-http-client-adapter-joomla

Regards @dominikzogg

The Factory should be able to support custom implementations as well as the base classes as part of this package. Our social API packages which subclass Joomla\Http\Http are unable to use the factory to build an instance of this because of the hardcoded dependencies.

Not sure if this is something that should be fixed be or is willing to be fixed - but finding a scenario where a curl response could have multiple Set-Cookie headers. But because https://github.com/joomla-framework/http/blob/master/src/Transport/Curl.php#L279 merges the headers into an associative array, only the last header is made available to the calling script with no way to access the original headers.

To reproduce, create a simple script that set's several cookies with setcookie(). Then a second script using this package to post to it and examine the $response->headers. Only the last Set-Cookie header will be available.

As a work around - will look at using a curl cookie jar but was hoping for something "in memory" rather than writing cookies to a file.

Exceptions thrown within the transports need to implement Psr\Http\Client\ClientExceptionInterface. This is going to require creating new Exception subclasses for the various error cases still using core PHP exceptions to fulfill this contract. As we don't work with Psr\Http\Message\RequestInterface in the transports, use of the two sub-interfaces is not needed.

Steps to reproduce the issue

Update composer/ca-bundle to latest version on 1.0.x branch to remove expired DST Root CA X3 rcoot certificate.

Remove old expired DST Root CA X3 Let's Encrypt root certificate - see Old Let’s Encrypt Root Certificate Expiration and OpenSSL 1.0.2

Expected result

HTTPS connections to servers with latests Let's Encrypt certificates from server with openssl version 1.0.2 are working.

Actual result

HTTPS connections to servers with latests Let's Encrypt certificates from server with openssl version 1.0.2 are NOT working

System information (as much as possible)

Any server with openssl 1.0.2

Additional comments