jordanzagerman / portfolioroot Goto Github PK

Overall it's a good start that could be fleshed out more and tightened from a design standpoint.

Issues

1. No custom fonts.
2. Links to external sites should open in a new window, i.e. LinkedIn
3. Images are not optimized. You have images on your work.html page cresting near or above 1MB. You should have multiple versions of each image (small/thumbnail and large) so that the grid uses small images and the lightbox uses larger versions, and all should be optimized to be the smallest possible file size without losing quality.
4. Many of your images are in .png format, when they probably should be in .jpg format for better compression.
5. The #wrapper element does not include the critical overflow: auto; 🐛fix we discussed in class. As a result, the calculated height of the container is 0.
   
6. Homepage Recent Work section is empty. This leaves the primary content on the homepage the FAQ. A text based FAQ on the homepage = boring.

Considerations

LIghtboxes are worn out and not ideal for mobile devices. Implementing one for this project does not count against you, but I recommend coming up with a different plan for next term.