Giter VIP home page Giter VIP logo

ssc-swapper-review's Introduction

SSC Swapper

Hello SSC team, Lumenous and I tested the SSC swapper and found/suggest the following things:

BUGS

Rinkeby explorer problem


  • Swapper is showing "view explorer" and opens Kovan testnet while transactions were on Rinkeby testnet. When you open the explorer from metamask you will be redirected to Rinkeby and you see your transaction.

Screenshot swapper transaction
Screenshot Kovan explorer

  • The transaction link returns no transaction on etherscan
Rinkeby sends you to Kovan

transaction id

Kovan send you to Ropsten

transaction id

Kovan explorer problem


When you swap on Kovan testnet and click on "view explorer" it will not point you to the actual transaction but to the "Txnhash not found" on the Ropsten testnet explorer.

Screenshot Ropsten explorer

  • In console this appeared when clicking on view transaction

Fired outbound link event kovan.etherscan.io/tx/***

Browser Console

warnings that appear in console for depreicated packages
  • event 'close' is deprecated use 'disconnect'
  • event 'networkChanged' is deprecated use 'chainChanged'
  • 'ethereum.send() is deprecated use 'ethereum.sendAsync()'

Browser Console transaction

Suggestions for features

Copy adress with a click


Add the feature to copy your wallet adress in the right top. It already looks like you can click on it to copy it but it doesn't work. We didn't think it is a bug but probably a feauture what isn't added yet.

Screenshot adress copy

Disconnect wallet from website


Add a feature what shows which network is active while you are using the swapper. Probably it would look nice next to the button where you can copy your adress Screenshot adress copy.

Summary


Overall the swapper looks very smooth, the transcations are executing fast. We only found a few minor bugs and listed them above.

ssc-swapper-review's People

Contributors

jordydutch avatar

Watchers

 avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.