UXML get returns self|null ... about einvoicing HOT 6 CLOSED

Hmmm self update, Solution 1 can't be used ! so i start to test all get returns before accessing to supposed values ...

from einvoicing.

Hello @rycks,

UXML is a different library, UXML::get() must return null if no element is found as per the specification. So yeah, that cannot be changed.

The PR you propose isn't possible either as none of the values you've changed can be null (eInvoicing expects them to be non empty). Probably adding a few null checks and throwing an InvalidArgumentException is the best approach here given it will comply with the current documentation, which would be ideal for backward compatibility.

Will that fit your use case? I'm assuming you're parsing an XML document that doesn't comply with the UBL PEPPOL specs. Or is it a valid invoice using a CIUS that overrides PEPPOL in weird ways?

from einvoicing.

you are right, is that a peppol invoice ?

<?xml version="1.0" encoding="UTF-8"?>
<Invoice xmlns:qdt="urn:oasis:names:specification:ubl:schema:xsd:QualifiedDataty
pes-2" xmlns:ccts="urn:oasis:names:specification:ubl:schema:xsd:CoreComponentPar
ameters-2" xmlns:stat="urn:oasis:names:specification:ubl:schema:xsd:DocumentStat
usCode-1.0" xmlns:cbc="urn:oasis:names:specification:ubl:schema:xsd:CommonBasicC
omponents-2" xmlns:cac="urn:oasis:names:specification:ubl:schema:xsd:CommonAggre
gateComponents-2" xmlns:udt="urn:un:unece:uncefact:data:draft:UnqualifiedDataTyp
esSchemaModule:2" xmlns="urn:oasis:names:specification:ubl:schema:xsd:Invoice-2"
>
  <cbc:UBLVersionID>2.0</cbc:UBLVersionID>
  <cbc:CustomizationID>1.0</cbc:CustomizationID>
  <cbc:ProfileID>FFF.BE ExactOnline</cbc:ProfileID>
  <cbc:ID>20700108</cbc:ID>
  <cbc:InvoiceTypeCode listURI="http://www.FFF.be/ubl/2.0/cl/gc/BE-InvoiceCode-1.0.gc">380</cbc:InvoiceTypeCode>

what could i do before open it with your peppol lib to check if it's a good peppol invoice ?

from einvoicing.

The UBL snippet you provided appears to have been generated by a software called Exact Online (not a valid EN 16931 invoice).

You can verify this by reading the <cbc:ProfileID /> field and making sure it starts with "urn:cen.eu:en16931:2017#compliant". For instance, PEPPOL BIS 3.0 invoices here have a value of "urn:cen.eu:en16931:2017#compliant#urn:fdc:peppol.eu:2017:poacc:billing:3.0".

I'm closing the issue now that this has been clarified.

from einvoicing.

Ok, thanks
but it could be good idea to make a early test in UXML no and get an error or exception in case of XML is not valid ?

from einvoicing.

Just added proper error handling to throw an InvalidArgumentException when the XML document is invalid. You can test it by requiring the latest development version:

composer require josemmo/einvoicing:dev-develop

from einvoicing.