The cloudformation-extensions from joshbalfour

Add a .cfnex file

If it could search up for a .cfnex to load any settings such as extensions directry, template directory and dist directory. So i can at anytime call cfnex to rebuild, and if im in the folder with the .cfnex file then it knows where to build (and everything is relative to the .cfnex file)

Include-file extension does not pass <%cfnex tag contents through as objects

When using the include-file extension, it parses <%cfnex tags so that it can pass the contents of those tags back to the outer template. However, the <%cfnex parsing simply passes the contents of the tag through as a string instead of parsing it as an object, which doesn't seem to provide the value that is intended by this feature.

For example, using the e2e test which pulls in example/ec2/boot.sh:

#!/bin/bash
echo ECS_CLUSTER=<%cfnex { "Ref": "EcsCluster" } cfnex%>  >> /etc/ecs/ecs.config

When pulled in by example/cfnex-cloudformation.json this generates:

...
        "UserData": {
          "Fn::Base64": {
            "Fn::Join": [
              "\n",
              [
                "#!/bin/bash",
                {
                  "Fn::Join": [
                    "",
                    [
                      "echo ECS_CLUSTER=",
                      " { \"Ref\": \"EcsCluster\" } ",
                      "  >> /etc/ecs/ecs.config"
                    ]
                  ]
                },
                ""
              ]
            ]
          }
        }
...

which the CloudFront template will not recognize for parameterization, since it sees the Ref as just part of a string. The expected output is:

        "UserData": {
          "Fn::Base64": {
            "Fn::Join": [
              "\n",
              [
                "#!/bin/bash",
                {
                  "Fn::Join": [
                    "",
                    [
                      "echo ECS_CLUSTER=",
                      {
                        "Ref": "EcsCluster"
                      },
                      "  >> /etc/ecs/ecs.config"
                    ]
                  ]
                },
                ""
              ]
            ]
          }
        }

so that CloudFront will actually insert the parameter inline. I will be submitting a PR with this fix shortly.

joshbalfour / cloudformation-extensions Goto Github PK

cloudformation-extensions's People

Contributors

Stargazers

Watchers

Forkers

cloudformation-extensions's Issues

Recommend Projects

Recommend Topics

Recommend Org