Giter VIP home page Giter VIP logo

one-dark's People

Contributors

joshpeng avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

one-dark's Issues

Not working on Windows

I am using Windows 10 and first install sublime babel then one dark (sublime) then change syntax but it does not change the colours or styles.

ext install sublime-babel-vscode
ext install theme-onedark-sublime

onedark_1
onedark_2

Issue in C# code

look on 'x' variable in lambda:
screenshot 8
monokai behavior:
screenshot 9

UPD: or it's as designed? I've looked on variable declarations, methods parameters - all use 2 different colors too

String interpolation and template string support

When using template strings, it would be nice if the curly braces were colored differently than the color of the string itself.

For instance, when using CoffeeScript's string interpolation:
String Interpolation with single variable
String Interpolation with variable and property

Or ES6 template strings:
Template string with single variable
Template string with variable and property

Thanks!

Please re-evaluate your CSS color selections...

I love this theme, and I know it's more js and python oriented, but CSS coloring could use some attention.
The colors chosen are too similar to each other, and reading CSS can be tiring.
I've included a screenshot:
ss1

Template Engines Colorization (Kind Request)

Congrats on this great theme, I love it and I've been using it for months now.
I would like to make a request, if you have the time to implement it.
Could you add colorization for the mustache tokens used by several templating engines?
I'm talking about these:
{{ example }}
{% example %}
<%= example %>

Those are the most common ones for most html-embedded engines. Those are the engines that use embedded tags inside html files, not the other types that require rewriting html into another style or file.
Please consider it.
Thanks for taking the time to read this.

Support for Flowtype

Hi, I've been using this syntax for quite some time, and it's really great. I am working on React and am using Flow annotations. Would you be interested in adding support for 'type' imports in JS, and some flow-specific syntaxes? Some examples to show where this syntax needs to be improved:

  1. Type imports mixed with normal imports:
    image
    The first type imported breaks the subsequent highlighting.
  2. Putting types on class properties breaks the highlighting:
    image

There are a bunch more issues, but I think you get the idea. Can you add better flow support?

workbench colorCustomizations

I have to add this to my settings.json for the theme to apply on workbench items too. Maybe it's worth integrating into the theme?

    "workbench.colorCustomizations": {
        "[One Dark+ (Sublime)]": {
            "activityBar.background": "#2F333D",
            "activityBar.foreground": "#D7DAE0",
            "activityBarBadge.background": "#4D78CC",
            "activityBarBadge.foreground": "#F8FAFD",
            "button.background": "#404754",
            "diffEditor.insertedTextBackground": "#00809B33",
            "dropdown.background": "#1d1f23",
            "dropdown.border": "#181A1F",
            "editor.background": "#282c34",
            "editor.findMatchHighlightBackground": "#314365",
            "editor.lineHighlightBackground": "#383E4A",
            "editor.selectionBackground": "#3E4451",
            "editorCursor.foreground": "#f8f8f0",
            "editorGroup.background": "#181A1F",
            "editorGroup.border": "#181A1F",
            "editorGroupHeader.tabsBackground": "#21252B",
            "editorHoverWidget.background": "#21252B",
            "editorHoverWidget.border": "#181A1F",
            "editorIndentGuide.background": "#3B4048",
            "editorLineNumber.foreground": "#495162",
            "editorSuggestWidget.background": "#21252B",
            "editorSuggestWidget.border": "#181A1F",
            "editorSuggestWidget.selectedBackground": "#2c313a",
            "editorWhitespace.foreground": "#3B4048",
            "editorWidget.background": "#21252B",
            "input.background": "#1d1f23",
            "list.activeSelectionBackground": "#2c313a",
            "list.activeSelectionForeground": "#d7dae0",
            "list.focusBackground": "#383E4A",
            "list.highlightForeground": "#C5C5C5",
            "list.hoverBackground": "#292d35",
            "list.inactiveSelectionBackground": "#2c313a",
            "list.inactiveSelectionForeground": "#d7dae0",
            "notifications.background": "#21252b",
            "scrollbarSlider.activeBackground": "#747D9180",
            "scrollbarSlider.background": "#4E566680",
            "scrollbarSlider.hoverBackground": "#5A637580",
            "sideBar.background": "#21252b",
            "sideBarSectionHeader.background": "#282c34",
            "tab.activeBackground": "#2c313a",
            "tab.border": "#181A1F",
            "tab.inactiveBackground": "#21252B",
            "titleBar.activeBackground": "#282c34",
            "titleBar.activeForeground": "#9da5b4",
            "titleBar.inactiveBackground": "#282C34",
            "titleBar.inactiveForeground": "#6B717D"
        }
    },

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.