joshuajansen / magnific-popup-rails Goto Github PK

View Code? Open in Web Editor NEW

52.0 52.0 18.0 56 KB

Ruby 1.96% JavaScript 84.04% CSS 14.00%

magnific-popup-rails's People

Contributors

Stargazers

Watchers

Forkers

div ivrrimum bracket7 nles itsnikolay danielpuglisi netmaniac appfolio jprincipe memoxmrdl aditiya66 bilalnaeem webdev1001 igor-firman rmedinap kimsg wnm halida

magnific-popup-rails's Issues

License missing from gemspec

Some companies will only use gems with a certain license.
The canonical and easy way to check is via the gemspec,

via e.g.

spec.license = 'MIT'
# or
spec.licenses = ['MIT', 'GPL-2']

Even for projects that already specify a license, including a license in your gemspec is a good practice, since it is easily
discoverable there without having to check the readme or for a license file.

For example, there is a License Finder gem to help companies ensure all gems they use
meet their licensing needs. This tool depends on license information being available in the gemspec. This is an important enough
issue that even Bundler now generates gems with a default 'MIT' license.

If you need help choosing a license (sorry, I haven't checked your readme or looked for a license file),
github has created a license picker tool.

In case you're wondering how I found you and why I made this issue, it's because I'm collecting stats on gems (I was originally
looking for download data) and decided to collect license metadata,too, and make issues for gemspecs not specifying a license as a public service :).

I hope you'll consider specifying a license in your gemspec. If not, please just close the issue and let me know. In either case, I'll follow up. Thanks!

p.s. I've written a blog post about this project

Incompatible with Rails 4.1

Just upgraded to Rails 4.1, and this gem doesn't work.

Sass::SyntaxError - File to import not found or unreadable: magnific-popup.
Load paths:
  /Users/raphael/Documents/projects/special_sauce/app/assets/images
  /Users/raphael/Documents/projects/special_sauce/app/assets/javascripts
  /Users/raphael/Documents/projects/special_sauce/app/assets/stylesheets
  /Users/raphael/Documents/projects/special_sauce/vendor/assets/javascripts
  /Users/raphael/Documents/projects/special_sauce/vendor/assets/stylesheets
  /Users/raphael/.rvm/gems/ruby-2.1.1/gems/bootstrap-sass-2.3.2.2/vendor/assets/images
  /Users/raphael/.rvm/gems/ruby-2.1.1/gems/bootstrap-sass-2.3.2.2/vendor/assets/javascripts
  /Users/raphael/.rvm/gems/ruby-2.1.1/gems/bootstrap-sass-2.3.2.2/vendor/assets/stylesheets
  /Users/raphael/.rvm/gems/ruby-2.1.1/gems/coffee-rails-4.1.0/lib/assets/javascripts
  /Users/raphael/.rvm/gems/ruby-2.1.1/bundler/gems/rails_emoji-ab58de3a497a/vendor/assets/images
  /Users/raphael/.rvm/gems/ruby-2.1.1/gems/magnific-popup-rails-0.9.9/vendor/assets/javascripts
  /Users/raphael/.rvm/gems/ruby-2.1.1/gems/magnific-popup-rails-0.9.9/vendor/assets/stylesheets
  /Users/raphael/.rvm/gems/ruby-2.1.1/gems/jquery-form-rails-1.0.1/vendor/assets/javascripts
  /Users/raphael/.rvm/gems/ruby-2.1.1/gems/jquery-rails-3.1.2/vendor/assets/javascripts
  /Users/raphael/.rvm/gems/ruby-2.1.1/gems/d3-rails-3.4.13/app/assets/javascripts
  /Users/raphael/Documents/projects/vendor/assets/stylesheets
  (in /Users/raphael/Documents/projects/special_sauce/app/assets/stylesheets/application.css.scss:40):
  sass (3.2.19) lib/sass/tree/import_node.rb:67:in `rescue in import'
  sass (3.2.19) lib/sass/tree/import_node.rb:45:in `import'
  sass (3.2.19) lib/sass/tree/import_node.rb:28:in `imported_file'
  sass (3.2.19) lib/sass/tree/import_node.rb:37:in `css_import?'
  sass (3.2.19) lib/sass/tree/visitors/perform.rb:217:in `visit_import'
  sass (3.2.19) lib/sass/tree/visitors/base.rb:37:in `visit'
  sass (3.2.19) lib/sass/tree/visitors/perform.rb:100:in `visit'
  sass (3.2.19) lib/sass/tree/visitors/base.rb:53:in `block in visit_children'
  sass (3.2.19) lib/sass/tree/visitors/base.rb:53:in `visit_children'
  sass (3.2.19) lib/sass/tree/visitors/perform.rb:109:in `block in visit_children'
  sass (3.2.19) lib/sass/tree/visitors/perform.rb:121:in `with_environment'
  sass (3.2.19) lib/sass/tree/visitors/perform.rb:108:in `visit_children'
  sass (3.2.19) lib/sass/tree/visitors/base.rb:37:in `block in visit'
  sass (3.2.19) lib/sass/tree/visitors/perform.rb:128:in `visit_root'
  sass (3.2.19) lib/sass/tree/visitors/base.rb:37:in `visit'
  sass (3.2.19) lib/sass/tree/visitors/perform.rb:100:in `visit'
  sass (3.2.19) lib/sass/tree/visitors/perform.rb:7:in `visit'
  sass (3.2.19) lib/sass/tree/root_node.rb:20:in `render'
  sass (3.2.19) lib/sass/engine.rb:315:in `_render'
  sass (3.2.19) lib/sass/engine.rb:262:in `render'
  sass-rails (4.0.4) lib/sass/rails/template.rb:22:in `evaluate'

Any ideas?

assets not found

Hi Joshua,

Thanks for your work here.

Neither the css or js file can be found by rails.

$'bundle show magnific-popup-rails outputs': .rvm/gems/ruby-1.9.3-p374/gems/magnific-popup-rails-0.8.1

Rails 3.2.8

I'll keep poking around but I thought I'd let you know.

Push actual version to RubyGems

RubyGem's last version of this gem is 0.9.9.1 as you can check here, but it doesn't match with this repo's version.rb file.

In fact, the code I got installed through gem install still has the .css.scss extension that was removed in 0c40f29.

Thanks in advance 😃

Integration with turbolinks

Hey, as far I've tried it does not well with turbolinks. I have such peace of code:

setupProducts = -> 
        $('.photo-gallery').magnificPopup
                type: 'image',
                delegate: 'a',
                gallery: {enabled: true}
$ ->
  document.addEventListener "page:load", setupProducts
  setupProducts()

When I start in a page with element $('.photo-gallery') I click on it and magnific show the gallery. Then I go to some other page using turbolinks. When I go back to the first page after clicking on the element nothing happens.

It seems like it was already initialized for this element (that at this time is in the turbolinks cache (?)). And magnific stops working if initialized for the second time on the same element. Is there a way to check if magnific was already initialized for a giving element?

Missing scroll bar after submitting form within pop-up window

To reproduce the issue create a form with in a pop-up window that has a form with a submit button like this: <%= f.submit "Send" %>. When clicked the form is submitted correctly, and the pop-up window appears to be gone, but the underlying page now has no scroll bars, so user can't navigate the page. Requires a manual page reload to recover from this state.

Fix:

Add code to close the window to submit button: <%= f.submit "Send" %, onClick: "closePopup();">
Add corresponding small javascript:

  function closePopup() {
    $.magnificPopup.close();
  }

joshuajansen / magnific-popup-rails Goto Github PK

magnific-popup-rails's People

Contributors

Stargazers

Watchers

Forkers

magnific-popup-rails's Issues

License missing from gemspec

Incompatible with Rails 4.1

assets not found

Push actual version to RubyGems

Integration with turbolinks

Missing scroll bar after submitting form within pop-up window

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent