joshuawise / nodemark Goto Github PK

Am I correct in assuming that the library attempts to deal with noise and the garbage collector in a better way? Also, how accurate would the library be when browserified?

I'm interested in using this library to help with in-browser benchmarking as well as potentially using it in Deno. I've done the work of removing node-specific dependencies in this branch. I'd be happy to contribute this as a PR.

(This makes the minimum Node version requirement 11.x, IIRC, in order for these features to be available. It also requires polyfilling globalThis.performance e.g. like so. I realise these are breaking changes for the library. I'd also appreciate advice on the best way to create a version which can be immediately imported in Node without requiring the user to supply the polyfill code.)

I've also done a bunch of other work in my fork, including

• Converting from require to import (changes)
• Replacing Mocha/Chai with tape (seems like the lightest testing framework for Node that I can find)
• Adding basic tests instead of no-op (see tests)
• Replacing Travis with Github Actions (changes)
• Formatting code using Deno's built-in formatter

I'd be happy to contribute any of these changes, but I also realise that the changes are significant, would involve a major version bump, and might not align with what you want for the library. I'm considering simply creating a "hard fork" if that's the case!

I really appreciate the work you have put into nodemark - it's the most straightforward and useful JS benchmarking library I've found.

EDIT: this is my attempt at patching up Node's global environment with performance so that browser code runs in Node.