joulupukki / bluegrassguru-issues Goto Github PK

For some reason it looks perfect in the iOS Simulator, but running on my actual iPhone looks bad with strange indentation.

After fixing Issue #15, it looks like the pull-to-advance view on the bottom of the screen only works when in full-screen mode. Finding the "bottom" of the table view (where song lyrics are displayed) has been a bit tricky, especially after the iPhone X was released. I'm wondering if maybe instead of trying to find the "bottom" of the UITableView if I placed a 1px high view with a clear background that could be used as an anchor instead?

On the new Library screen (home screen of the app), there's a Most Viewed section that shows you the songs that you access most. Need to decide whether showing the count is helpful. At this point I'm thinking it's not that helpful to see the actual count.

I'm also wondering if showing this section is even useful. If you've got thoughts on this, please add your comments!

Here's what I'm currently thinking about the paywall...

1. Search is free. Once this release is live I will be turning off the Bing Search API access so older versions of the app will no longer have built-in search. The new app will have search completely free (i.e., it won't cost me anything when we all use the app to search for songs).
2. Built-in tags will be free. You'll be able to use the default tags I ship in the app. If you want to add custom ones, you'll need to have a Guru Membership (premium subscription).
3. Set Lists have been a pay-for item in the past. I'm going to change the app so that you can make ONE set list. You'll only be able to add 5 songs to it.
4. Number of songs you can add to your library will be limited to TEN without getting a premium subscription. For people who already have more songs than this, they can continue to access them, but any time you try to add more songs, it'll check first to see that you're a premium subscriber.
5. Sync & Backup will remain a premium feature. If you're serious about keeping your songs backed up and synced with all your iOS devices, this is a no-brainer.

My reasoning behind this is that I want people to be able to experience all of the app's features without having to purchase anything. However, it does cost real $ to keep this app alive. There are Amazon server costs (mailing list), website costs, and the yearly Apple Developer Membership.

I still want to keep the cost relatively low because I'm not looking to make it rich on this. I just don't want to subsidize the whole thing. I've donated a lot of $ and time already to the project (happily), but it's time to share that joy with everyone who benefits from the app.

Similar to how the Music app works on iPhone, potentially make the extra sections on the Library screen configurable so you could turn them on and off.

This is likely not going to be something I do for version 11.0, but wanted to record the idea here anyway.

When you're on the new search screen and a lot of results come back in the "Your Device's Music" section, many items are being returned with blank/nil title and subtitle. I'm not sure if this is related to this same problem, but if you tap to play a video file and then tap a different one, sometimes the UI is not updated on the first one that was playing.

I never thought the help tips worked well enough to be included. I'm hoping that the newer interface is a little more self-explanatory. This ticket is just to make sure to go through the entire app and exclude the code from being even included anywhere.

If you have search results showing in the embedded browser and switch the search type (using the segmented control), it's not reloading the search at all.

Need to also verify that the correct URL is being built when searching (using all of the preferred/all sites).

Figure out how to make the UITabBar disappear when viewing song lyrics. It takes up too much page and also isn't allowing full screen mode to work.

It might be interesting to see a recently-played videos section on the home screen.

If you click on a recent search item (that's not the top-most item), it should bubble up to the top the next time the recent search items are shown. It's not doing that .

I've heard feedback from one customer that says it would be nice to have a metronome and BPM setting when viewing a song so that when he goes to practice/jam/perform, he can consistently play it at the right speed.

As of right now, this may not make it into 11.0 and the only supported web site will be google.com. If time, add in Bing as an option and make it configurable in the app's settings screen.

When using Quick Search (the button in the toolbar that looks like a search with a play button inside it) it would be nice to be able to play a YouTube video inside the View Lyrics screen so you could practice a song along with watching/listening to pre-recorded music.

Searching will now be a free-for-all feature starting in version 11.0. Need to remove it from the Paywall screens.

This is a problem happening on my iMac only. Need to track down why. I clear the recent searches and then go back to the search screen and it comes back.

Just making a note of how to opt out (temporarily) of dark mode in iOS 13. This will only be an issue once iOS 13 is released and we're all forced to use the new SDK for building and submitting apps. Instructions are at the bottom of this screen: https://developer.apple.com/documentation/appkit/supporting_dark_mode_in_your_interface/choosing_a_specific_interface_style_for_your_ios_app

With the new interface, the launch screen needs updating

Similar to how the new search lyrics view uses a font picker, see if there's a way to integrate this onto the lyrics view screen.

When someone is brand new to the app, help them get started so they know what to do and why there aren't any lyrics "built-in" to the app.

Add in the data source so when you view lyrics from the recent list, you can scroll to the prev/next song.

From the + button on the Songs screen the "Search the Internet" button is going to the old search interface. It should also be renamed to "Search the Web".

When you view a song, perhaps a rule should be in place that you have to view it for something like at least 10 seconds before it counts as a "view." This may help prevent artificially inflating the view count when flicking through songs. On my app, for example, the song that is showing as the most-viewed song is the one at the top of the list alphabetically.

When a new web search is performed, make sure to add the search term to the recently searched list (stored in UserDefaults).

This is just a reminder to make sure nothing funky happens on iPad with the newer UI.

When a song is playing in the "Your Device's Music" section and you tap to go to other screens, it's not stopping the currently playing song in all instances.

Even if we remove the counts (Issue #7) from showing, there's still an underlying issue where the section isn't being updated fast enough. If we change the way that we count views (Issue #22) that may also make this strange behavior (to where people may think that it's broken after they view a song(s)).

Right now subscriptions are a one-time purchase and don't automatically renew. This makes it inconvenient when your subscription runs out and you need to access a subscription-only feature at a gig/jam.

Need to check to see if extra lines are showing on the table view. If they are, just add in the viewDidLoad() function:

tableView.tableFooterView = UIView()

Also use embedded Safari browser to view them in the app.

If you navigate through a few different pages on a web search it seems like you can get into a state where it keeps hold of the forward contents too long.

Duplicate by:

1. Searching for a song
2. Navigate into the song (in the embedded web browser)
3. Navigate to an additional song inside that song (you're 2 levels deep)
4. Navigate back to the initial search results
5. Change the search type (Preferred | All Sites)

The forward button should be disabled and should have been cleared out.

The app must not be properly loading URL content because the progress meter isn't being updated until the very last second and there's also a delay in showing the contents of the screen.

This should be buttery smooth and a progress bar should show all the time (and progress) during loading and only go away once the data of the web page is showing.

Duplication steps:

1. View a song
2. Rotate to Landsacpe mode
3. Attempt to rotate back to Portrait

CRASH!

The music notes icon doesn't seem appropriate in the tab bar. Perhaps use something similar to what the Music app's Library tab uses, but add the Bluegrass Guru Guitar Pick shape on the folder?

The app has been using Flurry, but may want to consider using Firebase analytics instead. Also need to re-introduce this into the newer UI.

If you tap the "make smaller" font (the smaller "A") on the font adjuster on the lyrics view (in search results), nothing appears to happen. The reason for this is that the code just decrements the current font size of the song. The current default size is 0 and so decrementing isn't really doing anything for the font point size. I think the fix is to make sure new FBSong objects are set up with a default font size.

Looks like I need to account for the modalPresentationStyle.

Not sure if I should do this or not, but part of me thinks we shouldn't take up extra screen space by showing "No results found" in a section if it doesn't have any results to show.

If you search for a song from search that causes the Web Search feature to appear and then save a song ... the song doesn't appear in the list after you dismiss the search screen.