jpos / jpos-gradle-plugin Goto Github PK

dist target creates a flat structure and doesn't include a top level directory with the project and version name as we used to produce using jpos-app.gradle script.

The plugin makes the jar task to depend on createGitRevision task, that fails if this is not a git repository, the build even fails after performing a git init with a NoHeadException.

There are many options for this:

1. Not adding the dependency if the project is not in a git repository, and maybe not creating the task at all.
2. Letting a project property select if we want to run the task.
3. Ignore the git exception if a project property is set.
4. All of the above.

The easier to implement are 2 and 3.

I don't know if there is an easy way of asking jGit about whether the project is in a git repository or not, without using hard coded literals for implementing 1. But also for this we would need to ask git specific questions from the JPOSPlugin class, of course we can relay that to a GitRevisonTask method.

When running the test task, the following warning is printed:

  - Gradle detected a problem with the following location: 'repo/modules/module/build/resources/main'. Reason: Task ':modules:module:compileTestJava' uses this output of task ':modules:module:createBuildTimestamp' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.5.1/userguide/validation_problems.html#implicit_dependency for more details about this problem.
  - Gradle detected a problem with the following location: 'repo/modules/module/build/resources/main'. Reason: Task ':modules:module:compileTestJava' uses this output of task ':modules:module:createGitRevision' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.5.1/userguide/validation_problems.html#implicit_dependency for more details about this problem.

We can use this plugin as an example to how to fix those warnings: https://github.com/n0mer/gradle-git-properties/blob/master/src/main/groovy/com/gorylenko/GitPropertiesPlugin.groovy