Giter VIP home page Giter VIP logo

autofish's People

Contributors

jsbots avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

autofish's Issues

no longer works in windowed maximized mode

I've been using AutoFish for over a month without problem, but I can't seem to get it to detect the bobber any more. Could have also been the latest Turtle WOW update as well perhaps? I did notice that it the cursor WILL move AFTER I stop the bot sometimes to where the bobber is.

EDIT: Doesnt seem to work in Windowed >> Maximized mode anymore. If i untick "maximized" it seems to work OK.

Not casting in Ascension Wow

I'm not sure what is causing the issue here but the symptoms are:

  1. The program doesn't cast fishing. I set the key to 1 and the fishing ability to key 1.
  2. The program doesn't catch the fish in time. It says found the bobber, and reads checking hook but always results in fish got away.

potential issues:

  1. Ascension wow has a custom window called Ascension.
  2. Not sure if it's running in DirectX 11 or not. I have no option to change that.

AutoFish 1.6.2 clicking in the wrong spot

I'm on Tauri wow for mop 5.4.8.

Everything seems to be working except there is a clear offset between where the bobber actually is and where the application thinks it is. When the bobber moves on recast the mouse moves as well in the right direction, but there is always an offset between the mouse and the bobber that is around the same amount. Any thoughts on how to fix this?

I have attached a reference gif, cropped so that no details about my account are shown:

https://imgur.com/a/NhBGrar (without like a human and with like a human)

I did modify the fishing zone but it also breaks with the default values of x:0.3, y:0.01, w:0.4, h:0.416.

I am on windowed fullscreen 1920x1080.

Please let me know what additional information would be helpful.

Telegram remote dosnt start on start

Telegram remote does not link/start to telegram bot when pressing start and Token is saved. Always have to press connect in advanced settings before starting.

crashing and bringing up esc menu

I'm not sure if I have something configured incorrectly, but it will work successfully for between 1 to 8 (max so far) casts and catches, then it will bring up the in-game ESC menu and AutoFish will crash/freeze up. Has anyone else experienced this?

I'm in wotlk classic running 1920x1080 windowed mode, DirectX11, logging out option unselected, random sleep unselected, and with whitelist/loot all uncommon and rare.

Bad...

Your autofish fu***d my entire pc.... It started with a slow pause in games but after 2 days with a rtx 3060 and intel i5 12th gen i bearly can open my pc , and i wait 3 min minimum to do an action
.. thx ... Do not install this app...

Bot clicks to early

Is it possible, to add an option, to change the sensitivity of the hook detection?
my Fishbot clicks to early, if i use a bigger bobber

1

Greetings

"No Fish Hooked"

According to /statsbot there is about a 10% chance for missing Fish on retail.

I watched it a little, it will try to Catch, before a Fish is hooked, usually shortly after starting, is there a way to slightly lower the sensitivity of the hooked check ?

An Alternative Issue could be, that the fading Blopper (after loot), is still recognised as valid (new cast) and once fully disapeared it thinks we have a fish hooked, maybe ? This could be fixed by checking if a Blopper is detected before casting again and if so, delay until it faded as much as needed to be below threshold.

Another alternative would be using sound to check if we have a fish on hook.

implement mouse icon change detector?

this is a good bot program.
Here, I present another method, and maybe we can discuss if it's good.

this method is detecting mouse icon changes when the mouse scan line by line across a certain area of the screen.
when the mouse icon change to a hook shape, it means the mouse touches the float. and the scan shall stop immediately, and move downwards a certain distance until it changes back to normal shape.

when you get the fish, the float will move downwards a little and touches the mouse, then the mouse icon will change to a hook shape again, and it's time to click float to catch the fish.

the pros of this method are:
1 it does not rely on graphic driver
2 it does not rely on lighting and will not be influenced by environmental color
3 it will not be influenced by others fishing near you

the only con of this method is you need a lot of clipping and comparing work

Error on main.js start

Hi

Get the following error if i try to start. I use node.js

C:\gg3\app\main.js:246
let powerBlocker = powerSaveBlocker.start("prevent-display-sleep");
^

TypeError: Cannot read properties of undefined (reading 'start')
at Object. (C:\gg3\app\main.js:246:37)
at Module._compile (node:internal/modules/cjs/loader:1267:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1321:10)
at Module.load (node:internal/modules/cjs/loader:1125:32)
at Module._load (node:internal/modules/cjs/loader:965:12)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
at node:internal/main/run_main_module:23:47

Node.js v20.0.0

Whitelist not looting items if there are multiple

Hello! First off, thank you for the bot, it's wonderful.

However, if you get multiple items in the loot window, it will only loot and consider the first one.
It ALSO seems to struggle heavily with actually looting the correct stuff, right now it's avoiding 90% of loot i actually want.
So i have to use the bot with auto loot right now, which is sad because wotlk has a ton of trash loot

Game: WOTLK Classic
UI scale: 1, No addons, Loot window at mouse, auto loot OFF.
Whitelist string "Fangtooth Herring, Bonescale Snapper, Glacial Salmon, Pygmy Suckerfish, Reinforced Crate" (without quotes)

Thank you again!

EDIT: Now it's properly and completely working again. No idea how or why. Changed nothing, oh well, i'm happy!

Feature Suggestion: Items Blacklist or Ignore Vendor Trash / Grey Items ... and some other ideas/issues

An items blacklist or at least a checkbox to discard vendor trash would be very useful. As an alternative, checkboxes for additional classes of items in the whitelist could be useful too.

A checkbox to automatically open up items like clams would also be useful, but that might be more of a stretch since it involves interacting with the item inventory.

I have no idea how a proper workaround for applying lures would work. I can't find any info on how to write a sufficient macro that would solve this as a drop in replacement and then there is the issue of dealing with opening new panels in the game.

Thank you for continuing dev on this. It is a very handy tool.

Can't automatically download chi_sim language data of tesseract.js

Thanks for the brilliant work. The bot works well in the English version, but I had to switch the Game from Chinese to English every time I used the bot.
I tried to set the whitelist to "chi_sim", but it seems the bot can't automatically download the chi_sim language data of tesseract.js.
Are there any other means I could download the chi_sim language data? Thanks again from a Chinses user.

It doesn't find the bobber in 1st person view

Discussed in #66

Originally posted by Darth-Anon February 14, 2024
I was using this today and I noticed the bot trying to click on my pole and not the bobber.

i was in an area where I couldn't switch to the blue detection due to the water being blue and the red of the pole is a damn near exact red to the feather and I couldn't adjust the threshold to get it to differentiate between the two.

I tried zooming my camera all the way in while fishing but the program doesn't seem to like that.

Not applying lure freqvent in wow classic

Hi,

Program works good except the lures.

When I start the program it apply lure (10min) and start fishing.

When lure expire sometimes it apply now but sometimes it dont, and then you start fishing with to low skill and catch nothing.

I have played around with the settings but nothing seems to help to have 100% uptime with the lure.

The lure duration is 10min, and it is 5500ms to apply, just like setting say.

Anyone have any suggestion what this can be? I have done the macro needed etc but its like the bot just is not pressing the key every 10 min like it should.

It doesn't work after I updated the graphics card driver

RTX3060 537.13
After updating the graphics card driver, the game FPS is only 3-5
I reset the screen settings and the FPS became normal.
But the script doesn't work,script says:
[WIN1] The bot can't figure out the background color. Resize or reposition your Fishing Zone or try manual mode.
I tried DX11 and DX12 but neither worked
The DX repair software prompted me that c++ 2015-2019 needs to be repaired but cannot be repaired.(I'm not sure if it has anything to do with this)

Classic client (HermesProxied to Vanilla server) bot stop tracking bobber after certain events

As the title suggests, the bobber-tracking has a few issues:

When you either get a "no fish are hooked" or the "fish got away" message, then it doesnt track the next lure catch. The cursor remains in place at the old location and thus you waste a minute of time every time this occurs because the bot doesnt correct itself until it re-casts.

Also in some rare cases the bot is too slow to catch a fish. So slow that it gets a "no fish are hooked" message, which causes the above issue. This bug means that the issue above will happen much more frequent than actually catching a fish, in certain situations.

and sometimes it tries to reel in prematurely. before anything is hooked.

Unable to scroll loot section with default UI

Greetings! It is a very impressive and usefull project with it's performance and possibilities. But using the latest v2.2.1 release I've faced with issue that the bot cannot scroll the list of loot.
If you have a possibility to find an answer if this feature could be added in upcoming releases?

Suggestion: Let go of moving mouse when person moves mouse

So often I'm on second monitor doing something quick when it forces the cursor to the right position again to grab the lure. However, even though I've already pressed spacebar to stop the automation, it still forces my mouse to move there. No matter how hard I fight against it, at a damn slow pace too. Can you please make it that when outside mousemovement takes place, it drops whatever it's doing and let that movement overrule?

keys values cannot be empty

The bot works fine on my desktop PC, but when I try to turn it on my laptop - gives the following error: "Keys values cannot be empty".
All settings are the same as on a desktop PC, direct 11, full window mode, and fishing on the number 2, but the laptop does not work.

[enhancement]

  • We can use FishingBuddy to improve efficiency. You need to write about this in the readme
  • We can use the addon to cast a fishing rod, but there is a problem - in AutoFish we cannot assign mouse buttons or numpad
  • We can add an option for fishing with an addon that the bot will configure. For example, it will disable the lure check.
  • It is possible to create a simple addon (or modify FB by adding an option to work with AutoFish) that will capture game events such as client messages and lure buff tracking. Then display the relevant events in a small window with color codes to help AutoFish better track those events.
  • You can also do the same as fishing buddy, change equipment, put on lure and other amenities, without using macros, and all on one button

simples
LoseControl.zip
RogueSpam.zip

Notify telegram when bot stops running

Hi,

Thanks for this great bot. Would it be possible to add a feature to send a message to the telegram bot channel when it crashes ? It happened several times that the bot couldn't find the bobber more than 5 times and so stop working without letting me know that it's happening.

Cheers.

Build instructions

Is there some kind of build instructions for this?
How can i build the project under windows?

Switch to RobotJS instead of keysender

Hey,

could you consider switching from keysender to RobotJS? The main problem with keysender is that its windows only (this references #43 )

I'd also like to use this bot while on vacation using my mac or linux notebook. If you're open to it I would try to implement the change and open a PR. If not please let me now so I dont waste any of my time.

[Suggestion] Add staying logged out for X amount of time

Did not see anything about suggestions in the README. Feel free to delete this if not wanted.

Currently advanced settings allow you to log out after random X-Y minutes, but then it logs immediately back in. If we had a setting to stay logged out for X minutes that would be awesome

Profiles

Hi!
I like your Bot, already bought Premium Version :)
Is it possible, to add Profiles to save different settings?

Greetings

Ui scale and lure

My UI scale is set to normal and desktop + wow client are set to 1920x1080. Bot will not click the weapon slot. Using a /script UseAction(); /script PickupInventoryItem(16); /script ReplaceEnchant();
Option to use macro as lure instead of opening character page to apply lure?

Cast lure if bobber not found x number of times

Could you add an option for when we have lures enabled to have it recast lure if the bobber is not found for x number of casts, instead of stopping playback. Would be great sometimes the timing is a little off and it doesn't recast, causing the bobber not to cast in high level fishing zones that are unfishable without lures. Thanks :)

Game Menu Pop Up

Hi, I manage to make work the bot but every few seconds it makes the game menu pop up and stop working. Bye game menu I mean the one you get but simply pressing the ESC keyboard button. And of course when the game menu pop up the bot stop working and I have to reset everything again. Do you have any advice?
I m fishing in zereth mortis for Hirukon, I set the graphics to directx11, disable the vertical thing and turned on auto loot.
Please let me know if you have any solutions, it is unusable like this, and I realllllly want to use it!
Thanks

Color checking

On servers that don't show the bobber animation 100% of the time can be helped by disabling verticle sync. Suggest an option for looking for a blue color on the bobber, as this part will more often "jerk" when a fish is hooked than seeing the lower red portion. Can achieve 100% fish rate if color setting is set to max in some spots. Multisampling a higher depth color helps also, along with increasing (faster) checking time of bobber.

The bot doesn't manage game windows properly in win7

The bot captures the whole screen instead of the game windows and can't set a window foreground if it sets it from anything but the game window itself.

To get around this, open the window of the game in the background and switch to the bot UI, so that you can see the game in the background. After that, move the bot window outside fishing zone and press start (otherwise it will capture the UI of the bot too and surely find some red colors there).

error Can't find any window of the game

my game info :
1.WoTLK
2.Game UI 1.0 is default
3.Game Windows is all screen
4.Enable DX11
but click start error Can't find any window of the game pleass help me thanks!

increase attempt times

hello olesgeras!
can you increase attempt times from 3 to 10,or to customs? it is so easy to stop fishing after 3 times of attempts

Fishing in TBC

Hello, I have found an issue, in the TBC regions. In the region of Hellfire, Zangar, Terokkar, Nagrand... in the upper central part of the screen, the territories conquered by the alliance (blue) or by the horde (red) appear. The problem is that the software detects that red and therefore aborts the fish when it finds more red than the fish.

Would it be possible to release a new version that would ignore any red above a Y coordinate?

Since fishing never goes that high or shouldn't go that high, I think it would be a good solution to ignore the reds on the top of the screen so that these colors shouldn't interfere.

Thank you very much!

Interaction Key not working properly

Sometime the Interaction Key is not pressed/detected by the wow client.

Maybe the "pressed" time is to short for slow system ?

Any chance we get a Interaction Key Pressed for x ms setting ?

I think this would help with the problem.

casting fish key doesnt work

fishing key is 1 and the same in game but when start nothing happend

[00:56:22] [WIN1] Casting fishing... [here said Casting fishing , but nothing happend ]

[00:56:24] [WIN1] Looking for the bobber...

Random Movement not working

It's a shame because I paid only for that feature and it doesn't work. No matter the values I put in movement max or movement step, the bot does like a 90 degree. Even if I put 0 in all boxes or 1, the bot doesn't work.

Suggestion: Let go of moving mouse when person moves mouse

Discussed in #47

Originally posted by sausje August 1, 2023
So often I'm on second monitor doing something quick when it forces the cursor to the right position again to grab the lure. However, even though I've already pressed spacebar to stop the automation, it still forces my mouse to move there. No matter how hard I fight against it, at a damn slow pace too. Can you please make it that when outside mousemovement takes place, it drops whatever it's doing and let that movement overrule?

ERR: Can't find any window of the game!

Cannot start fishing, it only shows following error

[12:20:56] Starting the bot...
[12:20:56] Can't find any window of the game!

Game locale : ZH_CN , so the game window title is "魔兽世界"

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.