I'm submitting a ... <li class="t

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Can't build Unreal Engine plugin on Linux/Mac because of unsupported typeid keyword about jsbsim HOT 5 CLOSED

demonixis commented on July 1, 2024

Can't build Unreal Engine plugin on Linux/Mac because of unsupported typeid keyword

from jsbsim.

Comments (5)

demonixis commented on July 1, 2024 1

In that case, I'll prepare a PR with macos support. Linux support is still on its way because I've some error with the linking process. It's related to Unreal and not JSBSim. I don't know why, but linking the static lib on macos works well. On Linux, the static or dynamic cause linking issue. I've to investigate.

from jsbsim.

demonixis commented on July 1, 2024

I fixed many problems on my branch now the problem is about the typeid keyword that breaks the compilation on Linux and Mac. It's not possible to easilly add rtti without rebuilding the game engine itself.
A quick fix to validate that the plugin can compile on mac/linux is to hack the prop.hxx file like this

static const char* name() { return ""; }// typeid(T).name(); }

But it's not good... So I'm asking for help to find a way to replace typeid OR make it work with Unreal.

from jsbsim.

seanmcleod commented on July 1, 2024

So are you saying that the Unreal engine on Windows is built with rtti enabled but not by default on Mac and Linux?

from jsbsim.

demonixis commented on July 1, 2024

Well I'm not sure but it doesn't compile on Linux and macOS. However with the "hack" it compiles fine... I was able to run launch the Unreal project on macOS and I'll try on Linux too later today.

I suppose that there is no easy workaround and returning an empty string is not a good solution right?

JSBSim Unreal on macOS ;)

from jsbsim.

bcoconni commented on July 1, 2024

@demonixis, actually you can safely delete the code lines 1881-1929 in src/simgear/props/props.hxx, these are unused by JSBSim.

jsbsim/src/simgear/props/props.hxx

Lines 1881 to 1929 in 10c6e52

 namespace simgear 

 { 

 /** 

  * Default trait for extracting enum values from SGPropertyNode. Create your 

  * own specialization for specific enum types to enable validation of values. 

  */ 

 template<class T> 

 struct enum_traits 

 { 

 /** 

  * Typename of the enum 

  */ 

 static const char* name() { return typeid(T).name(); } 

 /** 

  * @return Default value (will be used if validation fails) 

  */ 

 static T defVal() { return T(); } 

 /** 

  * @return Whether the given integer value has an enum value defined 

  */ 

 static bool validate(int) { return true; } 

 }; 

 } // namespace simgear 

 /** Extract enum from SGPropertyNode */ 

 template<typename T> 

 #if PROPS_STANDALONE 

 inline T 

 #else 

 inline typename boost::enable_if<boost::is_enum<T>, T>::type 

 #endif 

 getValue(const SGPropertyNode* node) 

 { 

 typedef simgear::enum_traits<T> Traits; 

 int val = node->getIntValue(); 

 if( !Traits::validate(val) ) 

 { 

 SG_LOG 

 ( 

 SG_GENERAL, 

 SG_WARN, 

 "Invalid value for enum (" << Traits::name() << ", val = " << val << ")" 

 ); 

 return Traits::defVal(); 

 } 

 return static_cast<T>(node->getIntValue()); 

 }

Once you're happy with your code (including deleting the lines mentioned above), you can submit a PR.

from jsbsim.

Can't build Unreal Engine plugin on Linux/Mac because of unsupported typeid keyword about jsbsim HOT 5 CLOSED

Comments (5)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	namespace simgear
	{
	/**
	* Default trait for extracting enum values from SGPropertyNode. Create your
	* own specialization for specific enum types to enable validation of values.
	*/
	template<class T>
	struct enum_traits
	{
	/**
	* Typename of the enum
	*/
	static const char* name() { return typeid(T).name(); }

	/**
	* @return Default value (will be used if validation fails)
	*/
	static T defVal() { return T(); }

	/**
	* @return Whether the given integer value has an enum value defined
	*/
	static bool validate(int) { return true; }
	};
	} // namespace simgear

	/** Extract enum from SGPropertyNode */
	template<typename T>
	#if PROPS_STANDALONE
	inline T
	#else
	inline typename boost::enable_if<boost::is_enum<T>, T>::type
	#endif
	getValue(const SGPropertyNode* node)
	{
	typedef simgear::enum_traits<T> Traits;
	int val = node->getIntValue();
	if( !Traits::validate(val) )
	{
	SG_LOG
	(
	SG_GENERAL,
	SG_WARN,
	"Invalid value for enum (" << Traits::name() << ", val = " << val << ")"
	);
	return Traits::defVal();
	}
	return static_cast<T>(node->getIntValue());
	}