Comments (4)
seanmcleod
commented on July 19, 2024
Okay, so what you're pointing out is that when parsing the input parameter fname the assumption is that it has the form:
hostname:proto/port
But when then generating the model name, Name, from the components based on parsing, it's generating the model name as:
hostname:port/proto
from jsbsim.
fishpro
commented on July 19, 2024
yes,
That's what it means
from jsbsim.
seanmcleod
commented on July 19, 2024
Okay and looking at the code that calls FGOutputSocket::SetOutputName() the correct format is:
hostname:proto/port.
jsbsim/src/input_output/FGOutputSocket.cpp
Lines 115 to 122 in 92fa1ea
So the model name Name is incorrect. Not sure off-hand where the model name Name is used, possibly for display purposes somewhere.
I see the comment in the header file is incorrect, it has swapped port and protocol around.
So we should update the comment in the header file and updated the Name.
Do you want to submit a pull request (PR) or do you want me to go ahead and generate a pull request?
from jsbsim.
bcoconni
commented on July 19, 2024
Do you want to submit a pull request (PR) or do you want me to go ahead and generate a pull request?
I guess you can submit the PR @seanmcleod.
from jsbsim.
Related Issues (20)
- JSBSim Simulink Function HOT 36
- Rust HOT 13
- Can autopilot feature come to jsbsim- unreal engine 5? HOT 2
- MSVC: toupper is not a member of std HOT 1
- Missing target_include_directories in libJSBSim
- JSBSIM_ prefix in CMake options
- Cython warnings about 'tp_print' which is deprecated
- Wrong calculation of vPQRdot in FGAccelerations class HOT 4
- Fixing the mixture for JSBSim piston aircraft HOT 54
- Request: turbine spindown table or property support HOT 2
- Aircraft crashed on air when rolling consecutively HOT 15
- How Jsbsim models the "+" shaped tail fins of missiles and rockets. HOT 1
- JSBSimFlightDynamicsModel could not be loaded in Unreal Engine HOT 4
- AugmentCmd should be clamped to [0.0..1.0] HOT 5
- Transfer function make JSBSim close down HOT 2
- unresolved external symbol(s) logging/console related HOT 5
- Request: Unreal Marketplace Plugin HOT 5
- JSBSim can't interpolate between n dimensions
- Robocopy step errors if spaces in path.
- Keyboard/Gamepad input non-functional in Unreal Plugin Project HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jsbsim.