jsdom / js-symbol-tree Goto Github PK

Version 8.2.6 of babel-eslint was just published.

This version is covered by your current version range and after updating it in your project the build failed.

babel-eslint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

This is due to a duplicate declaration in SymbolTree.js:

symbol-tree/lib/SymbolTree.js: Duplicate declaration "index"
  481 |                 }
  482 | 
> 483 |                 let index = childNode.getCachedIndex(parentNode);
      |                     ^
  484 | 
  485 |                 if (index >= 0) {
  486 |                         return index;

I am running into some tricky initialization time issues in jsdom and need something like domSymbolTree.isInitialized(node), so I can bail out early if we're still in the pre-symbol-tree phase.

The devDependency tape was updated from 4.12.0 to 4.12.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

tape is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

When items are repeatedly added to and removed from new trees, the symbols stay and start clogging up the memory. Don't know if this is necessary by design or not.

My simple test:

const SymbolTree = require('symbol-tree');

const base = [];
for(let i=0; i<100; i++) {
	base.push({ content: i });
}

for(let i=0; i<1000; i++) {
	let tree = new SymbolTree();
	let root = { root: true };
	base.forEach(obj => {
		tree.appendChild(root, obj);
	});

	let it = tree.childrenIterator(root);
	for( child of it ){
		tree.remove(child);
	}
	console.log(JSON.stringify(process.memoryUsage()));

}

When I use the Iterator, I would want to know the level of a node.
Is there a (low complexity) way to have the level of a node?

Level: "The level of a node is defined as: 1 + the number of edges between the node and the root."
Depth: "The depth of a node is the number of edges from the tree's root node to the node."
(from Wikipedia)

Would be also interesting to have other characteristics about the tree:

• is Branch node (or is Internal node)
• Height of node
• Height of tree
• Depth

I can understand strange preferences for 8-space indents. Even tabs. But newlines before braces? That is just crazy-sauce. (In part due to the return hazard, but also just because absolutely nobody does it.)

Feel free to close if you really want to keep this :P

api.md is 404

Up to you, but if you do let me know. We've put a few things there.

Would be a lot more readable I think :)