Giter VIP home page Giter VIP logo

conductormvp's Introduction

ConductorMVP

Build Status

The source code in this repo accompanies my article Creating Clean Architecture Multi-Project MVP App.

Here you will find a multi-project single Activity TODO app using Conductor implementing MVP pattern (each Controller is a View).

Main Libraries

  • Conductor
  • Room (with fully reactive data types)
  • RxJava 2 and RxAndroid
  • Dagger 2 with custom scopes
  • ButterKnife for view binding

Multi-Project setup

The app is configured as multi-project Gradle setup which improves build and testing speed in addition to providing clear isolation between the components of the app:

  • domain module contains business logic/use-cases/repository interfaces as well as Model
  • data module contains implementation of the domain layer abstractions
  • presentation module contains Views and Presenters as well as Dependency Injection setup that glues all layers together

Relationship between modules

This setup enables you to swap your backend implementation (for instance, migrate to Firebase or Realm) simply by replacing your data layer module and modifying a dependency in the presentation module. If the data layer changes, domain layer is not affected.

Screenshots

List of notes

Note detail

Edit a note

Code Quality

This project aims to maintain high test coverage for all modules.

Unit test code coverage is at 96% (Views are excluded from unit tests since they are rather passive).

Main libraries used for testing are:

  • JUnit
  • Mockito-kotlin
  • Hamcrest
  • Jacoco

License

Copyright 2017 James Shvarts

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

   http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

conductormvp's People

Contributors

jshvarts avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

conductormvp's Issues

Doublme dependencies block

Hello,
In the domain gradle file why do you have double dependencies block ?
dependencies {
compile "org.jetbrains.kotlin:kotlin-stdlib-jre8:$kotlin_version"

implementation libs.rxJava
implementation libs.rxAndroid
implementation libs.junit

}

and

dependencies {
// RxJava and RxAndroid
implementation libs.rxJava
implementation libs.rxAndroid

// JUnit
testImplementation libs.junit

// Mockito Kotlin
testImplementation libs.mockitoKotlin

}

Dependecy Injection with Dagger through Android Injector

According to your own article, regarding the new Dagger Android Injection and the external references, the purpose of these changes within the API is to ensure the following Dependency Injection principle

"A class shouldn’t know anything about how it is injected."

Having said that, is it possible to apply Dependency injection through Android Injector within this Clean Architecture? Which are the limits or disadvantages of it and why do you keep "the old way"?

ConductorMVP + RxJava?

This boilerplate/demo project with Conductor over MVP is perhaps one of the best out there. It'd be great to see your take on RxJava on top of this work. It would make another great medium post.

Again, great work!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.