This is about the 50th django project that has moved to Github, but has left their Google Code project alive. It's quite irritating when trying to see what projects are out there.

I see there's a note on the Google Code page about the move, but it's at the bottom of the intro page. Instead of having the intro page at all, we should kill the project on Google Code or remove all text except for the redirect link.

Is this something we can do?

After accepting a friend request and creating a user account with the same email, the email_confirmed signal is not sent even though the email address is marked as validated. This results in the user account never being marked active.

This bug happens in model.py at:

  def add_email(self, user, email):
     try:
        email_address = self.create(user=user, email=email)

If this throws an IntegrityError (e.g. user and email already exist), Django fails when handling session and Cookies at the end with the HTTP return. This seems to be related to psycopg2, which cannot simply continue accessing the database when an IntegrityError was raised.

Here's a Danish locale file for the project:

http://www.daimi.au.dk/~illio/pinax/emailconfirmation/django.po

For django-allauth I am running into an issue where Facebook hands over email addresses that are longer than 75 characters. For reference, also refer to:

http://code.djangoproject.com/ticket/11365

As Django will not be fixed, I was hoping that email-confirmation could switch to max_length=254 so that it can handle long email addresses.

Your signals.py file seems to b missing. I am getting import errors, and but the one from pypi contains the file

Hi

Thanks for you code it helped me greatly in my project

I found few issues to make the sample "devproject" to run on django 1.1 , I have made the changes and can provide you the same, so that one need not modify it again

Please let me know the procedure to submit the code

Regards
Subramanyam

django-email-confirmation misses some obvious database indexes

We found this issue when using email-confirmation on really large databases.

2 issues found:
EmailConfirmation.confirmation_key <- you always do a lookup with confirmation_key as key
EmailAddress.email <- when looking for dups etc, you query on this key

patch below:

Index: 3rdparty/django-email-confirmation/emailconfirmation/models.py
===================================================================
--- 3rdparty/django-email-confirmation/emailconfirmation/models.py      (revision 417)
+++ 3rdparty/django-email-confirmation/emailconfirmation/models.py      (working copy)
@@ -44,7 +44,7 @@
 class EmailAddress(models.Model):

     user = models.ForeignKey(User)
-    email = models.EmailField()
+    email = models.EmailField(db_index=True)
     verified = models.BooleanField(default=False)
     primary = models.BooleanField(default=False)

@@ -135,7 +135,7 @@

     email_address = models.ForeignKey(EmailAddress)
     sent = models.DateTimeField()
-    confirmation_key = models.CharField(max_length=40)
+    confirmation_key = models.CharField(max_length=40,db_index=True)

     objects = EmailConfirmationManager()