Giter VIP home page Giter VIP logo

angularjs-code-review-checklist's Introduction

I'm not the author of this amazing checklist, i've only copied it in a readable and printable way. The original site if here

#Code Style

  • Is all code intention-revealing?

  • Is all code linted/hinted?

  • Is controller as syntax used?

  • Is DOM manipulation handled only by directives?

  • Are names prefixed with $ avoided?

  • Is direct use of globals avoided?

  • Are AngularJS specific directives put after standard attributes in templates?

  • Are built-in AngularJS dependencies injected before custom ones?

  • Are modules named correctly?

  • Are controllers named correctly?

  • Are directives named correctly?

  • Are filters named correctly?

  • Are services named correctly?

  • Are factories named correctly?

  • Are built-in AngularJS directives used whenever possible?

  • Are built-in AngularJS services used whenever possible?

  • Is ng-cloak used to prevent content from flashing

  • Is console.log() avoided?

  • Is code minification safe?

Architecure

  • Is there a component-driven structure?

  • Do directives communicate correctly?

  • Is business logic defined in services?

  • UI-Router: has a default route been configured?

  • ngRoute: has a default route been configured?

  • ngRoute: are route errors handled properly?

  • UI-Router: are state change errors handled properly?

  • Are exceptions handled properly?

  • Are resolves used where needed?

Security

  • Is Strict Contextual Escaping enabled?

  • UI-Router: are private parts of application properly protected?

Performance

  • Are scripts at bottom of the document?

  • Are styles in HEAD?

  • Is expensive logic avoided in filters?

  • Is filtering logic handled in controller if needed?

  • Are expensive operations cached?

  • Are complex expressions avoided in templates?

  • Is one-time binding used where possible?

  • Is logic in watchers kept as simple as possible?

  • Is $watchCollection used instead of deep watch where possible?

  • Is $applyAsync used when possible?

  • Do timers skip $digest cycle when possible?

  • Are resources cleaned up when scope is destroyed?

  • Are templates bundled with main JavaScript file?

  • Is ngModelOptions used where possible?

angularjs-code-review-checklist's People

Contributors

juancarloscruzd avatar

Stargazers

 avatar

Watchers

 avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.