Giter VIP home page Giter VIP logo

hello-portfolio's Introduction

hello-portfolio's People

Contributors

iptysam avatar juaryimami avatar mhamedgd avatar

Stargazers

 avatar

Watchers

 avatar

Forkers

iptysam

hello-portfolio's Issues

Peer to peer review week 3

Excellent Job ๐Ÿ‘

Good GitHub workflow
no linter errors

Please correct the following suggestions:

  • For better Semantic meaning nav tag can stand alone without the Header tag.
  • We suggest the use of prettier and eslint extension for better code flow
  • We suggest linking your tag to the specified roots for enhancing functionality

Peer to peer Code Review.

Adel's Suggestion:

The "checlocal" works but it is over engineered, You can get by with the same functionality with only 3 lines of code,

  • if data is in localStorage: Update the values of the form elements;

Ikon's Suggestion:

Agrees with Adel's.

Mohammed's Suggestion:

Juhar wrote the code well because it's readable, and beginner user friendly.

Ikon-Kenny-Okei Peer-to-Peer code review

Ikon's comment

  • Good job implementing CSS DRY code principles, we suggest, for the popup its better for the elements to contain the max size of the container, rather than having a space on one side as it is.

Kenny's comment

  • Good code, however, we suggest you put the verified link to your website.

Okei's comment

  • Nice job, clean code, however I suggest you reduce the number of classes used in your code.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.