juicy / juicy-markdown Goto Github PK

Wth Shadow DOM enabled using this method:

    <script src="/sys/webcomponentsjs/webcomponents.js"></script>
    <script>
        window.Polymer = window.Polymer || {};
        window.Polymer.dom = "shadow";
    </script>
    <link rel="import" href="/sys/polymer/polymer.html">

I get the following error:

Are there any plans to update the component to work with Polymer 1.0?

I'm not 100% sure this is an issue with marked so I'll start here

I get the following exception when using Marked in a web component. The result displays so I don't think it's a Marked error. May this be related to why the page is not updating when I make css changes after the first load?

This is how I'm using Juicy Markdown

 <juicy-markdown value="{{doc}}"   ghcss="false"></juicy-markdown>   

This is the exception I get in Chrome 39.

 Exception caught during observer callback: TypeError: Cannot read property 'replace' of null
Please report this to https://github.com/chjj/marked.
    at Lexer.lex (http://localhost:8888/athena-document/bower_components/marked/lib/marked.js:137:5)
    at Function.Lexer.lex (http://localhost:8888/athena-document/bower_components/marked/lib/marked.js:128:16)
    at marked (http://localhost:8888/athena-document/bower_components/marked/lib/marked.js:1201:31)
    at juicy-markdown.Polymer.parseText (http://localhost:8888/athena-document/bower_components/juicy-markdown/juicy-markdown.html:72:53)
    at juicy-markdown.Polymer.valueChanged (http://localhost:8888/athena-document/bower_components/juicy-markdown/juicy-markdown.html:68:10)
    at juicy-markdown.properties.invokeMethod (http://localhost:8888/athena-document/bower_components/polymer/polymer.js:9355:12)
    at juicy-markdown.properties.notifyPropertyChanges (http://localhost:8888/athena-document/bower_components/polymer/polymer.js:9344:20)
    at Object.Observer.report_ (http://localhost:8888/athena-document/bower_components/polymer/polymer.js:4890:24)
    at Object.createObject.check_ (http://localhost:8888/athena-document/bower_components/polymer/polymer.js:5296:12)
    at callback (http://localhost:8888/athena-document/bower_components/polymer/polymer.js:4788:20)polymer.js:4893 Observer.report_polymer.js:5296 createObject.check_polymer.js:4788 callback

As decided last week with @tomalec, we are deprecating this repo.

juicy-markdown is perfectly replaceable with marked-element.

@tomalec the master branch and gh-pages have diverged.

What is more, the commits 0bb5ca9 and 0bb5ca9 are kind of similar, so I would not like to do a dumb merge.

Could you please review this and sync the branches?

When I do bower install juicy/juicy-markdown, the following package is installed:

github-markdown-css

juicy-markdown never uses it, though.

Instead, it uses a hardcoded URL to GitHub Pages:

    <!-- New way to do template if tags -->
    <template is="dom-if" if="{{ghcss}}" restamp>
        <link rel="stylesheet" type="text/css" href="http://juicy.github.io/github-markdown-css/github-markdown.css">
    </template>

This should be changed for two reasons:

• GitHub Pages is not a CDN
• We should not assume using a public CDN

I'm working on a project that pulls data from a third party API. The Markdow contains HTML content that is not rendered with juicy-markdown. For example:

To access the free version of this course, click the blue button that says <em>Access Course Materials.</em> is rendered with HTML markup instead of rendering italics for em

<a href="https://www.udacity.com/course/ud853" target="_blank">Developing Android Apps. Following Android's <a href="http://developer.android.com/distribute/essentials/quality/core.html" target="_blank">Core App Quality Guidelines, we'll identify the production criteria that still needs to be implemented, then tackle each problem until Sunshine is ready to publish on the Google Play Store. In the process, we'll introduce you to a host of tools and concepts, including: material design approaches, image-handling, performance profiling, and more!

Is there a workaround for this?

During updating elements in kitchensink I found out that juicy-markdown uses old versions of 2 elements:

is there any reason why shouldn't those be updated?

cc @tomalec