juicy / juicy-popover Goto Github PK

Add new positions: beforetop center and bottom center

cc @pileqrai

Steps to reproduce

Use the element with a standard setup. The hard-coded z-index value for the expandable element can be too restrictive for some usage.

We may need to increase its value or decrease it.

Expected result

z-index on the expandable CSS id can be customize to match the application context.

Actual result

z-index is hard-coded to 999.

Browsers affected

• Chrome
• Firefox
• Edge
• Safari 9
• Safari 8
• IE 11

Are there any plans to update to be module based?

#4 introduced a typo in the API. Slot name expendable should be called expandable.

Should we fix or alias the API? I vote for aliasing, to avoid yet another breaking change. juicy-popover is used in many apps.

cc @tomalec

Hello.
It seems that the bower package has a problem.

$ bower install juicy-popover --save
bower    invalid-meta The "name" is recommended to be lowercase, can contain digits, dots, dashes
bower    ENOTFOUND Package juicy-popover not found

Al the best,
Hervé

Right now, when I click on the body of the expandable, unless on an <input> element, the expandable collapses.

It should only collapse when clicked outside.

I propose to change

this.ignore = true;

Currently, juicy-popover expands on mousedown event and collapses on mousedown outside.

Add a new attribute expand-event (and perhaps collapse-event?) that allows to specify alternative events, such as mouseover (mouseenter?)

cc @pilqerai

It would be good to have a test suite, even basic one, like for other Juicy elements

• https://travis-ci.org/Juicy
• https://github.com/Juicy/juicy-composition/tree/master/test

This custom element has a variant of the following line:

var script = document._currentScript || document.currentScript;
var template = script.previousElementSibling;

document._currentScript was only needed in IE11, but Starcounter does not support that browser anymore.

Therefore, this code can be simplified to:

var template = document.currentScript.previousElementSibling;

If we want to drop support for IE11.

This repo uses .bowerrc file which causes it to act arcane - when you type bower install, the dependencies get installed in the parent directory.

Proposed solution - remove .bowerrc and recommend using polyserve.

Same thing was done in Juicy/juicy-select#8