Giter VIP home page Giter VIP logo

imagesmooth.jl's Introduction

ImageSmooth

Stable Dev Build Status Coverage

Algorithms Preview References
L0Smooth() L0Smooth_preview Image Smoothing via L0 Gradient Minimization

imagesmooth.jl's People

Contributors

github-actions[bot] avatar jkay0327 avatar johnnychen94 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

Forkers

jkay0327

imagesmooth.jl's Issues

Potential performance tweak on L0smooth

Tweaking performance can be very difficult and there's no plan to investigate this issue. Running profiler gives me two suspicious performance hotspot

  1. ImageFiltering.freqkernel: https://github.com/johnnychen94/ImageSmooth.jl/blob/1cb03e8949585e3431095e5869e706175df8e103/src/algorithms/l0_smooth.jl#L117-L118
  2. fft! on complex number: https://github.com/johnnychen94/ImageSmooth.jl/blob/1cb03e8949585e3431095e5869e706175df8e103/src/algorithms/l0_smooth.jl#L159-L163

TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Linear filtering?

I'm quite excited to see this package, nice work @JKay0327 and @johnnychen94.

I'm curious about the right way to handle the comparison to smoothing operations like Gaussian blur. There seem to be at least two options:

  • add a LinearBlur(ฯƒ...) algorithm here that is just a convenience method to imfilter with a KernelFactors.gaussian kernel
  • declare that this package focuses on nonlinear methods, and link to ImageFilter for linear methods

I'd be happy to make a PR at some point, but I thought it would be best to hear which of these you think makes more sense. I'd be happy with either outcome.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.