juninhokaponne / friendrecomendation Goto Github PK

from src/controller/PersonController.js
line - 9

if (!cpf || cpf.toString().length !== 11) {
      throw new AppError("CPF must contain exactly 11 numeric digits.", 400);
    }

as we already have in - src/middleware/validateCPF.js

Hey, I would love to contribute to this project and develop a landing page with proper info on how to proceed for the same.

Hey @juninhokaponne ,

I hope you're doing well. I was going through the project, and I must say it's quite interesting. I've reviewed the functional requirement document and noticed that your algorithm currently focuses on unidirectional recommendations.

To clarify, in the current setup, if 'A is a friend of B, A is a friend of C, B is a friend of D, C is a friend of D and E,' and we ask for a recommendation for A, the output will be D and E. However, for entities B, C, D, and E, there would be no recommendations, resulting in an empty response.

My question is whether we are intentionally focusing on implementing unidirectional relationships, or if we have the flexibility to enhance the algorithm to consider bidirectional relationships as well. In other words, if A is a friend of B, it implies that B is also a friend of A.

I hope this clarifies the objective I wanted to discuss. Looking forward to your insights on this matter.

confused to do so , sir please help me , how i can acheive that things

Example - Move this to controller file with specific file and then exports from the controller
(req, res) => {
const { cpf, name } = req.body;
const result = personController.createPerson(cpf, name);
res.status(result.error ? 400 : 200).send(result);
}