junosuarez / minq Goto Github PK

Rather than implementing, eg, Query#deferOne for each finalizer, have a Query#defer() function which alters the behavior of the finalizers.

Eg byId -> byIds rewrite
Experiment
Hinting? Automatic?

@jden i upgraded the underlying mongo driver to the last stable 1.x version; can you check it out and if it looks good pub to npm.

add a Query#cache() method to trigger use of a caching plugin, if available.

can use in conjunction with Query#byId and Query#byIds. Possibly formalize this in a post-processing step so other chained custom query functions can use it.

cache plugin should have interface:{
get:
put: or set: (support either, prefer put)
del:
}

currently fails silently if called with undefined or empty string; should throw

ex: http://mongodb.github.io/node-mongodb-native/driver-articles/anintroductionto1_1and2_2.html#aggregation-framework-helper

proposal: minq(conn).from(collection).aggregate([piplineObject,...]).toArray() returns promised result of the aggregation

thoughts?

Add pre- and post- execute query hook
Minq.use() syntax, mixin fluent helpers (see chai)

https://gist.github.com/jden/7883441

possibly as a separate module

using minq 1, rc 8; ubuntu 14.04; node 0.10.26; npm 1.4.3

setup

var connstr = process.env.DB_CONN_STRING;
var minq = require('minq');

minq.connect(connstr).then(function (db) {
  console.log('connected: ' + connstr);

  return db
    .from('CollectionName')
    .forEach(function (data) {
       console.log(data);
    });
})
.then(function () {
  console.log('done');
});

expected

a log of each item in the collection

> {}
> {}
...

actual

TypeError: Object #<Object> has no method 'forEach'
    at /home/test.js:23:15
    at Writable.stream._write (/home/node_modules/minq/node_modules/charybdis/index.js:51:14)
    at doWrite (_stream_writable.js:226:10)
    at writeOrBuffer (_stream_writable.js:216:5)
    at Writable.write (_stream_writable.js:183:11)
    at Stream.ondata (stream.js:51:26)
    at Stream.EventEmitter.emit (events.js:95:17)
    at drain (/home/node_modules/minq/node_modules/through/index.js:36:16)
    at Stream.stream.queue.stream.push (/home/node_modules/minq/node_modules/through/index.js:45:5)
    at Stream.<anonymous> (/home/node_modules/minq/mongodb.js:85:50)

notes

interestingly, if you add a select(['_id']) it works fine; however if you add any other element to the select, it fails with the same error

http://docs.mongodb.org/manual/applications/update/#update-multiple-documents

E.g., .update() operations should take place even without a .then() handler

add a Query#expect method to throw a NotFoundError if the actual number of documents returned is less than the number expected.

If used in conjunction with Query#byIds, Query#byId, Query#one, and Query#deferredOne, default to the appropriate number.

Current behavior is it will return null or an empty array.

aggregation queries are broken

Promises/A+
cps
Continuables

getCollectionNames should return an array of strings with collection names, not including the db name. if the db name contains, eg, a -, the collection name is returned including the db name, eg:

['test-db.foos','test-db.bars'] should be ['foos','bars']

Return Query instances which are lazy promises, to allow returning partial queries which can be further modified, restricted, etc.

Callable any time before the query is finalized,, create a new Query object with the same parameters (db, collection, query, options, etc)