Giter VIP home page Giter VIP logo

Comments (9)

jupe avatar jupe commented on July 17, 2024 1

Implemented here #18 :) See https://github.com/jupe/onkyo.js/pull/18/files#diff-04c6e90faac2675aa89e2176d2eec7d8R122R125

from onkyo.js.

VonOx avatar VonOx commented on July 17, 2024

Error when trying getVolume()

Error: Command for 'AUDIO:STATUS' not defined
    at Promise.try (......\node_modules\onkyo.js\lib\Onkyo.js:540:15)

setVolume() is working fine

from onkyo.js.

jupe avatar jupe commented on July 17, 2024

oh, thats true. My mistake. Here ia patch for it:
#23

from onkyo.js.

jupe avatar jupe commented on July 17, 2024

actually there was typo in test which causes this bug leak.. anyway - patch is merged and should work now as expected.

from onkyo.js.

Codelica avatar Codelica commented on July 17, 2024

Thanks for the module. :) Just a quick note that I think the hex volume string sent may need to be upper case. At least in my case (with an Onkyo 818) volume commands that result in lowercase hex letters like "!1MVL1e" would fail.

Changing the volumeHex as follows fixed it:

const volumeHex = volume.toString(16).toUpperCase();

Thanks..

from onkyo.js.

jupe avatar jupe commented on July 17, 2024

could you open new issue, or PR? Sounds like easy to fix, but I’ve to double check if it still works with my receiver..

from onkyo.js.

jupe avatar jupe commented on July 17, 2024

I'll create new PR to fix uppercase issue, coming soon..

from onkyo.js.

jupe avatar jupe commented on July 17, 2024

https://github.com/jupe/onkyo.js/releases/tag/v0.6.1

Thanks for the module. :) Just a quick note that I think the hex volume string sent may need to be upper case. At least in my case (with an Onkyo 818) volume commands that result in lowercase hex letters like "!1MVL1e" would fail.

from onkyo.js.

Codelica avatar Codelica commented on July 17, 2024

Thanks for the speedy update! 👍

from onkyo.js.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.