Comments (9)
Implemented here #18 :) See https://github.com/jupe/onkyo.js/pull/18/files#diff-04c6e90faac2675aa89e2176d2eec7d8R122R125
from onkyo.js.
Error when trying getVolume()
Error: Command for 'AUDIO:STATUS' not defined
at Promise.try (......\node_modules\onkyo.js\lib\Onkyo.js:540:15)
setVolume()
is working fine
from onkyo.js.
oh, thats true. My mistake. Here ia patch for it:
#23
from onkyo.js.
actually there was typo in test which causes this bug leak.. anyway - patch is merged and should work now as expected.
from onkyo.js.
Thanks for the module. :) Just a quick note that I think the hex volume string sent may need to be upper case. At least in my case (with an Onkyo 818) volume commands that result in lowercase hex letters like "!1MVL1e" would fail.
Changing the volumeHex as follows fixed it:
const volumeHex = volume.toString(16).toUpperCase();
Thanks..
from onkyo.js.
could you open new issue, or PR? Sounds like easy to fix, but I’ve to double check if it still works with my receiver..
from onkyo.js.
I'll create new PR to fix uppercase issue, coming soon..
from onkyo.js.
https://github.com/jupe/onkyo.js/releases/tag/v0.6.1
Thanks for the module. :) Just a quick note that I think the hex volume string sent may need to be upper case. At least in my case (with an Onkyo 818) volume commands that result in lowercase hex letters like "!1MVL1e" would fail.
from onkyo.js.
Thanks for the speedy update! 👍
from onkyo.js.
Related Issues (10)
- Add optional port configuration HOT 4
- No error handling in Connect() method HOT 2
- Additional commands HOT 2
- OnkyoDiscover class is not exposed HOT 4
- Enhancement: Add isOn() isOff() HOT 4
- isOn and isOff to promises
- unknow_msgs HOT 6
- onkyo.js available in Node-Red HOT 3
- Timeout when using SPEAKER_AB_CONTROL commands? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from onkyo.js.