Giter VIP home page Giter VIP logo

Comments (4)

jupe avatar jupe commented on July 17, 2024

yamaha-nodejs implementation for isOn()/isOff() looks like it returns true/false depend on cached status - right ? in fact there is cache for these already - onkyo.deviceState.PWR -for example, which should tell if powers are on/off. I could add functions for it like you proposed :)

from onkyo.js.

VonOx avatar VonOx commented on July 17, 2024

Yes you are right.

I just think this is more natural, I have already implemented deviceState so this is not a problem right now.

Just an idea. Feel free to close this issue😉

from onkyo.js.

jupe avatar jupe commented on July 17, 2024

sorry, I did it already and released to npm :D

from onkyo.js.

jupe avatar jupe commented on July 17, 2024

I just looked a vit more deeply yamaha library and yes it is Promise api - it was wrapped to promise based here: https://github.com/PSeitz/yamaha-nodejs/blob/0bd1d83371061332a30bfefbb2f9d76c6c5002bf/simpleCommands.js#L452 .

So onkyo.js behaviours now a bit different than yamaha lib for isOn and isOff -functions. Perhaps I should switch that to Promise based - at least it is always up-to-date because no cached value needed..

from onkyo.js.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.