just-an-dev / sodogetip Goto Github PK

mark message as read only after action made with success :)

History is only showing outgoing transactions, it's not showing any incoming transactions.

add an sell/buy order book, to permit users exchange currency

remove config params :

• user_file
• user_history_path
• unregistered_tip_user

use DATA_PATH instead

Edit : not remove but use DATA_PATH

add reddit gold credits ticket payment system

Hi how do i use my reddit account and use this tipbot? I want to put it on my sub reddit

add to info and +balance command amount of pending tip to unregistered users

maybe a command to be detail of this tips ?

What about give the ability to users to import their addresses in order to let them own private key?
This would give user quite more confidence on security (especially after recent crack of dogetipbot)
Been a blockchain based tipbot, This should not be a problem

The code is very hard to look at as-is.

example: # help_user(rpc, msg) is responsible for the +help command

As published, there is no explicit permission for anyone to modify sodogetip, even if the only purpose is to contribute back.

Please include the license terms for this software so that contributors may know their permissions.

Not enough funds
Poor bastard alert
Fake tip. Sad (ala trumpet tweets)
Such poverty wow

I used the faucet to get 2,000 DOGE, then sent 4 tips of 1,999. The bot replied that it tipped, but none of the transactions show up on the chain.

Tip 1: https://www.reddit.com/r/dogecoin/comments/6a8k34/new_tipbot_running_on_testnet_help_us_test_and/dhdvlf1/

Tip 2: https://www.reddit.com/r/dogecoin/comments/6a8k34/new_tipbot_running_on_testnet_help_us_test_and/dhdvsvc/

Tip 3: https://www.reddit.com/r/dogecoin/comments/6a8k34/new_tipbot_running_on_testnet_help_us_test_and/dhdvsym/

Tip 4: https://www.reddit.com/r/dogecoin/comments/6a8k34/new_tipbot_running_on_testnet_help_us_test_and/dhdw0az/

Dogechain showing my transactions: https://chain.so/address/DOGETEST/ndvBrYrYqcqxgUVH3nYL3zSvq6iav9jTZ2

I always liked the idea of tipping directly to an address, but it comes with a certain risk. If a reddit account is compromised, there are little chances to secure the tipbot balances. But what if some malicious script/code/whatever tricks a user into sending a withdraw command?

There should be some kind of a text captcha asking for an answer to a (maybe simple math) question. This would not secure your funds if your account has been "broken into", but it would prevent automatic attempts. It should be active for all commands that transfer doges out:

• tips to addresses
• tips over 1000 doge
• withdrawals

on help command we have empty value for balance instead 0

maybe to 30 last entry

reduce level of logs making by module praw

After a small outgoing transaction, some of the remaining dogecoins are in an unconfirmed transaction. +balance result does not account for these dogecoins. It appears to the user that the balance is handled incorrectly.

In order to have a balance we have to dm the bot with +balance in subject and object.
First Time it's work properly, then you you just replay +balance on same message, it will not work.
We need instead to open a new dm.

Should be possible to consider also the replay on the same thread?

My bot wallet address is: DGYYfxPkr8kuwhmmKJU17eoqoU9Qu2zkRL https://chain.so/a/cnyi8zq

On reddit the +info says:

Here are your account details /u/GaryLittlemore!
very info
Your balance 7575 doge $24.7
Your pending balance 0 doge $0.0
Your spendable balance 7575 doge ($24.7)
Deposit address DGYYfxPkr8kuwhmmKJU17eoqoU9Qu2zkRL

The blockchain says:

Balance 8,075.00000000
Pending Nothing
Received 346,642.00000000
Transactions 41

The bot balance is 500d less than the blockchain.

As you can see below, I've received the message with a wallet address after the register request, I'd requested some Doge via a testnet faucet, then I requested a balance to be told 'You need register before'. I had already registered.

re: +register
from sodogetiptest sent 11 hours ago
GaryLittlemore registered, your address is nqKNVFNDpC6PSxPcYHrwmf7A62vchy82f5

re: +balance
from sodogetiptest sent 39 minutes ago
You need register before

send message to operator when bot haven't gold credits

keep a separate database of a record of transactions

we have too many dirty balance function

add command for all of fame (of donator in first part)

after leaving the following comments

+/u/sodogetiptest ;} doge
+/u/sodogetiptest ;

I now get 'you must use valid amount' after valid comments such as:

+/u/sodogetiptest 1 doge
+/u/sodogetiptest 10 doge
+/u/sodogetiptest 100 doge

address: nfM8qc8iubDTgeGqBfMhnSsguCfjRYfjr1

edit: actually i think the bot was broken before this

Currently it seems like it is only possible to buy gold for yourself. But gold is way more commonly bought for other users so it would be cool if the bot could support that, maybe even gilding a comment via the bot. (not sure if the API supports that) It could even leave a comment there that someone gilded via the bot.

Commands could look like this:

subject: +gold
content: buy <username>

subject: +gold
content: buy <link to comment>

I made a tip to someone a couple of days ago, and even after this user registered, the tip still remains pending. So I just thought I would resend it to him after the three days, but it's still pending. It's been four days now and I don't know why it's pending.

use cache system with ttl for value of coin

We make an function to calculate fee but not used.
fee are set to 1 (hardcoded)

need to improve this

• All messages sent via PM, except tips with verify or tips over 1000

• If a tip is less than or equal to the user's balance but more than the user's balance + miner fee, send a special error message for that.

• +register as a reply in comment to bot should register user, and PM with more info

• If the tipper doesn't have enough balance for a tip, it should just be a "balance is too low for this tip" error, even if the person getting tipped isn't registered

Stack trace :

Traceback (most recent call last):
  File "dogetipper.py", line 70, in main
    bot_command.balance_user(self.rpc_main, msg)
  File "/usr/src/app/bot_command.py", line 28, in balance_user
    balance = crypto.get_user_balance(rpc, msg.author.name)
  File "/usr/src/app/crypto.py", line 15, in get_user_balance
    list_unspent = rpc.listunspent(1, 99999999999, [address])
  File "/usr/local/lib/python2.7/site-packages/bitcoinrpc/authproxy.py", line 136, in __call__
    'Content-type': 'application/json'})
  File "/usr/local/lib/python2.7/httplib.py", line 1042, in request
    self._send_request(method, url, body, headers)
  File "/usr/local/lib/python2.7/httplib.py", line 1076, in _send_request
    self.putrequest(method, url, **skips)
  File "/usr/local/lib/python2.7/httplib.py", line 924, in putrequest
    raise CannotSendRequest()
CannotSendRequest

I tried +register to sodogetiptest but didn't received the confirmation of me being register. After sending +info the message told me that I wasn't registered.

• only use confirmed TX
• remove fail over system
• add tip in queue if we have pending
• move pending tip to use publish system
• make TxPublish system
• add multisig (close #4 )

order result of history

I suggest that the bottom of each message received from the tipbot should include a small help link which requests a help message from the bot.

The primary purpose of the help page would be to list the most useful features of the bot. Such as:

• A list of links to common tasks like withdraw & history
• Your current balance
• Your deposit address
• A link to the full documentation page on the tipbot

As the bot is "on chain", wouldn't this be eaten up by transaction fees?

I think there should be an error message like: "The minimum tip is 2 doge, as transaction fees are deducted from the tip amount"

add reminder function for reddit gold

add info on fee, it's onchain tipbot so we add fee for miner

Improve error message for tipping yourself

If reddit rate-limits the bot, which can happen for a variety of reasons, including if moderators remove a bunch of its posts, then the tip will go through, but it won't be able to post a verification message. When the reddit rate-limit is over, it checks again the user's balance and sees that it's not enough to tip and comments with an error. Even though the tip went through

to reduce fee, use one transaction to multiple tips, can be useful in giveaways.

This will add a little delay before send tip

Hello @just-an-dev and readers!

My name is Vadim, and i'm a developer of typegram: https://github.com/recoilme/tgram

Typegram is opensource reddit like platform for publishing. It's written on golang.
I want to add dogecoin for all users, for tip to authors

Your project is looking very good for that.
May you please give me some directions on how to start? Or may be you want to contribute to typegram?

Thank you, Vadim

Implement:

+/u/dogetipbot @PowerLemons 100 doge verify (for tipping a user)

+/u/dogetipbot ADDRESS 100 doge verify (for tipping an address)

Can someone tell me were i can put my keys to install the tipbot

• add litecoin

I notice that my balance is changeing without performing any tip
is this because it's a test environment?
or there is some bug?

re: +balance
inviato 1 giorno fa da sodogetiptest
Your balance : 2000.00000000

this has been reset to zero without any activity

then I was tipped and i request the balance again

da talman_au via /r/dogecoin inviato il 11 ore fa
mostra il post a cui è riferito
+/u/sodogetiptest 98 doge

re: +balance
inviato 11 ore fa da sodogetiptest
Your balance : 98

it show correctly the 98 doges

than I used the faucet getting 2000 doges

running again balance

re: +balance
inviato 11 ore fa da sodogetiptest
Your balance : 2000

It lost 98 doge previously tipped

Hi how do i use my reddit account and use this tipbot? I want to put it on my sub reddit

This is the message for +info with #22

Here are your account details %s!

%s being whatever is supposed to be replaced and ^ being superscript.

IMO it would make sense to have +info and +balance have this same message, as it shows everything the user needs to know.

add check of passphrase on startup