jvavrek / nimb2018 Goto Github PK

Or at least we can make it a simple wrapper around G4RandomDirection so that the naming is consistent with G4NRF::SampleCorrelation.

When attempting to incorporate G4NRFPhysics.cc into my own code I Get the following error:
aParticleIterator->reset(); not declared in this scope
suggested alternative: 'GetParticleIterator'
GetParticleIterator->reset();

1. Does your code take into account the probability of a coherent process (so called, "pure" NRF)?
2. If so, what is the error in determining the probability of NRF? More or less than 30%?
3. And finally, can I use G4NRF for Lu? Or maybe user can add their own isotopes in your database.

P.S. I can't send you an email to the address you provided.

I haven't tested this yet, but I don't think the decay time of the excited state is ever sampled to provide an emission time for the new photon. Most lifetimes are very short (1-100 fs) but it could be interesting to include that correction, likely involving the following lines in G4NRF.cc:

G4DynamicParticle* aGamma = new G4DynamicParticle(G4Gamma::Gamma(), emitted_gamma_direction, E_gamma);
aParticleChange.AddSecondary(aGamma);

Something like (pseudocode):

aGamma->SetProperTime(current_time + G4RandExponential(-pLevel->Lifetime()));

maybe?

When running with MPI I get the following error:
33:ERROR in G4NRF::AssignMultipoles.
33:Unexpected value of Gamma_num_mult: 3
33:Aborting.
33:WARNING - Attempt to delete the physical volume store while geometry closed !
33:WARNING - Attempt to delete the logical volume store while geometry closed !
33:WARNING - Attempt to delete the solid store while geometry closed !
33:WARNING - Attempt to delete the region store while geometry closed !

I wasn't getting this error when only running on one core but now running with MPI I am consistently getting this error.

Fatal error in PMPI_Comm_dup: Unknown error class, error stack:
PMPI_Comm_dup(179)..................: MPI_Comm_dup(comm=0x84000004, new_comm=0x7fffffffb668) failed
PMPI_Comm_dup(164)..................:
MPIR_Comm_dup_impl(57)..............:
MPII_Comm_copy(571).................:
MPIR_Get_contextid_sparse_group(495):
MPIR_Allreduce_impl(293)............:
MPIR_Allreduce_intra_auto(178)......:
MPIR_Allreduce_intra_auto(84).......:
MPIR_Bcast_impl(310)................:
MPIR_Bcast_intra_auto(223)..........:
MPIR_Bcast_intra_binomial(182)......: Failure during collective
Fatal error in PMPI_Comm_dup: Unknown error class, error stack:
PMPI_Comm_dup(179)..................: MPI_Com

Areg said you have ran with MPI before so I was wondering if you've ran into this error before?