jvelo / mayocat-shop Goto Github PK
View Code? Open in Web Editor NEW[RETIRED] Open source e-commerce and marketplaces made simple on the JVM
License: Other
[RETIRED] Open source e-commerce and marketplaces made simple on the JVM
License: Other
White background
Save
button on a product page.Actions
menu next to a thumbnail shouldn't be centered.featured
option on a thumbnail can't be removed once it's set.theme.yml
file, the height
property must be specified for thumbnails or the server will always return an error (500).No flag beside the url, it just change when a language selector is triggered
For the menu
For the pages
Avoid displaying a blank form before loading the content
See: /admin/#/settings/tenant
The shop informations can't be edited.
This seems legitimate but the behavior isn't adapted. When we create a page with a name identical to another one, the creation form never disappear, instead we can see in the network pane there is a 409 error. This error should be handled and an explicit message should be displayed.
While editing an image, if you crop it, there's a chance that the generated URL contains some space characters, which doesn't seems to handled by Mayocat's router.
For example, when I do a cropping similar to this:
I get this URL from the server:
/images/thumbnails/vines4_96_77_1 021_1 021.jpg?width=720&height=720
And if I try to access this URL, the server returns a 404 error.
The Style
selector should be removed and the Strike Through
button should be replaced with an Underline
button.
On the product creation page:
We need to check the X-Requested-With header and just say 200 OK
This should be an upstream responsibility.
Due to the serialization, the items in the cart take too much place in the cookie, which limits their number nearly to 15. Only the item IDs should be stored.
For instance on a server where the system locale is en_US, localSymbol will return "EUR" for the euro currency. It should return the euro symbol.
Ex: in org.mayocat.cms.news.api.representations.ArticleRepresentation
.
Ideally this should be defined in only one place.
Ẁith a list of featured products
In the "Running from command line" section, the specified directory should be mayocat/shop/application/
instead of mayocat/shop/
.
Without minification
There are a couple of needs with regard to database migrations we need to address
Right now when a theme developer makes mistakes in its theme.yml file or template files, it can be very hard to understand what's wrong ; we need to fix that
If you try to disable it, the initial stock field will still be visible in the product form.
Currently, an image uploaded to Mayocat is compressed a bit harshly. It could be interesting to switch to another compression library or even to an external process like ImageMagick.
Admitting there's no better library, introducing a dependency to ImageMagick could be troublesome for some servers without it. It would great if Mayocat was able to fallback to a JVM library to compress the images if ImageMagick isn't available.
If a product is saved once with a price, there's no way to remove it after.
It seems like a cart will always display a price even if it's empty. The displayed price seems to be equivalent to the flat rate price. This could happen because the shipping hasn't be completely cleared once the cart is empty.
What's strange is that every time I got a PermGen, it's always on this module, and its build is not exotic.
Happened on 2 different machines already.
[ERROR] The system is out of resources.
[ERROR] Consult the following stack trace for details.
[ERROR] java.lang.OutOfMemoryError: PermGen space
[ERROR] at java.lang.ClassLoader.defineClass1(Native Method)
[ERROR] at java.lang.ClassLoader.defineClass(ClassLoader.java:792)
[ERROR] at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
[ERROR] at java.net.URLClassLoader.defineClass(URLClassLoader.java:449)
[ERROR] at java.net.URLClassLoader.access$100(URLClassLoader.java:71)
[ERROR] at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
[ERROR] at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
[ERROR] at java.security.AccessController.doPrivileged(Native Method)
[ERROR] at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
[ERROR] at org.codehaus.plexus.compiler.javac.IsolatedClassLoader.loadClass(IsolatedClassLoader.java:56)
[ERROR] at com.sun.tools.javac.util.JCDiagnostic$Factory.<init>(JCDiagnostic.java:81)
[ERROR] at com.sun.tools.javac.util.JCDiagnostic$Factory.<init>(JCDiagnostic.java:70)
[ERROR] at com.sun.tools.javac.util.JCDiagnostic$Factory.instance(JCDiagnostic.java:60)
[ERROR] at com.sun.tools.javac.util.Log.<init>(Log.java:128)
[ERROR] at com.sun.tools.javac.util.Log.<init>(Log.java:199)
[ERROR] at com.sun.tools.javac.util.Log.<init>(Log.java:193)
[ERROR] at com.sun.tools.javac.util.Log.instance(Log.java:206)
[ERROR] at com.sun.tools.javac.util.BaseFileManager.setContext(BaseFileManager.java:72)
[ERROR] at com.sun.tools.javac.file.JavacFileManager.setContext(JavacFileManager.java:156)
[ERROR] at com.sun.tools.javac.file.JavacFileManager.<init>(JavacFileManager.java:148)
[ERROR] at com.sun.tools.javac.file.JavacFileManager$1.make(JavacFileManager.java:135)
[ERROR] at com.sun.tools.javac.file.JavacFileManager$1.make(JavacFileManager.java:133)
[ERROR] at com.sun.tools.javac.util.Context.get(Context.java:147)
[ERROR] at com.sun.tools.javac.util.Context.get(Context.java:190)
[ERROR] at com.sun.tools.javac.main.Main.compile(Main.java:422)
[ERROR] at com.sun.tools.javac.main.Main.compile(Main.java:353)
[ERROR] at com.sun.tools.javac.main.Main.compile(Main.java:342)
[ERROR] at com.sun.tools.javac.main.Main.compile(Main.java:333)
[ERROR] at com.sun.tools.javac.Main.compile(Main.java:94)
[ERROR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[ERROR] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
[ERROR] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Create an error message
Disable the hover effect on the update button when it's disabled
This is a first step to improve feedback when the theme definition is not valid. The second step will be to provide detailed feedback : type of error (invalid YAML, or invalid theme definition?) and line numbers.
There are several reason why we want to move towards native Handlebars rendering. The main reasons are :
This will also come with some brawbacks:
Right now, it's possible.
The objective of this refactoring/revamp is to introduce new use cases around image management for entities (products, pages, etc.), namely :
Some of the steps required to achieve this :
Editable in Settings / General
When dropping an image, it will be displayed instead of being uploaded.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.