Giter VIP home page Giter VIP logo

delivery-finder's People

Contributors

dishant avatar jvkumar avatar parikhv15 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

delivery-finder's Issues

instacart store ?

Instacart has multiple stores.. is there any way to figure out which store has availability ?

node_sleep.node is macOS only binary

I am trying to run your tool on Linux, and getting following error, presumably due to node_sleep.node being macOS only binary-

module.js:681
  return process.dlopen(module, path._makeLong(filename));
                 ^

Error: /home/vineet/bin/delivery-finder/node_modules/sleep/build/Release/node_sleep.node: invalid ELF header
    at Object.Module._extensions..node (module.js:681:18)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/vineet/bin/delivery-finder/node_modules/sleep/index.js:1:75)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)

I am not familiar with node.js, but isn't this something which can be pulled as dependency, instead of committing to the repo?

Double Quotes

Please adjust the auth.js in order to have 'XXXXX' instead of "XXXXX" in whole code, users may not figure out why this is not working... ;). Double quotes seem to produce syntax error:

SyntaxError: Unexpected identifier
�[90m    at wrapSafe (internal/modules/cjs/loader.js:1101:16)�[39m
�[90m    at Module._compile (internal/modules/cjs/loader.js:1149:27)�[39m
�[90m    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1205:10)�[39m
�[90m    at Module.load (internal/modules/cjs/loader.js:1034:32)�[39m
�[90m    at Function.Module._load (internal/modules/cjs/loader.js:923:14)�[39m
�[90m    at Module.require (internal/modules/cjs/loader.js:1074:19)�[39m
�[90m    at require (internal/modules/cjs/helpers.js:72:18)�[39m
    at Object.<anonymous> (C:\Temp\food\delivery-finder\finder.js:5:20)
�[90m    at Module._compile (internal/modules/cjs/loader.js:1185:30)�[39m
�[90m    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1205:10)�[39m

How it is:

const walmartGroceries = {
  cookie: "XXXXX",
  store_id: "XXXXX",
  cart_id: "XXXXX"

How it should be, Suggested:

// to find availability in Walmart Groceries, replace XXXXX with value of `cookie`, `cart id` & `store id` you collected in Step 3
const walmartGroceries = {
  cookie: 'XXXXX',
  store_id: 'XXXXX',
  cart_id: 'XXXXX'

Beep not working on Windows10

Not sure this is an issue for everyone but I found out the beep was not working and the code is not throwing the exception in the finder.js. After checking it and forcing the exception by adding if (err) throw err I found the following...

Error: Couldn't find a suitable audio player
    at Play.play (c:\Temp\delivery-finder\node_modules\play-sound\index.js:34:19)
    at Object.<anonymous> (c:\Temp\delivery-finder\sound.js:4:8)
    at Module._compile (internal/modules/cjs/loader.js:1185:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1205:10)
    at Module.load (internal/modules/cjs/loader.js:1034:32)
    at Function.Module._load (internal/modules/cjs/loader.js:923:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
    at internal/main/run_main_module.js:17:47

If you want to use the windows default player you have to fix the \node_modules\play-sound\index.js while adding 'powershell' as per updated on the https://github.com/shime/play-sound/pull/33/files :

var fs               = require('fs')
  , findExec         = require('find-exec')
  , spawn            = require('child_process').spawn
  , players          = [
                        'mplayer',
                        'afplay',
                        'mpg123',
                        'mpg321',
                        'play',
                        'omxplayer',
                        'aplay',
                        'cmdmp3',
			'powershell'
                         ]

Additionally you will need to use the full path in delivery-finder\finder.js e.g.:

function beep () {
  player.play('C:\\temp\\delivery-finder\\beep.mp3', function (err) {
    
  })
}

or

function beep () {
  player.play('./beep.mp3', function (err) {
    
  })
}

After that it should work where it will launch the default windows player application and play the sound


Alternatively, another easy option to the changes above mentioned / default windows player is to use the cmdmp3 (https://github.com/jimlawless/cmdmp3) and have installed on the same folder as your finder.js

May mention this on the documentation for windows users ;)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.