Makefile doesn't byte-compile Python code about mwic HOT 6 CLOSED

Does d39e277 address your concerns?

from mwic.

I saw those lines but forget I was looking at master.. Also, my build script does use DESTDIR:
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=mwic

from mwic.

I neglected the case when DESTDIR is set on the assumption that distros have their own tools for byte-compliation. Perhaps I was being overly optimistic.
Anyway, this should be fixed in a71847f.
Note that this only takes cares care of non-optimized bytecode. If you want “optimized” bytecode too, run make install again with PYTHONOPTIMIZE set, i.e. something like this:

--- a/PKGBUILD
+++ b/PKGBUILD
@@ -24,2 +24,3 @@ package() {
   make PREFIX=/usr DESTDIR="$pkgdir" install
+  make PREFIX=/usr DESTDIR="$pkgdir" install PYTHONOPTIMIZE=1
   install -Dm644 -t "$pkgdir"/usr/share/licenses/mwic doc/LICENSE

from mwic.

Tried adding a compileall line directly to the build script, and things definitely didn't go as planned. A bunch of lines like:

*** Error compiling '/usr/lib/python3.7/pyclbr.py'...                                                                
PermissionError: [Errno 13] Permission denied: '/usr/lib/python3.7/__pycache__/pyclbr.cpython-37.pyc.140693525927080'

Will tailor one to build from master tomorrow.

from mwic.

Looks good to me! Thank you very much.

from mwic.

Fixed in 0.7.8.

from mwic.