promise based decorators? about kaop-ts HOT 6 CLOSED

Does this mean we can now use kaop-ts with promises? Should this issue then be closed? Thanks

from kaop-ts.

keep in mind that you still rely on meta.commit to complete a task within each advice scope.

This change allows decorate methods that work with promises but inside advice operations you still have the same API

from kaop-ts.

🎉 This issue has been resolved in version 4.1.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

from kaop-ts.

k1r0s/kaop@d3c6cb2

from kaop-ts.

Thanks for ur comment @greg-murray-volusion

I made that change on kaop lib (which is a hard kaop-ts dependency). I have to release a minor version simply pointing to last kaop version here.

You can try this feature now if you manually install latest kaop version on your project.

This change will make your methods wrapped with 'async' advices return a promise (or wrap existing one) in order to reflect that async process from outside of the method.

Before this change, if you had a method that returns a promise and you want to put advices on it, you couldn't properly return that promise if any of those advices contain an async task too.

I have to document that in deep, that's why this is still open :)

You can check these test in order to get more context
https://github.com/k1r0s/kaop/blob/master/test/promise-advice-method.spec.js

I can show you how this looks on es6 classes with real decorators:

this was somehow impossible with previous kaop version

const { beforeMethod, afterMethod } = require("kaop-ts");

const delay = beforeMethod(meta => setTimeout(meta.commit, 10))
const handleError = afterMethod(meta => meta.handle())

class Dummy {

  @delay
  do1() {
    return Promise.resolve(10)
  }

  do2() {
    return Promise.resolve(10)
  }

  @delay
  do3() {
    throw new Error("lmaooo")
  }

  @delay
  @handleError
  do4() {
    throw new Error("lmaooo")
  }
}

from kaop-ts.

Cool, thanks!

from kaop-ts.