Giter VIP home page Giter VIP logo

Comments (4)

w-etc avatar w-etc commented on May 29, 2024 1

Version 4.0.0

Edit: Just checked with version 4.3.0. Error is still happening

Edit 2: I thought I'd exhausted all possibilities on my end, but after a nap I found out that the problem was in the tests setup and had nothing to do with the advises. Everything is working as expected now. Thanks for answering earlier and sorry for the false issue!

from kaop-ts.

k1r0s avatar k1r0s commented on May 29, 2024

Hey! which kaop-ts version are you running on your project?

from kaop-ts.

k1r0s avatar k1r0s commented on May 29, 2024

My two cents on your code: try to separate concerns as your advice is doing too much stuff alone!

You can create an advice for every phase on your pre-request stuff

checkAndParseBody
extractAuthHeaderVerifyAndDecodeToken
checkExistingProperties
getCredentialedResponse

any of them could be extracted as an advice

This article explains for instance, how to separate concerns in backend development using advices: https://dev.to/k1r0s/idiomatic-javascript-backend-part-1-4g0b

from kaop-ts.

w-etc avatar w-etc commented on May 29, 2024

Oh, thanks for the info!

from kaop-ts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.