k2informaticsgmbh / dderl Goto Github PK

Ctrl+C and Ctrl+V to move selected ranges from slickgrid to another slickgrid or clipboard is not working properly...

Ctrl+V on a slickgrid selected cells isn't adding/appending/replacing any rows

=ERROR REPORT==== 27-Mar-2013::08:22:24 ===
** Generic server <0.782.0> terminating
** Last message in was {'$gen_cast',
{process,
[<<"button">>],
<<"{"button":{"connection":null,"statement":null,"btn":"close"}}">>,
<0.1017.0>}}
** When Server state == {state,{priv,{erlimem_session,<0.787.0>},[]},
[],
{1364372531971830,#Ref<0.0.0.9452>},
<<"admin">>,imem_adapter}
** Reason for termination ==
** {function_clause,[{base64,decode,[null],[{file,"base64.erl"},{line,114}]},
{imem_adapter,process_cmd,3,
[{file,"src/imem_adapter.erl"},{line,195}]},
{dderl_session,process_call,3,
[{file,"src/dderl_session.erl"},
{line,154}]},
{dderl_session,handle_cast,2,
[{file,"src/dderl_session.erl"},
{line,68}]},
{gen_server,handle_msg,5,
[{file,"gen_server.erl"},{line,607}]},
{proc_lib,init_p_do_apply,3,
[{file,"proc_lib.erl"},{line,239}]}]}
27.03.2013 08:22:31.113830 [error] [DDRL] {dderl_resource,35} session <<"<0.782.0>">> doesn't exists ("process not found")

After executing the drop table command, a (superfluous and empty) data window appears. The session crash happens, when this window is closed.
When no statement reference is returned by exec(), the data result gui should be suppressed.

The rowcount shown in the yellow field does not match the last row tag.

On the header bar, the context menu 'hide column' is missing.

• Dialog move should be restricted so that top border doesn't hide:

current

desired

• "Browse Data" on large tables:
  • few pixels are hiding behind the status also its few pixels less wide to bring up the horizontal scroll bar while enough space on right side in the browser
    
  • if the source table is located near the right border of the browser window, new table do not expand to right
    
• The login box don't get cursor in Password field after page load/browser refresh
  
  should be
  

1. Add a 'Disconnect' (if connected menu under 'File') it might show disabled (grayed) if not connected.
2. 'New Connection' should open a new tab only if the current tab is connected, otherwise it shows the connect dialog in the current tab

Having several table dialogs open, entering a target rowid on one of them kills another dialog.

It looks as if the keyboard enter event is routed to a dialog other than the current insert cursor control where I just wrote the text (target rowid).

Having a query with many result rows quickly shows the final row count in the yellow table size indicator.
Instead of showing the last 100 (one blocksize) rows, the GUI receives all consecutive blocks in sequence. This takes ages.

We need to test using this version since it is the one currently used.

A row insert fails on a table with reordered columns.

The timer is blocked while rows are being produced. File table.js

var rowStatusCheckInterval = 500;
function rowFunWrapper(countFun, rowFun, table, opts, rowNum, loadFunOpts)
{
    table.data("finished")
        .removeClass("download_incomplete")
        .removeClass("download_complete")
        .addClass("downloading");

    function statusCheckFun() {
        if(jQuery.isFunction(countFun)) {
            countFun(function(resp) {
                if(table.data("finished") != undefined)
                    table.data("finished").val(''+resp.count);
                if(!resp.finished)
                    setTimeout(statusCheckFun, rowStatusCheckInterval);
            });
        }
    };
    setTimeout(statusCheckFun, rowStatusCheckInterval);
    rowFun(opts, rowNum, loadRows, [table, rowNum, loadFunOpts]);
}

A timer should be added for all the command that are waiting for rows from the db, in case the timer gets triggered before the operation is complete, then it should reply with the that is currently on the buffer.

In long table after inserting a new row the focus property is set to 0 instead of the newly created row.

'New Connection' should open a new tab and leave the existing connection alive in the current tab. This function will enable to connect to the same or a new a new external database using the same or a different user. Credentials are asked in the login.

The new connection will connect to the same local dderl instance as the current tab and inherit the dderl login credentials. This means that the seco needs to be cloned for the new session manager.

If there are control characters on a string we need to escape them properly to allow edition of the cell.

Ctrl-c of the cell should return the original raw text.

following the result of pasting one entire row into the first field of the empty row at the bottom:

** {function_clause,
[{erlimem_fsm,data_update_row,
[{undefined,ins,
[{"time",
"1\t23.03.2013 17:10:03\t-123\t0\t1.00000000000000000000e+00\tstart"}]},

"time" is a column name where the fsm expects a column position (1 here)
the handling of multi-column paste is discussed in separate issue

Expected ChangeListFormat for insert:

[{RowId,ins,Fields}] where Fields = list( {Col#, StringValue} )

Column headers should show the following sort menue items:

sort...:

if this column is not yet in the sort spec then
    add this column to the sort spec (ascending, at the end)
endif
show the sort spec

sort asc:

if this column is not yet in the sort spec then
    add this column to the sort spec (ascending, at the end)
else
    correct the sort order for this column to asc
endif
If the resulting sort spec consists of only this column then
    run the sort immediately
else
    show the sort spec
endif

sort desc:

if this column is not yet in the sort spec then
    add this column to the sort spec (descending, at the end)
else
    correct the sort order for this column to desc
endif
If the resulting sort spec consists of only this column then
    run the sort immediately
else
   show the sort spec
endif

sort clear:

if this column is part of the sort spec already then
   remove it
endif
if the resulting sort spec is empty then
    run it (go back to raw navigation)
else
    show the sort spec
endif

In the scenario shown above "Browse Data" will fail.

Reason: "Browse Data" do not support multiple cells at the moment, but may support in future

Remedy: A right click should clear all the previous selected ranges in the slickgrid cellrowselectionmodel plugin when it is following a left click in the same table at two
different cells.

Clicking on a cell or moving there by tabulator key use should set the focus and select the current content (like in DataDirect Explorer).

Like that,
typing characters will replace the current text
typing right arrow will deselect and allow appending to the text
typing left arrow will deselect and allow prepending to the text

If the column is readonly, the focus should still be moved into the cell and the current content should be selected. Arrows also work as expected an can be used (with the help of the shift key) to select portions of the current content. When the user wants to type in something, an error box should pop up saying "This cell is read only".

Currently it is possible to reorder the id column, it should be fixed in the first position.

Currently the sessions doesn't keep a list with the connections that it owns, it should keep track of them and validate the ownership when processing requests.

Using a tcp connection to browse the data of a table with a small number of rows (approximately less than 5) crash the server due to time out.

Output:

16.05.2013 20:42:20.563345 [info] [IMDR] {erlimem_session,0376} sort_spec [{1,
<<"asc">>}]
16.05.2013 20:42:20.846208 [info] [IMDR] {erlimem_session,0284} [INCOMPLETE] <0.1650.0> received 1456 of 4908 bytes buffering...
16.05.2013 20:42:20.846336 [info] [IMDR] {erlimem_session,0284} [INCOMPLETE] <0.1650.0> received 2916 of 4908 bytes buffering...
16.05.2013 20:42:20.846428 [info] [IMDR] {erlimem_session,0284} [INCOMPLETE] <0.1650.0> received 4376 of 4908 bytes buffering...
16.05.2013 20:43:54.618150 [info] [IMDR] {erlimem_session,0284} [INCOMPLETE] <0.1650.0> received 284 of 68 bytes buffering...
16.05.2013 20:43:59.621560 [IMEM] {imem_server, 0070} socket #Port<0.8932> got closed!

=ERROR REPORT==== 16-May-2013::21:39:07 ===
** State machine <0.1731.0> terminating
** Last event in was {button,<<">">>,#Fun<imem_adapter.35.37698144>} (for all states)
** When State == empty
** Data == {state,{ctx,"what is it?",100,<0.1730.0>,
[{stmtCol,'$1',<<"id">>,userid,0,0,false},
{stmtCol,'$2',<<"roles">>,list,0,0,false},
{stmtCol,'$3',<<"permissions">>,list,0,0,false},
{stmtCol,'$4',<<"quotas">>,list,0,0,false}],
#Fun<imem_datatype.1.109819567>,
#Fun<imem_sql.7.128848470>,[],undefined,
<0.1650.0>},
8806532,8810629,100,300,<0.1730.0>,
[{stmtCol,'$1',<<"id">>,userid,0,0,false},
{stmtCol,'$2',<<"roles">>,list,0,0,false},
{stmtCol,'$3',<<"permissions">>,list,0,0,false},
{stmtCol,'$4',<<"quotas">>,list,0,0,false}],
#Fun<imem_datatype.1.109819567>,[],
#Fun<imem_sql.7.128848470>,
{undefined,[]},
#Fun<erlimem_fsm.24.123808864>,0,99999999,0,0,
99999999,0,0,[],{},0,99999999,0,0,undefined,undefined,
false,raw,false,0,false,false,undefined,undefined,
<<>>}
** Reason for termination =
** {timeout,{gen_server,call,[<0.1650.0>,[fetch_recs_async,[],<0.1730.0>]]}}

If a connection is attempted with something that is not a integer as the port, dderl_session crash instead of returning the error to the user.

Ctrl-C should copy the current cell selection to the clipboard.

The copied data must be usable in the client OS by doing Ctrl-V which emits the values (as 2-D tabulator separated values).

When saving a view, and bringing it back using 'Browse data',
the window position (upper left corner) is restored correctly
the column widths ar ok
the window height is approximately ok (a little too small)
but the window width is not correctly set (too small in test case)

Choosing from SQL-History sometimes replaces the Pretty SQL string but not always (maybe depending on NewQuery/BrowseData).
It does not change the Flat SQL.
Changes in Box are not promoted to Pretty nor Flat when changing the view.
It is ok that the current SQL is not shown in the history but it should be saved before another version from the history replaces it.

SQL history drop down should auto-extend to the end of the footer line.

History should persist on a combination of SQL-window and ist associated table.

When rows are updated, they get a red font color and sometimes a strikethrough.

After committing, the fonts must be changed back to normal.

After roollback, the fonts must be changed back to normal.

Currently, the red color survives even a gui_replace().

When the users log out or the sessions are terminated by a time out, the session is not properly cleaned.

print the given erlang term just as it is presented here:

[{tpi,[{ip,              {127,0,0,1}}]}
,{tpi,[{ip,              {127,0,0,1}}
      ,{verylongportname,8443}
      ,{ssl,             [{certfile,        "priv/mpro.crt/etc/etc/etc/etc/etc/etc/etc/etc"}
                         ,{keyfile,         "priv/mpro.key"}
                         ,{verylongpassword,"mpro"}
                         ]
       }
      ]
 }
,{tpi,[{ip,              {127,0,0,1}},      {port, 9999}]}
]

for the default case where the user wants automatic indenting.

The drop down should allow the following values:

auto (new option, set as default)
0
1
2
3
4
5 (fixed indentation for all elements as you have it)

The rules are as follows:

· fixed space font (e.g. Courier)
· variable nesting indentation, depending of value length (aqs for atom verylongportname)
· given target line length (e.g. 50 characters), can be exceeded if no nesting is possible or if nesting does not help (as with etc/etc/etc/etc)
· nesting is NOT done if whole subnested block fits (unnnested) on remainder of the line
· to be shown in a text box with scrollbars in both directions

Good to have a File menu "About" which shows the application versions of DDErl and its dependencies (may or may not include 'kernel' and 'stdlib').

When editing a cell, the use of the tabulator key should move the focus to the next visible cell in the same row (which it does) but keep the edit mode (which it does not). DataDirect Explorer behaviour should be approximated as much as possible (no enter/doubleclick needed there to enter edit mode).

Commit response replaces all the rows and only adds the affected rows.

It should just change the formatting of the affected to back to default

Also, the same function should be made available using context menu on tag bar for current row selection.

Column headers should show the following menues:

filter...:

if any of the selected columns is not yet part of the filter spec then
    add it to the filter spec (with empty value lists)
endif
show the filter spec (for all columns)

filter clear:

remove these columns from the filter spec (if present)
if resulting filter spec is not empty 
     show the filter spec
else
    execute the new filter (go back to raw navigation) without showing the filter spec
endif

a filter operation on a selected cell range should merge the current selection into a pre existing value list for the columns, removing duplicates and sorting the merged string values in ascending order

if there is no pre-existing filter and if only one filter column is present, the filter can be executed immediately
otherwise, the filter spec is shown

When creating a new connection using the same session, the old connection is replaced by the new one. This shouldn't be the case, the new connection should be completely independent of the old one.

All the global variables used in dderl jquery should be kept in one global object as its properties.

For example in dderl.js

Instead of:

var session = null;
var adapter = null;
var connection = null;

Preferred:

var global = {
  session: null,
  adapter: null,
  connection: null
};

Access (lvalue or rvalue):

global.session
global.adapter

This will improve code readability and prevent assignment attempt accidentally creating a new variable in the local scope without change the global variable.

Like (in earlier scenario):

fun() { var session = ... ; } // doesn't change the global variable

In new approach:

fun() { var global.session = ... ; } // error

Calculating the adapted column widths for the first block of data in a table dialog is implemented too slow.
Possible solution: Sever adds meta information for each column which points to the row in the first block with the highest number of characters.

** Reason for termination ==
** {'function not exported',
[{gen_adapter,process_cmd,
[{[<<"parse_stmt">>],
[{<<"parse_stmt">>,
[{<<"qstr">>,
<<"select c.owner, v.name from ddView as v, ddCmd as c where c.id = v.cmd and c.adapters = "[imem]" and (c.owner = user or c.owner = system)">>}]}]},
<0.1764.0>,undefined],
[]},

wrong signature for process_cmd

The following bas SQL brings the server to a hang:

select
*
from
Imem.mproDestinationPeer where appId =ucp
and address="10.231.163.101"
and opts = []

Subsequent corrected SBS is blocked with the error message:

ClientException: Statement creation already in progress!

The dderl server log shows:

11:25:09.799 [error] [IMDR] {erlimem_session,491} throw {case_clause,
{error,
{9,sql_lex,
{illegal,"["}},
9}}
11:25:09.796 [error] [DDRL] {imem_adapter,302} query error {case_clause,{error,{9,sql_lex,{illegal,"["}},9}}

=ERROR REPORT==== 25-Feb-2013::11:25:09 ===
Error in process <0.526.0> on node '[email protected]' with exit value: {badarg,[{erlang,list_to_binary,[[99,97,115,101,95,99,108,97,117,115,101,58,32|error]],[]},{imem_adapter,process_query,2,[{file,"src/imem_adapter.erl"},{line,303}]},{imem_adapter,process_cmd,2,[{file,"src/imem_adapter.erl"},{line,88}]},{dderl_session,'-process_call/3-fun-1-'...

Login dialog shows a button "Delete" which does not work.

All dialog title bar / column headers / toolbars with buttons should be of same height (as the current dialog title bar or slightly higher if necessary).

The height of the data columns may be somewhat different, potentally auto-adjusted to the font when the latter becomes configurable or selectable in the GUI.