kaelzhang / neuron-module-bundler Goto Github PK

Wrap commonjs module/1.0 javascript files for http://github.com/kaelzhang/neuron

License: Other

JavaScript 100.00%

neuron-module-bundler's Introduction

neuron-module-bundler

Usage

var builder = require('neuron-module-bundler');

builder(file, options, callback)
  .on('warn', function(message){
    console.warn(message);
  });

builder(filename, options, callback)

filename String the pathname of the entry file to be parsed from
options Object
- pkg: Object mixed package json format of project
- cwd: String current working directory
- allowImplicitDependencies: Boolean=false whether allows implicit dependencies. If true and a dependency is not found in pkg, it will be treated as the latest version.
callback function(err, content)

callback will get err, contents and parsed as its arguments, where:

err Error
content String the parsed content

neuron-module-bundler's People

Contributors

Watchers

Forkers

cortexjs-legacy

neuron-module-bundler's Issues

Cannot read property 'assert' of undefined

info: cortex test in local mode
error: Cannot read property 'assert' of undefined
error: TypeError: Cannot read property 'assert' of undefined
    at /usr/local/lib/node_modules/cortex-test/node_modules/neuron-builder/index.js:150:43
    at Array.map (native)
    at Parser.resolveDependencies (/usr/local/lib/node_modules/cortex-test/node_modules/neuron-builder/index.js:145:17)
    at Parser.generateWrapingCode (/usr/local/lib/node_modules/cortex-test/node_modules/neuron-builder/index.js:66:21)
    at /usr/local/lib/node_modules/cortex-test/node_modules/neuron-builder/index.js:40:22
    at /usr/local/lib/node_modules/cortex-test/node_modules/async/lib/async.js:249:17
    at /usr/local/lib/node_modules/cortex-test/node_modules/async/lib/async.js:125:13
    at Array.forEach (native)
    at _each (/usr/local/lib/node_modules/cortex-test/node_modules/async/lib/async.js:46:24)
    at async.each (/usr/local/lib/node_modules/cortex-test/node_modules/async/lib/async.js:124:9)
ERR! Not ok, exit code: 1

pkg.dependencies may be undefined

avoid multi process pollution

missing return value of method `mix`

result in undefined options.map

upgrade to [email protected]

neuron.write(dest) will no longer resolve paths.

Save neuron.js to './neurons/neuron.js' instead of './neurons/neuron/<version>/neuron.js'

more compact for options.asyncDeps

asyncDeps will be added to all define's:

saving options.asyncDeps as a local var
or detecting require.async

Maybe not output asyncDeps and entries if empty

function mix(a,b){for(var k in b){a[k]=b[k]}}
var entries = [];
var asyncDeps = [];

sequence of defined modules, main at last

package: "*" should build into /root/package/latest dir

Use node.isForeign instead of proto.isExternalDep

maybe use module-deps to instead of commonjs-walker

module-deps

two modules from two different dirs both require './a'

对于全部打包到一起的模块，是否可以完全打破 define 的方式

如果模块非常多，根本就不要用 define 来做，或许。

define 不是 commonjs stardard

目标

减小大型的项目内部模块的互相运作的复杂度，代码体积和运行代价

feed commonjs-walker with resolved `as`

supports cyclic dependencies, and warn events

more compact output

asyncDeps
define

the array of dependencies should also be lowercased

more scenarios for test cases
lowercased dependencies
lowercased id to be defined
id could also be saved into a variable: '[email protected]/A.js'

(function(){
function mix(a,b){for(var k in b){a[k]=b[k]}return a}
var _0 = "[email protected]/A.js";  // >>>> HERE! <<<<
var _1 = "[email protected]/a.js";
var asyncDepsToMix = {};
define("[email protected]/index.js", [_0], function(require, exports, module, __filename, __dirname) {
'use strict';

var a = require('./A');

exports.init = function() {
  a();
};

}, {
    main:true,
    map:mix({"./A":_1}, asyncDepsToMix)
});

// >>>> HERE! <<<<
define("[email protected]/A.js", [], function(require, exports, module, __filename, __dirname) {
module.exports = function () {
  console.log('hello world');
}
}, {
    map:asyncDepsToMix
});
})();

合并大量重复的变量，使文件变小

asyncDeps
转换相对路径为 module id，使之可以转存

more arguments of factory

define(
  id, 
  dependencies, 
  function(require, module, exports, __filename, __dirname){}, 
  options
);

related to kaelzhang/neuron.js#113

bundled modules should maintain order

facade foo

create mod foo

try to load javascript file of foo

define foo/index.js ->

foo loaded

try to load the dependencies of foo/index.js

found that foo/index.js -> foo/a.js

try to load foo/a.js, but actually foo/a.js is defined after foo/index.js in foo.js

So it is better to maintain order

Code review

no try-catch
split logic about validation and output

cant build correctly when file extension not specified in `pkg.main`

should not conflict if .parse() method calls several times

if cortex.main is false, it will throw

migrate from grunt

5.0.0: support to register a compiler

compiler

flag to determine whether should compress and use variables

support filename and dirname

Change APIs

will be landed in a new major version

support pkg.as

support requiring a directory and module fallbacks

请使用 [email protected]

use variables to compress options.asyncDeps and dependencies

var a = '......../a.js';
var b = '......../b.js';
var asyncDeps = {...}

define('xxxxx', [a, b], factory, {asyncDeps: asyncDeps});

supports scoped packages

where is v4.0.8

cortex requires "neuron-builder": "^4.0.0".

After npm install, I got [email protected]. But this project only includes v4.0.6. :(