kaitoy / impress Goto Github PK

View Code? Open in Web Editor NEW

1.0 3.0 0.0 84.15 MB

An Atom package to create presentations using impress.js.

Home Page: https://atom.io/packages/impress

License: MIT License

CoffeeScript 28.81% JavaScript 56.98% CSS 7.78% HTML 6.43%

impress's Introduction

impress package

An Atom package to create presentations using impress.js.

Features

Presentation Project Generator

Ctrl+Alt+i Ctrl+Alt+n to run the Presentation Project Generator. (Keep pressing Ctrl+Alt and press i and then n quickly.)

Step List View

In a presentation project, Ctrl+Alt+i Ctrl+Alt+s to toggle the Step List View. (Keep pressing Ctrl+Alt and press i and then s quickly.)

Preview

In a presentation project, Ctrl+Alt+i Ctrl+Alt+p to open the Preview window. (Keep pressing Ctrl+Alt and press i and then p quickly.)

Configuration

Package settings and <presentation project root>/.impress.toml.

impress's People

Contributors

Stargazers

Watchers

impress's Issues

Small changes required for an upcoming Atom release

Hi! Atom will soon be upgrading to a new version of Electron, which will cause some APIs to change.

You'll need to:

change this usage of BrowserWindow.prototype.loadUrl to @previewWindow.webContents.loadURL.
change require("remote") to require("electron").remote
change remote.require("browser-window") to remote.BrowserWindow

There may be other similar small changes required. See this post on the electron blog for more information. And let me know if you need any additional help. Thanks!

Failed to activate the impress package

[Enter steps to reproduce:]

Atom: 1.14.4 x64
Electron: 1.3.13
OS: Linux Mint
Thrown From: impress package 0.1.1

Stack Trace

Failed to activate the impress package

At ENOENT: no such file or directory, open 'impress/icons/x-mark.png'

Error: ENOENT: no such file or directory, open 'impress/icons/x-mark.png'
    at Error (native)
    at Object.fs.openSync (fs.js:640:18)
    at Object.module.(anonymous function) [as openSync] (ELECTRON_ASAR.js:168:20)
    at Object.fs.readFileSync (fs.js:508:33)
    at Object.fs.readFileSync (ELECTRON_ASAR.js:501:29)
    at Object.exports.readIconInBase64 (/packages/impress/lib/util.coffee:48:6)
    at /packages/impress/lib/step-list.js:14:20)
    at Module._compile (/app.asar/src/native-compile-cache.js:109:30)
    at /app.asar/src/compile-cache.js:216:21)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.require (module.js:483:17)
    at require (/app.asar/src/native-compile-cache.js:50:27)
    at /packages/impress/lib/step-list-view.coffee:8:12)
    at /packages/impress/lib/step-list-view.coffee:1:1)
    at Module._compile (/app.asar/src/native-compile-cache.js:109:30)
    at /app.asar/src/compile-cache.js:216:21)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.require (module.js:483:17)
    at require (/app.asar/src/native-compile-cache.js:50:27)
    at /packages/impress/lib/step-list-view-manager.coffee:3:16)
    at /packages/impress/lib/step-list-view-manager.coffee:1:1)
    at Module._compile (/app.asar/src/native-compile-cache.js:109:30)
    at /app.asar/src/compile-cache.js:216:21)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)

Commands

Non-Core Packages

activate-power-mode 0.9.0 
atom-beautify 0.29.12 
atom-ja-dummy 0.2.0 
atom-lorempixel 0.1.0 
atom-material-syntax 0.4.6 
atom-material-ui 1.3.6 
color-picker 2.2.2 
emmet 2.4.3 
file-icons 1.7.19 
file-type-icons 1.3.2 
highlight-line 0.11.1 
impress 0.1.1 
linter 1.11.16 
lipsum 0.1.0 
minimap 4.25.0 
monokai-complete-syntax 0.2.3 
seti-ui 1.3.2 
Writer 0.1.0

Changes required due to TextBuffer.save becoming async in Atom 1.19

Hi! Thanks for maintaining the impress package!

In Atom v1.19, we will release a major change to Atom's core text buffer data structure. As part of this change, we have made TextBuffer.save asynchronous; rather than blocking until the save is complete, it now immediately returns a Promise that resolves when the save is complete. Because of this, a few other Atom APIs that use save have similarly become async:

Pane.close
TextBuffer.save
TextEditor.save
Pane.saveItem
Pane.saveItemAs
Pane.saveActiveItem
Pane.saveActiveItemAs
Pane.saveItems
Workspace.saveActivePaneItem
Workspace.saveActivePaneItemAs

Effects on this package

We think this package could be impacted by this upgrade because it calls the changed methods in the following places:

TextEditor.save
- here

We found these calls using a regex search, so this list might be incomplete, and it might contain some false positives.

What to do about the change

It should be pretty easy to adjust your package code and/or tests to work with the new async behavior, and to simultaneously keep it working with older versions of Atom. Here are some examples of pull requests we opened on our bundled packages to cope with the change:

Please let me know if you have any questions. I would be happy to help!