kalaspuff / stockholm Goto Github PK

Hello, first of all, I want to say thanks for the great library! It is very well explained with a lot of examples and it is very feature rich.
I have 2 questions and I couldn't find a wiki or a discord or any other discussion forum so I guess I will open an issue to ask.

First is what is the most intended way to use this library with Pydantic 2?
It would have been cool if the Money object was a Pydantic BaseModel or supported Pydantic schemas for serialization, but since that is not the case am I supposed to convert it to a dict, parse it as a Pydantic model and store it like that? And then when I want to do money operations I am supposed to convert it back and forth?
Or is working with Pydantic models just not a considered aspect of this library? If you are interested I could try to contribute this functionality.

My second question is does this library support formatting money using Unicode symbols?
For example: €5.00, -€4.21, $50, -$7
And is this a feature that you are interested in getting a contribution for?

Hi, just caught a small typo, where decimal_digit should be decimal_digits.

I hope you don't mind if I don't submit a PR? Cheers,

Firstly, this is a fantastic library.

I have a few questions relating to readability of the string output:

• Is it possible to print 1000000.00 USD as 1,000,000.00 USD? (humanize.intcomma module does this)
• Is there a way to print $1000.00 instead of 1000.00 USD?
• Is there a way to strip nanos if they're zeroes? 1000.00 USD -> 1000 USD?

We're using version 0.5.1

from stockholm import Currency

c1 = Currency("RWF")
c1
# <stockholm.Currency: "RWF">
c1.decimal_digits
# 2

c2 = Currency.RWF
c2
# <stockholm.Currency: "RWF">
c2.decimal_digits
# 0

This causes a bug for us where 100x as much money was passed as intended

from stockholm import Money

t = Money("1673861354.00", "RWF")
t
# <stockholm.Money: "1673861354.00 RWF">

t.sub_units
# Decimal('167386135400')

int(t.sub_units)
# 167386135400

Workaround:

c3 = getattr(Currency, "RWF")
c3
# <stockholm.Currency: "RWF">
c3.decimal_digits
# 0