Giter VIP home page Giter VIP logo

emi's People

Contributors

kamicane avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

emi's Issues

tweaks

  1. You could drop the check for duplicate event listeners in on.
    It's pretty edge and if a dev is attempting it they probably want to.
    jQuery allows duplicates because it helps keep their event system open/flexible enough for things like namespaced events. By keeping the event system dumb you give the dev more control.
  2. Shallow clone your listeners before emitting them so listeners that call on or off won't muck up the current iterating listeners.
  3. Allow on to accept a space separated string of event types foo.on('click touch', listener) and allow off to be called likefoo.off('click') to remove all "click" listeners or foo.off() to remove all listeners.
  4. Instead of slicing arguments in your emit method you could standardize on always passing an event object (assumes the presence of a simple Event constructor):
// instead of this...
var args = Array.prototype.slice.call(arguments, 1);

// you could have this...
arguments[0] = new Event(event);
// and then...
events[i].apply(null, arguments);

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.