karbovanets / karbo Goto Github PK

Transaction multi-signature validation looks not finished.

Because output is not filled and has zero values condition on line 569 will be always true and validation always gonna fail.

The dynamically adjusting fee based on difficulty needs to be fixed and need to take into account possible POW change #21.

Now it uses an all-time avg. difficulty as a reference difficulty whereas it should use some selected difficulty at the point of time with the desired price to calculate the corresponding fee.

If new POW algo is introduced, this all-time difficulty will not be relevant.

Moreover, this all-time average difficulty is not from the initial equation F = S * A / D from whitepaper where, F​ — minimum transaction fee in native currency, KRB; S​ — starting fee in fiat equivalent, USD; A​ — Average difficulty constant, corresponding to the chosen level of fiat price; D​ — Current difficulty.