karelvuong / st-primer Goto Github PK

A very minor visual issue: If your font size is very small (<= 10 with Menlo), the height of the inputs in the Find and Find in Files panels matches the size of the height:

Personally, I find 14-point text easier on the eyes, but this makes the inputs a few px taller than the buttons:

I understand why the inputs have to get taller, but it would be nice for the buttons to get taller to match.

just wanted to let you know that the bower icon is not working it is coming up as your settings icon thanx for the theme and hard work keep at it

Primer Dark - quick panel is white - it should match the theme

Check if this occurs on Spacegray Light.

Error in Console

Errors parsing theme:
Rule is missing a class name

User > Preferences.sublime-settings

{
    "close_windows_when_empty": true,
    "color_scheme": "Packages/User/SublimeLinter/Espresso Soda (SL).tmTheme",
    "default_line_ending": "unix",
    "ensure_newline_at_eof_on_save": true,
    "highlight_line": true,
    "highlight_modified_tabs": true,
    "ignored_packages":
    [
        "Vintage"
    ],
    "rulers":
    [
        80,
        120
    ],
    "scroll_speed": 2.0,
    "show_encoding": true,
    "show_line_endings": true,
    "theme": "Primer.sublime-theme",
    "translate_tabs_to_spaces": true,
    "trim_trailing_white_space_on_save": true
}

Text in sidebar is truncated for Sublime Text 3.

Settings:

"theme": "Primer Dark.sublime-theme",
"theme_primer_sidebar_font_large": true,
"theme_primer_sidebar_tree_large": true,
"theme_primer_tabs_font_large": true,
"theme_primer_tabs_large": true

Color scheme primer.dark is white

Dev Build 3101 is out now at https://www.sublimetext.com/3dev
There's now a button on the status bar to switch between panels. If you have a custom theme, the relevant class name is panel_button_control.
Also changed is the way Sublime Text detects changes to open files. Sublime Text 2 would simply poll the current file whenever it was switched to. This has the disadvantage that any changes to the underlying file wouldn't be noticed until either the main window itself loses and then regains input focus, or the active file was changed to something else and then back. In practice, this was only an issue if there was a 3rd party changing the file behind the scenes. It also wouldn't notice background modifications to files that are never switched to.
Sublime Text 3 by and large worked around the missed notification issue by subscribing to file system change notifications, so that it didn't need to poll. To work around file systems that don't publish change notifications, it still polls files when an application window goes from an unfocused to a focused state, but not when simply switching between files. 3101 will now poll the active file when the active file changes, to better handle file systems that don't send change notifications.

I think that border should be lighter.

I've attached screenshot below

Hi @karelvuong,

Firstly, thank you for an amazing theme. May I request a less bright background color of your current color scheme (primer.light3 maybe). Current background is too bright and it hurt my eyes, I'm a fan of light color scheme though.

For your reference, can you please take a look at this PaperColor for Vim

I've installed Primer in Sublime Text build 3083 running on OS X 10.10.3. The Find panel looks great:

But in the Find in Files panel, the Replace row is partially cut off:

(It's cut off whether the status bar is shown or not.)

Package is reported as compatible with ST2, but when I try to enable it (OS X, not sure it matters) I get a completely unusable window.

Widget (search/replace) - input height is too big for font size 10/11

It is not the same as other panels.

The icon st-primer used for python file:

https://github.com/karelvuong/st-primer/blob/master/icons%2Ffile_type_python%402x.png

looks a little bit dim compare to the one that cobalt2 used:

https://github.com/wesbos/cobalt2/blob/master/icons%2Ffile_type_python%402x.png

I replaced it with cobalt2's, comparison as below:

Original Primer:

With python icon replaced with cobalt2's:

In my opinion the latter is better, how do you think :)

here is a little problem for the primer -light theme

the selected item's background color is too similar to white, It's really hard for me to see which one did I
choosed, can you add a setting to set the background color a litte more obviously

Observed as of c89952b commit in Windows 7 and Ubuntu, ST3 3086

The rendering of the horizontal and vertical scroll bars does not render consistently.
Rendering does appear to be correct using the dark theme.

Currently the code folding indicator is a low resolution picture and does not match the themes. Hope this could be improved.

The caret is great, but when I am jumping across panes it can be difficult to see what line you're on at first glance. I'm seeing this issue with the primer.dark.tmTheme.

When using a combiation of theme_primer_tabs_* and theme_primer_tabs_font_*, tab text is truncated.

Can't see the tail of the 'g' or the 'p'.

Please see attached image for example.

The current screenshots only reveal accent colors taking effect on the active tab and icons in the bottom panel.

plz scrollbars to the theme i had switch back to my other fav theme cause of its scrollbars btw its Theme - Numix

(request)

The theme is very well done, but the syntax theme (while nice) is not the Primer color scheme as displayed on the official site: http://primercss.io/

For example, here's a snippet in your theme

And the same snippet taken from the Primer site here

here 1.0.3 - uninstall, clean folder from old files, (re)install but nothing, there are not border on GoAnything Panel, it's a problem of my package?

I reverted back to the original sublime theme and now the icons are missing

I have changed the code from Briles/gruvbox to output Theme - Primer based on primer/github-textmate-theme.

Changes:

• no NDC variants
• no Soft, Medium, Hard variants
• no extras
• slightly changed README

Question:

• Would it be OK to add a PR for you, @Briles and @karelvuong?

Should fix #49, #48, #47, #41, #32, #31, #28 and if extras included from gruvbox also #24.

TODO:

• change accent colors to match Primer
  • recolor assets
  • recolor extras if included
• add Python file to automatically fix old settings during the transition phase to v2.0
  • fix color scheme and theme entries with new names
  • remove old other settings or replace if similar new found
• changes visuals for sidebar to match old Primer versions
• add menu and command palette entries if desired
  • use minihtml menu similar to equinusocio/material-theme if desired

Hey, I'm just gonna ask - are you planning on updating color scheme? With new sublime syntax definitions for JavaScript almost all code is in "red", which makes it unusable.

Hi, I have a problem. Sometimes the scrollbars behave strange, changing of color, and I can't distinguish the bars from the total space assigned it.

Here is an image that explain better the problem

Like you see the vertical and horizontal bars (of the text editor) doesn't appear, and the total space, where could be located, have been replaced with a grey bar.

Anyone knows the reason of this problem?

Really like this theme but, I've recently moved to using Atom. Is there an Atom UI + Syntax theme port for this?

Is this intended? It’s a little weird, made me think it was a .rss file.

More space for text-input and border for item row, as is in sidebar.

Hello! how can i enable the icon file type at the left sidebar panel in Primer theme by Sublime Text 3?

Hey Thanks for fixing the scrollbars anyway just noticed that the code completion for the dark theme is all white and doesnt match the theme at all so i went in and changed some stuff and i got this effect

here are the settings i changed

if you could implement these with your own changes it would be great Thanks

Custom title bar styling support added in Build 3127
Example: ctf0/Seti_ST3@f66ca9a

maybe the active background should be in blue?

Hello -- first of all thanks for putting together such a nice theme!

I'm having no problems with the light variation of the theme, but the Dark version doesn't seem to work at all.

I installed the package using Wbond's Package Manager, and I've confirmed that the "Primer Dark.sublime-theme" file exists, but it just doesn't want to apply.

I'm using Sublime Text 2, build 2221 on Linux.

Any thoughts?

perhaps it would be better to align all the center...

You're using tags, so to get the dark theme, we need a new release tag. :)

Folder: https://octicons.github.com/icon/file-directory/

Using the dark theme. And by "Out of focus" I mean the cursor is not on the ampersand.

Out of focus

In focus

the scrollbars need some adjusting when the "overlay_scroll_bars": "system" option is set . I cannot see the puck control .

So Sorry for but its just that when i'm in yml developing a new theme or color scheme it just looks weird

here take look

Color Scheme Example

• Notice the after the part of the string it doesn't stay green i know its little but its annoying

Theme Example

• Notice When you define property like layer0.opacity you get the red colon i know its easily overlooked but can you fix this plz & thank you in advance

In light mode it's very hard to tell which list item is selected. The difference is very subtle, especially if selected item is down the list.