karing / databc Goto Github PK

Testing on PHP 5.5, I ran into this syntax error:

[:error] [pid 7701] [client 192.168.123.1:39422] PHP Fatal error: Arrays are not allowed in class constants in /srv/www/d7-master/sites/default/files/civicrm/ext/DataBC/CRM/DataBCGeocode/Form/Settings.php on line 15, referer: http://d7-master.dev/civicrm/admin/setting/mapping?reset=1

Seems to be caused by the syntax in:
https://github.com/KarinG/DataBC/blob/master/CRM/DataBCGeocode/Form/Settings.php#L9

Suggested: All user-visible strings are wrapped in E::ts()

Non-blocking, very minor issues, such as usage of ts() instead of E::ts(), some strings missing, example the - select - here.

Please note: if you have selected DataBC above - you will likely want to select a backup method - to GeoCode non-BC addresses - on the DataBC admin settings page

The above "DataBC admin settings page" links to wp-admin/databcgeocode, which creates a 404 - can I confirm if this is intended?

Uploading it here for safekeeping

online_geocoder_rest_api.pdf