kayelgee / control-concealer Goto Github PK

i was wondering if this is still maintained as i dont see anyhting for V11

Please add a DM-only Settings with an option to hide button that allow players to change their controls personally. This is needed for newbie players who mess with controls or do not understand Development and Production levels, for OCD people who don't like to see additional controls, and for games where the DM wants to edit one setup and then propagate it to all players.

While the tabs properly hide when marked for hiding, they reappear on refresh of the page.

The scene must be reloaded each time to regain capabilities.

This is a nitpick but is extremely easy to implement. I noticed that the Module Simultaneous Combat System modifies the Tabs to Remove the default Combat Tracker. I no longer use that module, but the justification technique they used does improve the visuals after removing elements.

By default, the CSS of .tabs has "justify-content: flex-start;" as the value. BUT, it would be better off using
"justify-content: space-between;". By doing that, the Tab Icons always have even spacing between them, instead of having void space between at the end of the line.
Having Space-Between

In Edit Mode with Space-Between

Having Flex-Start :(

Hey, great module!

I'm running v9. Editing controls works as expected, and they are successfully hidden. Once any other control is selected, however, all hidden controls are revealed.

Sometimes when a module is updated, the names of certain controls change. Other times, such as here where I changed a setting, they aren't added to the tool palette. In these cases, the module is complaining that an expected control is missing, but this never goes away, even after toggling edit mode on and off like the error suggests. It will reappear on every reload. I attempted disabling and enabling the module, and uninstalling it completely and reinstalling it. Both resulted in the problem remaining once it was enabled again.

Here's the console error for Combat Numbers as an example:
Control concealer | couldn't find: {name: "combatNumbers", title: "COMBATNUMBERS.CONTROLS.title", icon: "fas fa-hashtag", layer: "CombatNumberLayer", tools: Array(0)} icon: "fas fa-hashtag" layer: "CombatNumberLayer" name: "combatNumbers" title: "COMBATNUMBERS.CONTROLS.title" tools: [] __proto__: Object

Hey! I like your module, it's exactly what I was looking for but I stumbled upon a pesky bug.

If Enhanced Terrain Layer button is hidden, when I click any other button, all buttons appear for a second and then disappear, then error is shown:

Ernie's UI enhancement breaks the positioning of the icons; or at least the icons break positioning with Ernie's.

I keep getting spammy notifications for Control Concealer.

Using Foundry VTT version 0.7.9 I am unable to select the Develop tab. The Production tab and Toggle edit mode buttons work just fine, but selecting the Develop tab button does nothing. So in essence the add-on still works, but not all functionality appears to be available. Additionally, with Edit mode activated and attempting to hide some tabs from the sidebar, I am able to select a tab but the tab selected is one to the left of the tab that my mouse cursor is over. Again, still functional but not quite right.

Is it possible to get this fixed soon? I'm enjoying the add-on but don't want to fully enable for my players until this is working a bit cleaner.

Hi,

On my screen with no other module active, the D, P and Edit buttons are completely misplaced preventing access.

I'm using the latest version of the module on V9

Here is a screen shot

I add/remove modules all the time. I get the controls have changed messages ALL THE TIME and it's super obnoxious. As DM, it's easy enough to click edit twice to make it go away, but I still have to dismiss these notifications to be able to do that. And then I have to log in as each player and do it for them, because my players aren't tech savvy enough to do this on their own.

It's a huge pain and it's totally unnecessary. If you found all the controls, why bother with these notifications? At the very least, please add a config option to hide this. Or prevent it from showing more than once, at least.

For example, I would love to be able to move drawing line from 2nd level of Basic Controls as second 1st level button... is this possible with the current way Foundry handles controls?

Every time I enter my game, or refresh, I receive a flood of errors:
Control concealer - Your controls don't match the saved controls. Some controls couldn't be found look at the console for more information! Start edit mode and end it to save and to suppress this message.

Looking the console, it looks like every toast popup is for the same error:

Control concealer | couldn't find:  
{name: "Parallaxia", title: "Irreversibly de-parallaxalize all Parallaxia tiles in the layer", icon: "fab fa-centos", button: true}
button: true
icon: "fab fa-centos"
name: "Parallaxia"
title: "Irreversibly de-parallaxalize all Parallaxia tiles in the layer"

It is only ever the parallaxia button that breaks it. Disabling the Parallaxia module, saving, and then open and closing edit mode to save the buton not being there any more prevents the issue from happening.

My guess is a race condition? The button isn't added to the code yet when CC loads and tries to find it based on the saved content?

Hi!
I wanted to test your great module, starting to have a few too many non-deactivatable tools, but it turns out that it seems to be incompatible with Combat Carrousel. I used Find the Culprit to find out why I couldn't save changes to the module, and it seems that with Combat Carousel enabled, your module just doesn't work anymore.

Edit : All latest version of Foundry, Combat Caroussel, Control Concealer ... And Dnd5e.

Thank you !