kazuar / country_data_codes Goto Github PK

Saw the post -- good stuff! Have some comments that may or may not be useful:

• Why not skip scraping the country code page urls? (like https://en.wikipedia.org/wiki/Country_codes:_A). Instead, you could just iterate from A to Z, construct the url, and if it 404s, then skip, otherwise scrape. Saves some code. (for example https://en.wikipedia.org/wiki/Country_codes:_J redirects to https://en.wikipedia.org/wiki/Country_codes:_J-K, so it's not a problem that some of the urls aren't regular)
• Why make alpha_two_to_country_name and alpha_three_to_country_name? There won't be any collisions, because length is different, so you could store everything in one dictionary.
• Why not just json serialize a dict in the format you want to use for lookup? Then you don't need this: country_data["country_name"].lower(): country_data for country_data in self._countries_data every time you load.

Anyways, feel free to close/delete if you want, just had some questions :)