Giter VIP home page Giter VIP logo

siftrain's People

Contributors

clemmyn23 avatar kbz avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

siftrain's Issues

[Request] Scrolling through beatmap list shouldn't select (+ font readability)

(Sorry that I can't explain this very well :<)

When scrolling through the beatmap/difficulty list, whatever song you tap on while dragging your finger is automatically selected, which is kind of weird; the majority of apps require an actual tap (not a drag) to select a menu item.

Normally this wouldn't be an issue (just awkward), but this select also plays the song preview, and these previews queue up after quickly selecting different songs. For example, if while scrolling through I select songs D, J, P, and then settle on song S, it'll play all the previews of the previous songs before S, even if S is currently selected. It's kind of annoying, especially if I don't recognise the song names due to them being in Japanese and can only distinguish via preview. :\

Also unrelated, but kind of an issue: font readability. I guess because of my smaller screen, the smaller text (version number, settings headers, etc.) doesn't resize nicely and becomes distorted and hard to read because of the weird bitmap(?) characteristics of the font. I guess this is more of personal opinion/request, but I'd suggest using a consistent, aliased font (think Noto Sans, Roboto, Arial, etc.) throughout the app as it'd resize better and be nicer on the eyes.

Stutters

RE: kbz's comment


huen6uu

adc435

I think I found it. Need a bit more testing though.

So basically every time the tap sound plays the SoundPool code runs through the permission check in appOps to see if sound playback is allowed. And for whatever reason one of the checks throws an error (which happens quite often as evident in the stutters) it defaults to false (ie. yolo we'll play the sound anyway) while throwing an expensive error.

This is platform specific to Android since Sound.java implements AndroidSound which uses SoundPool.

Proposed solution: implement a custom play() method and check appops permission on app load.

Thoughts?

Ask for storage permissions on Marshmallow

After upgrading my device from Android 5.1.1 to Android 6.0.1, SIF Train began crashing immediately on startup.

When I went into its App Info screen and manually turned on its ability to access the device storage, it worked again.

This seems to be the only thing keeping the app from working flawlessly on Marshmallow.

Notes out of sync

Since the latest update I have noticed that you most likely changed the function of the offset slider to affect the start point of the notes / song rather than affecting the hit timing for notes. the issue with doing that is that people (such as myself) who are used to an offset on SIF now are stuck with essentially a 0 offset, since with the new setting the notes might sound in sync with the song but hitting the notes is now unchanged from default.

If you could add the old function as a separate option that would be appreciated

[feature request] numbered notes

Would it be possible to number the note circles like this? I don't know how many people are using SIFTrain on BlueStacks, but it would be very helpful for people who are using it to get used to the keyboard layout and playing with all fingers. I'm sorry if I'm asking for something difficult. Thank you very much.
rlfatjr

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.