kdl-org / kdl4j Goto Github PK

The unit test TestParseIdentifier (trunk@59ced546f5227abcbd0b4c8a7d5bcddcb8ba6667) is identical to TestParseBareIdentifier.

Both call the parseBareIdentifier function, so parseIdentifier isn't directly covered. Seems like a minor typo?

Changing https://github.com/hkolbeck/kdl4j/blob/trunk/src/test/java/dev/hbeck/kdl/parse/TestParseBareIdentifier.java line 46 to call parseIdentifier results in a passing unit test calling the correct function, but should it have a different set of test data?

Hi! Since this was originally written, KDL has stabilized to 1.0.0. No further changes should be made to spec so it should be safe to update + finalize kdl4j to the 1.0 spec!

Please let me know if you have any questions or if there's anything I can do to help!

I've been testing kdl4j using the KDL document generator I wrote for fuzz testing, found here: https://github.com/hkolbeck/kdl-gen

I have not yet identified the source of all issues, but they can be reproduced by running kdl-gen and piping the result to https://github.com/hkolbeck/kdl4j/blob/trunk/src/main/java/dev/hbeck/kdl/Fuzzer.java. Due to a limitation of the BigDecimal class used internally, the kdl-gen argument --num-len-max should be set to 8 or less. It can be useful to utilize the --ascii-only flag as well if the issue doesn't depend on unicode.

When run, kdl-gen prints a seed value to stderr, if invoked again passing --seed <SEED> with the same arguments other than --debug it will replicate the same output. See the kdl-gen readme for info on possible arguments.

I'll call this closed when piping kdl-gen to the Fuzzer can be done 10,000 times in a loop with no parse errors.