Giter VIP home page Giter VIP logo

Comments (7)

khaosdoctor avatar khaosdoctor commented on July 27, 2024 1

On it after #42

from http-add-on.

arschles avatar arschles commented on July 27, 2024

cc/ @khaosdoctor

from http-add-on.

khaosdoctor avatar khaosdoctor commented on July 27, 2024

#42 is finished, on it

from http-add-on.

khaosdoctor avatar khaosdoctor commented on July 27, 2024

I'm thinking on changing a bit the API, here's the current one:

spec:
  appName:
  image:
  port:
  pollingInterval:

My suggestion:

spec:
  app:
    image:
    name:
    port:
    labels:
    annotations:
  ingress:
    labels:
    annotations:
    host:
    enabled:
  service:
    labels:
    annotations:
    port:
  pollingInterval:
  labels: # For common labels
  annotations: # For common annotations

from http-add-on.

arschles avatar arschles commented on July 27, 2024

@khaosdoctor I'd like to keep the spec simple for now, so how about something that will add annotations to all created resources:

spec:
  appName:
  image:
  port:
  pollingInterval:
  annotations: # the fields in here will be put as annotations on all created resources

if there's a use case for custom annotations on some resources but not others, I'm open to breaking out the resources as you suggested. WDYT?

from http-add-on.

khaosdoctor avatar khaosdoctor commented on July 27, 2024

No objections here, should I add labels as well?

from http-add-on.

khaosdoctor avatar khaosdoctor commented on July 27, 2024

Closing this one up because of #35 becoming the main workflow for users

from http-add-on.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.