keefertaylor / base58swift Goto Github PK

View Code? Open in Web Editor NEW

12.0 2.0 13.0 729 KB

A pure swift implementation of base58 string encoding and decoding

License: MIT License

Ruby 11.38% Swift 88.62%

base58 cryptocurrency swift

base58swift's People

Contributors

Stargazers

Watchers

Forkers

microhexhq vaultie hasibeoztok a2hill kylinge mghnmtt gre4ixin unrealtechnologies happy-health alimyuz reonarudo heckj

base58swift's Issues

Bug when decoding `11111111111111111111111111111111`

The decoding of string 11111111111111111111111111111111 to bytes wasn't correct
Expected result: [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0]
Reality: [49,49,...]

Type 'Base58' has no member 'encode'

Attempted to use example code from README

        let bytes: [UInt8] = [255, 254, 253, 252]

        let encodedString = Base58.encode(bytes)
        let decodedBytes = Base58.decode(encodedString)!

        print(encodedString) // 7YXVWT
        print(decodedBytes)  // [255, 254, 253, 252]

Fails to compile with noted error

Decoding fails if the data's first byte is 0

Example:

let bytes: [UInt8] = [0, 128, 128, 128]
let encodedString = Base58.base58CheckEncode(bytes)
let decodedBytes = Base58.base58CheckDecode(encodedString)!  // <- fails here

Base58 Encoded string not being properly decoded

What is the issue:

When I go ahead and encode a value to Base58, everything works as intended (e.g., correct hash). However, when decoding, I receive the incorrect value. Here is the example:

let test = Base58.base58Encode([UInt8]([0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9]))  // "1Bhh3pU9gLXZhoVxkr5wyg9sX6"
let test2 = Base58.base58Decode(test)  // [49, 1, 2, 3, 4, 5, 6, 7, 8, 9, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9]

Expected: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
Received: [49, 1, 2, 3, 4, 5, 6, 7, 8, 9, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9]

Is there a plan to add support for Swift Package Manager in the near feature?

Xcode 11 takes Swift packages to the level where they are finally fully useable. I think it would be cool to add the support for it.

swiftlint required but not a dependency

Trying to install TezosKit via carthage.

*** Building scheme "Base58Swift_macOS" in Base58Swift.xcodeproj
Build Failed
	Task failed with exit code 65:
	/usr/bin/xcrun xcodebuild -project /Users/jojo/Documents/CodeProjects/MyProj1/Carthage/Checkouts/Base58Swift/Base58Swift.xcodeproj -scheme Base58Swift_macOS -configuration Release -derivedDataPath /Users/jojo/Library/Caches/org.carthage.CarthageKit/DerivedData/12.3_12C33/Base58Swift/2.1.14 ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES archive -archivePath /var/folders/76/q9_yh34j5wd23ksxl7b70ssm0000gn/T/Base58Swift SKIP_INSTALL=YES GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=NO CLANG_ENABLE_CODE_COVERAGE=NO STRIP_INSTALLED_PRODUCT=NO

...
...
/Users/jojo/Library/Caches/org.carthage.CarthageKit/DerivedData/12.3_12C33/Base58Swift/2.1.14/Build/Intermediates.noindex/ArchiveIntermediates/Base58Swift_macOS/IntermediateBuildFilesPath/Base58Swift.build/Release/Base58Swift_macOS.build/Script-836D7AF445A97E1216598BA1.sh: line 2: swiftlint: command not found

This "swiftlint" seems to be some 3rd party tool? But none of the documentation for Base58Swift says I need to install it and it is not a dependency list anywhere

keefertaylor / base58swift Goto Github PK

base58swift's People

Contributors

Stargazers

Watchers

Forkers

base58swift's Issues

Bug when decoding `11111111111111111111111111111111`

Type 'Base58' has no member 'encode'

Decoding fails if the data's first byte is 0

Base58 Encoded string not being properly decoded

Is there a plan to add support for Swift Package Manager in the near feature?

swiftlint required but not a dependency

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent