Giter VIP home page Giter VIP logo

keepassxc-browser's People

Contributors

3nt3 avatar acasset avatar ashus avatar bendingbender avatar bwbroersma avatar cdevienne avatar cypx avatar dependabot[bot] avatar diadlo avatar djcrashdummy avatar droidmonkey avatar dxdc avatar frederick888 avatar hauk92 avatar jaller94 avatar jeroened avatar jrc03c avatar layalk avatar magicfab avatar onthegocode avatar phoerious avatar reimer-atb avatar schlimmchen avatar stefansundin avatar thetric avatar tinyoverflow avatar transifex-integration[bot] avatar tremby avatar varjolintu avatar xf- avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

keepassxc-browser's Issues

Credential drop down select not shown on initial page load

Expected Behavior

After you press "Allow" from the credential pick list from KPXC the credential list should appear when you focus on the username/password field on the page.

Current Behavior

The credential list does not appear unless you reload the page, press "redetect credential fields", or tab in/out.

Possible Solution

Automatically perform a credential detection on the loaded page after KPXC sends credentials.

Steps to Reproduce (for bugs)

  1. Load a login page (https://twitter.com/login)
  2. When the credential list appears, press Allow
  3. Focus on the Username field
  4. Nothing appears that lets you fill in the credentials

General Info

KeePassXC fork - 2.3.1
keepassxc-browser - 1.0.1

Operating system: WIN
Browser: Chrome
Proxy used: YES

On unsuccessful match browser extension opens debug console

When I try to log in to a site that should have a valid User/Pass combination stored but the site does something unexptected (e.g. change after the username has been filled in by autofill) the extension opens a debug console window and shows me:

Connecting to native messaging host org.keepassxc.keepassxc_browser  keepass.js:870:5
Server public key: <REDACTEDKEY>  keepass.js:620:17
Error 15: No logins found keepass.js:954:5
Error: Nonce compare failed  keepass.js:938:9
Error 15: No logins found keepass.js:954:5
Error: Nonce compare failed keepass.js:938:9
Error 15: No logins found  keepass.js:954:5
Error: Invalid tab ID: 99  event.js:75:22
Error: Invalid tab ID: 116  event.js:75:22
Error: Invalid tab ID: 124  event.js:75:22
Error: Invalid tab ID: 124  event.js:75:22
Error: Invalid tab ID: 135  event.js:75:22
Error: Invalid tab ID: 153  event.js:75:22
Error 15: No logins found  keepass.js:954:5
Error: Nonce compare failed keepass.js:938:9
Error 15: No logins found  keepass.js:954:5
Error: Nonce compare failed keepass.js:938:9
Error 15: No logins found

I think the important line here is:

alert() is not supported in background windows; please use console.log instead.

I can then not autofill anything on that page. Once I close the debug window it does not reappear on reload or trying to reload the page. I'm currently a bit unsure how to reliably reproduce this.

Expected Behavior

I would expect to get a extension native error message stating that no login was found.

Current Behavior

It opens a debugging console and does not perform autofill.

Steps to Reproduce (for bugs)

Load website were login is "unclear" (not sure how to describe)

Context

Some websites require me to manually copy credentials since auto fill and filling through rightclick menu won't work.

Debug Info

Firefox 58.0.2
KeePassXC-Browser Version: 1.0.1
KeePassXC Version: 2.3.0
macOS 10.12.6

KeePassXC - Version 2.3.0
Revision: 4c0ed74

Libraries:

  • Qt 5.9.3
  • libgcrypt 1.8.2

Operating system: macOS Sierra (10.12)
CPU architecture: x86_64
Kernel: darwin 16.7.0

Enabled extensions:

  • Auto-Type
  • Browser Integration
  • Legacy Browser Integration (KeePassHTTP)
  • SSH Agent
  • YubiKey

Network?

Legacy KeePassHTTP was able to act as "server" through network. Please keep this functionality!

Use proper brand color

Expected Behavior

KeePassXC-Browser should use the correct brand colors.

Current Behavior

The settings header uses a darker green than the one we use on our website.

Password field detection not working on citi

The username is detected, but not the password field. Site does not recognize the username as being filled even when it appears to be filled visually.

Expected Behavior

The username and password field are detected and autofilled after being dynamically generated.

Current Behavior

Username is autofilled but not the password field.
Website does not recognize that the username has been entered, so you have to use the shortcut to fill it in again.

Possible Solution

Add further password field detection. Make website recognize that the username field has been filled.

Steps to Reproduce (for bugs)

  1. enable Automatically fill-in single credentials entry.
  2. visit citi.com which redirects to https://online.citi.com/US/login.do

General Info

KeePass Version 2.38
keepassnatmsg 2.0.0.9
keepassxc-browser - KeePassXC-Browser Version: 1.0.1

Operating system: Windows 10 pro 1709 64bit
Browser: Chrome Version 64.0.3282.186 (Official Build) (64-bit)
Proxy used: NO

KeePassXC Version Detection

Expected Behavior

A higher version than the last known highest version wouldn't trigger the out of date alert.

Current Behavior

Observed the extension notifying me of my "out of date" KeePassXC version. The status eventually cleared which may have been when the extension pulled the latest info from the server. Also the error message should probably read "You are using an older version of KeePassXC, recommend you update to the latest version."

browser_version_detect

Possible Solution

Check the numbers and if they are greater than or equal to what the extension knows is the latest, do not alert the user.

Debug info

General Info

KeePassXC fork - 2.3.1
keepassxc-browser - 0.5.2

Operating system: WINDOWS
Browser: CHROME
Proxy used: YES

How to connect to recent keepassxc source build?

I am working on keepassxreboot/keepassxc#850 and want to integrate all my work into the native messaging server.

However, I can't seem to connect to it using firefox from either the keepassxc-browser or keepassxc-browser-fork extension.

My KeepassXC build is based off of keepassxreboot/keepassxc@92dd4c0 right now. I built with -DWITH_TESTS=OFF -DWITH_XC_HTTP=ON -DWITH_XC_BROWSER=ON and enabled all the options in "Browser extension with native messaging" in KeepassXC.

The extensions, both keepassxc-browser-fork 0.4.5.1 and and keepassxc-browser 0.4.8, are stuck at "Timeout or not connected to KeePassXC" and I don't see any way to fix it.

I'm using Firefox 57.0.4 on archlinux.

Save credentials right click menu storing password as username

Expected Behavior

Using the "Save credentials" dialog after right clicking on a username or password should allow the creation of a new login with the correct attributes.

Current Behavior

Accessing the "Save credentials" dialog by right clicking on the username field correctly creates a new login.

Accessing the "Save credentials" dialog by right clicking on the password field creates a new login with the username and password values both being set to the password. E.g.:

screen shot 2018-02-27 at 8 53 33 pm

Steps to Reproduce (for bugs)

  1. Open firefox and navigate to any login page
  2. Enter a username and password
  3. Right click on the password field and Select "KeepassXC-Browser->Save credentials"
  4. Observe the popup dialog has the password displayed in the username field
  5. (Optional) open the new record in Keepassxc and observe both the username and password values contain the password

General Info

KeePassXC fork - 2.3.0 (default settings)
keepassxc-browser - 1.0.0 (default settings)

Operating system: macOS 10.13.3
Browser: Firefox 58.0.2 (64-bit)
Proxy used: No

A little bit of usage documentation :)

Currently, neither the README nor the Chrome/Mozilla installation pages say what the addon actually does.

Would be nice with just a couple of sentences or a bullet list stating what the main features are. Perhaps a screen shot or two.

I found this which is really good: https://github.com/pfn/passifox/blob/master/documentation/chromeIPass.md

It does not have to be so comprehensive, but I'm sure there's some good stuff in there that could be used for starters.

Finally, it would also be nice if there was a short section discussing the difference between global auto-type and this addon, both UX wise and security wise.

Thanks!

Build instructions

Hi,

Is there a way to build the extensions from source instead of downloading them from the chrome / firefox store?

Thanks!

Cannot log into sites with 2FA token input fields of type password

When I try to login to a site which requires a username and password on the first page, and then am brought to a second page which asks for a SMS token to be entered (in an input field of type password), I am unable to successfully enter the SMS token. When the cursor is moved out of the 2FA token field, immediately the password stored in keepassxc is auto-filled. There does not seem to be a way of preventing this. In order to login to the site, I had to revert back to the old chromeIPass extension.

Expected Behavior

If I have entered text into a password field manually, I would expect the extension not to wipe out what I entered.

Current Behavior

The 2FA token is always wiped (apparently replaced by the site's stored password) when moving the cursor outside of the input field.

Possible Solution

Either don't autofill password fields where a user has already inputted text, or provide some other workaround to allow logging into a site such as this.

Steps to Reproduce (for bugs)

  1. Go to site which requires username and password on the first login page.
  2. Click on username field and select login from drop down.
  3. Click sign in button.
  4. On next page where 2FA token is requested in a password field, type in 2FA token manually or copy and paste from external 2FA token application.
  5. Watch the contents of the password field change length.

Debug info

This is the html input field for the 2FA token:

General Info

KeePassXC fork - KeePassXC version: 2.3.0
keepassxc-browser - KeePassXC-Browser Version: 1.0.0

Operating system: Ubuntu 17.04
Browser: Google chrome beta: Version 65.0.3325.106 (Official Build) beta (64-bit)
Proxy used: YES

Transfering old repositories

Why not transferring old repositories from @varjolintu account instead of duplicating them?
This would allow you to keep all issues for example...
You can do it by going to each repository page then Settings > Danger Zone > Transfer ownership

accept "KeePassHttp Settings" attribute

Expected Behavior

I used the keepasshttp extension before to access password out of my browser. With the new version keepassxc changed to the new "keepass browser" protocol. It would be absolutely great if it would accept the "KeePassHttp Settings" from the previous extension, or just directly converts them (after asking the user) to the new "KeePassXC-Browser Settings" attribute.

Current Behavior

It does not accept the previous setting. and on every page it asks me if I want to accept access to the password or not, it drives me nuts. I've got dozens, if not hundreds, of page logins stored, with some allow and deny rules. To update them all by hand would take forever.

General Info

KeePassXC fork - 2.3

Vivaldi on Windows using NativeMessagingHosts of Google Chrome

Vivaldi is using the messaging hosts declared in registry directory of Google Chrome. Therefore selecting Vivaldi in the settings of KeePassXC will fail to enable the plugin.

Expected Behavior

Activating browser integration for Vivaldi in the settings of KeePassXC sets the NativeMessagingHost for Vivaldi and the extension can connect to the browser.

Current Behavior

The NativeMessagingHost ist set in a directory of the registry that is never queried, therefore no NativeMessagingHost is registered. The extension does say so when being debugged.

Possible Solution

Just do the same for Vivaldi on Windows as you are doing when activating browser support for Google Chrome, e.g. create the NativeMessagingHost not in "\HKCU\Software\Vivaldi\NativeMessagingHosts\org.keepassxc.keepassxc_browser" but in "\HKCU\Software\Google\Chrome\NativeMessagingHosts\org.keepassxc.keepassxc_browser"

Steps to Reproduce (for bugs)

  1. Use Windows
  2. Enable Browser integration for Vivaldi
  3. Install extension in vivaldi
  4. Try to connect to database (fails with silent error ->debugging says no native host found)

Debug info

General Info

KeePassXC fork - 2.3.0
keepassxc-browser - 1.0.1

Operating system: Win10
Browser: Vivaldi
Proxy used: YES (but obviously the same with no proxy)

Extension blocks and waits forever in HTTP access

When a website requires HTTP access control (as configured typically in in .htaccess files), chrome will wait forever for KeePassXC-Extension, probably for a password.

Expected Behavior

It should at least fail at some point when the Database does not have

Current Behavior

Its stuck, as described

Possible Solution

Steps to Reproduce (for bugs)

  1. Have a website with HTTP access control (the site I tested was over HTTPS with a client certificate, dont know if its relevant)
  2. Password input field is never shown and status bar shows "waiting for KeePassXC-Extension.."

Debug info

General Info

KeePassXC - 83f1a53d32916f31a70462c54beea07b863f7936
keepassxc-browser - 0.5.1 (23-01-2018

Operating system: Ubuntu 16.04
Browser: Chrome 64
Proxy used: NO

"Choose own credential fields for this page" tool selecting wrong window

Expected Behavior

While selecting custom credential fields using the "Choose own credential fields for this page" tool, the in-focus window (i.e, the one the user clicked on the Keepassxc-Browser extension icon from) should display the UI for selecting the appropriate fields.

Current Behavior

It is possible for the in-focus window to not have the credential selection UI drawn on it, but instead for the UI to be drawn on a different, entirely unrelated window. e.g.:

screen shot 2018-02-27 at 8 12 11 pm

When the github issue page is not open in a different window, the UI is properly displayed on the intended page.

Steps to Reproduce (for bugs)

  1. Open firefox (close all tabs if any open)
  2. Navigate to any url (e.g., https://www.facebook.com/)
  3. In a new window (not tab), navigate to https://github.com/keepassxreboot/keepassxc-browser/issues/new (leave it at the new issue creation page without modifying anything)
  4. Return to the facebook window, click on the Keepassxc-Browser extension and select "Choose own credential fields for this page"
  5. Examine the current window, nothing will appear. Examine the github issue page, observe that the credential selection UI is drawn with the "Search" and "Title" fields highlighted.

General Info

KeePassXC fork - 2.3.0 (default settings)
keepassxc-browser - 1.0.0 (default settings)

Operating system: macOS 10.13.3
Browser: Firefox 58.0.2 (64 bit)
Proxy used: No

New credentials from the browser are not saved

When I perform a signup on a new site, the new credentials are not saved into KeePassXC

Expected Behavior

After completing the signup and clicking the blinking toolbar icon, the new credentials should be immediately available when alt-tabbing to KeePassXC

Current Behavior

New credentials are not saved

Steps to Reproduce (for bugs)

  1. Signup on any new site (e.g. here)
  2. perform signup (also using suggested pwd)
  3. toolbar icon blinks prompting to click to save new pwd entry into DB
  4. alt-tab to KeePassXC, new credentials not saved

Debug info

KeePassXC - 2.3.1
keepassxc-browser - 1.0.1
Operating system: Ubuntu 17.10 (64-bit)
Browser: Chromium 64.0.3282.167+ Firefox 60b2
Proxy used: YES
Other: Tools > Settings > Automatically save after every change: ON

Thanks!

RFE: Use the same database for several users

We use internally keepass/keepassxc on a synced storage (with Seafile, a dropbox clone) between several users, to store user/login for the IT service.
We currently don't use any browser extension to autofill entries, but we are thinking about it.

can the same database be used with several users/browser ? it seems that an entry at root is added:
KeePassXC-Browser Settings

XML pretty-print gets broken by the extension (Firefox)

Expected Behavior

Pretty print should work like it does on xml documents

Current Behavior

image
This issue is mitigated partially by https://github.com/keepassxreboot/keepassxc-browser/blob/develop/keepassxc-browser/manifest.json#L45-L48 so it was "fixed" on documents with .xml and .xsd endings but is still present when the xml document doesn't contain that extension.
Some more information (e.g. that jQuery is the issue) is at smorks/keepasshttp-connector#32

Possible Solution

Steps to Reproduce (for bugs)

  1. Open an xml document without the .xml or .xsd extension with the extension enabled

Database not connecting (Chromium, Debian-Stretch, KeePassXC 2.31)

Expected Behavior

With an open KeePassXC database, KeePassXC-Browser should be able to detect the open database and begin the connection process.

Current Behavior

Plugin does not recognize open database, clicking reload does nothing, and database cannot connect
screenshot from 2018-03-08 14-02-41
screenshot from 2018-03-08 14-03-31

Debug info

No Error Messages

General Info

KeePassXC fork - 1.0.1
keepassxc-browser - 2.3.1

Operating system: Debian - Stretch
Browser: Chromium 64.0.3282.119
Proxy used: No

"Uncaught (in promise)" error in console in incognito

When using KeepassXC browser in Chrome (v64) and browsing in incognito mode, the extension throws an error in the console.

Expected Behavior

I would expect there to be no console error.

Current Behavior

See above.

Steps to Reproduce (for bugs)

  1. Be using KeepassXC Browser in Chrome with the extension set to Allow in incognito.
  2. Browse to a site in an incognito window (www.reddit.com seems to reliably cause the error).
  3. Open console and view error.

Debug info

Uncaught (in promise) {message: "The message port closed before a response was received."}

  | n | @ | browser-polyfill.min.js:1
  | sendResponseAndClearCallback | @ | VM30 extensions::messaging:417
  | disconnectListener | @ | VM30 extensions::messaging:441
  | EventImpl.dispatchToListener | @ | VM23 extensions::event_bindings:403
  | publicClassPrototype.(anonymous function) | @ | VM29 extensions::utils:138
  | EventImpl.dispatch_ | @ | VM23 extensions::event_bindings:387
  | EventImpl.dispatch | @ | VM23 extensions::event_bindings:409
  | publicClassPrototype.(anonymous function) | @ | VM29 extensions::utils:138
  | dispatchOnDisconnect | @ | VM30 extensions::messaging:378

General Info

KeePassXC fork - 2.3.0
keepassxc-browser - 1.0.1

Operating system: Mac
Browser: Chrome (v64)
Proxy used: unknown

KeePassXC Browser not working on sites, where login is split into multiple sites

KeePassXC Browser (aswell as KeePasshttp before) is not working on sites, where login is split into multiple sites. Most known example for this would be Google.

Expected Behavior

The browser plugin detects credential fields correctly

Current Behavior

On sites like Google, where the login is split into zwo seperate sites, the plugin does not work properly. You have to type your email adress manually. Selecting the password works though.

Possible Solution

Eighter hardcode a behavior for the few sites that use multiple sites for login into the plugin, or maybe add a way to make custom credential fields work with those sites.

General Info

KeePassXC fork - 3.2.0
keepassxc-browser - 1.0.0

Operating system: Win 10, Ubuntu 17.10 (does not matter)
Browser: 59.0b13 (64-Bit) (does not matter)
Proxy used: NO

KeePassXC-Browser don't work with Iridium Browser

KeePassXC-Browser don't work with Iridium Browser.

Iridium seems to be a privacy enhanced browser based on Chromium.
Don't know how active the project is actually.
https://github.com/iridium-browser/tracker/wiki/Differences-between-Iridium-and-Chromium
Current version is 2017.10
(based on Chromium 61.0.3163.100)

Expected Behavior

KeePassXC-Browser Integration asking for credentials.

KeePassXC-Browser Integration should work with Iridium

Current Behavior

After integration of KeePassXC-Browser nothing happens. No database is detected.
It doesn't ask for credentials. It only has encountered an error:
"Timeout or not connected to KeePassXC"

Possible Solution

Maybe it happens only because of the name of the browser?

If I should file the issue to the Iridium project, please give a short reply.

After creating the directory ~/.config/iridium/NativeMessagingHosts and copying org.keepassxc.keepassxc_browser.json from Chromium it seems to work.

keepassxreboot/keepassxc#1559

Steps to Reproduce (for bugs)

  1. Install latest Iridium Browser
  2. Add KeePassXC-Browser extension to Iridium
  3. Plugin is running, but nothing more
  4. KeePassXC-Browser has encountered an error

Debug info

There is nothing in the JavaScript console

KeePassXC-Browser has encountered an error:
Timeout or not connected to KeePassXC

General Info

KeePassXC fork - Version 2.3.0
Revision: 4c0ed74
keepassxc-browser - Version 1.0.0

Operating system: Ubuntu 16.04.4 LTS
Browser: Firefox, Chromium, Iridium
Proxy used: NO

"Timeout or not connected to KeepassXC" (Windows)

Expected Behavior

The extension should detect running copy of keepassxc

Current Behavior

Extension displays "Timeout of not connected to KeepassXC"

Steps to Reproduce (for bugs)

  1. This happens always

Debug info

Connecting to native messaging host org.keepassxc.keepassxc_browser
keepass.js:846 Failed to connect: Specified native messaging host not found.
keepass.js:954 Error 5: Timeout or not connected to KeePassXC
Uncaught (in promise) TypeError: Cannot read property 'onMessage' of null
    at Promise (keepass.js:92)
    at new Promise (<anonymous>)
    at Object.keepass.sendNativeMessage (keepass.js:89)
    at Promise (keepass.js:609)
    at new Promise (<anonymous>)
    at Object.keepass.changePublicKeys (keepass.js:590)
    at setTimeout (event.js:157)

General Info

KeePassXC fork - 2.3.1
keepassxc-browser - 1.0.1

Operating system: Windows
Browser: Chrome
Proxy used: Yes (according to Advanced tab of Browser Integration setting)

Other relevant information

This used to work with when I had 2.3.0 portable version running. With 2.3.1, I deleted the portable version and chose to install the .exe file. Ever since then keepassxc-browser can't detect the running copy of KeepassXC.

Also, when I look at running tasks in Task Manager, I only see KeePassXC.exe, however, I remember seeing some tasks with keepassxc-proxy with 2.3.0 that I don't see now.

"Fill TOTP" does nothing on right click menu

Expected Behavior

When selecting the option "Fill TOPT" opened by right-clicking a text box the configured TOTP for the current page (Keepassxc entry) should be pasted.

Current Behavior

When "Fill TOTP" is clicked nothing happens, the textbox is still empty.

Steps to Reproduce (for bugs)

  1. Fill in you user/password using the extension (the keepassxc entry must have TOTP set up)
  2. When prompted for a TOTP right click the textbox, -> KeePassXC-Browser -> Fill TOTP
  3. Nothing happens even though the current entry has TOTP set up.

Debug info

No error generated on the console

General Info

KeePassXC - Version 2.3.0
Revision: 4c0ed74

Libraries:

  • Qt 5.10.1
  • libgcrypt 1.8.2

Operating system: Windows 10 (10.0)
CPU architecture: x86_64
Kernel: winnt 10.0.16299

Enabled extensions:

  • Auto-Type
  • Browser Integration
  • Legacy Browser Integration (KeePassHTTP)
  • SSH Agent
  • YubiKey

Proxy used: NO

Remove the dialog for multiple accounts

The alert notifying the user about there being multiple accounts when using "Fill User + Pass" is breaking the user flow and is simply annoying. Additionally it has no further purpose as telling the user the same as the dropdown with the users tells - to select the account one wants.

Expected Behavior

When selecting "Fill User + Pass" in the context menu, show no alert but only the dropdown with the accounts.

Current Behavior

When selecting "Fill User + Pass" in the context menu, the plugin shows an unnecessary alert, when there are multiple accounts.

Possible Solution

Just remove the dialog.

Steps to Reproduce (for bugs)

  1. Go to a page you have multiple accounts for.
  2. Select from the context menu "Fill User + Pass"
  3. The unnecessary dialog appears

Debug info

General Info

KeePassXC fork - unimportant
keepassxc-browser - latest

Operating system: unimportant
Browser: unimportant
Proxy used: unimportant

Extension icon is missing HiDPI support

The icon is pixellised.

Expected Behavior

The icon should be crisp on HiDPI display.

Current Behavior

The loaded icon does not seem to take into account HiDPI.

Possible Solution

Other extensions do it, so it should be easy.

Steps to Reproduce (for bugs)

  1. Open Firefox in HiDPI mode.
  2. See all icons being crisp excepted for keepassxc-browser.

General Info

KeePassXC - N/A
keepassxc-browser - 1.0

Operating system: Linux
Browser: Firefox (Nightly)
Proxy used: N/A

keepassxc-browser interferes with Proxy SwitchyOmega

Expected Behavior

Should not try to send credentials for proxies SwitchyOmega (PSO) already have correct ones.

Current Behavior

When trying to access a sites that PSO routes through a basic authentication secured proxy server which credentials have already been entered in the PSO settings keepassxc-browser still tries to overrule the PSO credentials. But if you don't have the proxy credentials stored in the password database keepassxc-browser tells that it has multiple credentials (which is not true as it does not have any) and the basic authentication at the proxy fails, One then has to enter the credentials manually which leads to storing them in Chrome itself.

chromeIPass as an example does not interfere with PSO (don't know why ;)).

Possible Solution

keepassxc-browser should not send credentials for proxies PSO already have them in it's own settings.

Steps to Reproduce (for bugs)

  1. Install keepassxc-browser and PSO
  2. Configure PSO to automatically route some sites through a Squid proxy with basic authentication turned on
  3. Try to access the sites
  4. Look at keepassxc-browser's error message and take a look at Google Chrome's extensions (orange exclamation mark should be visible saying that PSO wasn't able to send credentials becaus keepassxc-browser already sent some)

Debug info

Don't have any right now.

General Info

KeePassXC fork - 2.3.1
keepassxc-browser - 1.0.1

Operating system: MS Windows 10
Browser: Google Chrome
Proxy used: YES

Can't connect to KeePassXC on Windows 7 using Firefox 59

Expected Behavior

The keepassxc-browser extension for Firefox should connect to KeePass portable on Windows 7.

Current Behavior

The keepassxc-browser extension for Firefox cannot find running instance of KeePass portable on Windows 7.

Possible Solution

Steps to Reproduce (for bugs)

  1. Download KeePassXC portable for Windows 7.
  2. Install keepassxc-browser extension for Firefox
  3. Start KeePassXC. Enable browser integration
  4. "Connect" button does not appear. Instead "timeout or not connected to KeePassXC" message displays and the "Reload" shows up.
  5. Click "Reload" button. Nothing happens.
  6. Go to extension settings, then "Connected Databases". No databases are listed. Click "Connect" button. Still nothing happens.

Debug info

After enabling add-on debugging (about:debugging) there's some error messages.

After clicking on the "Reload button":
debugger_console

General Info

KeePassXC - 2.3.0
keepassxc-browser - 1.0.0

Operating system: Windows 7 64 bits
Browser: Firefox 59.0b14 (64-bit)
Proxy used: YES

  • Tried KeePassXC portable and installer. Same behavior.
  • Tried with and without proxy. Same behavior.
  • Tried with a fresh Firefox profile with no other extensions. Same behavior.
  • Interestingly, I also enabled "Legacy Browser Integration" and installed KeePassHttp-Connector extension. That extension works without any issues.

Update copyright footer

Expected Behavior

The copyright footer should primarily list KeePassXC Team as copyright owner. Other contributors can be listed in a special acknowledgement section somewhere in the settings.

This needs to be done before we release a version 1.0, which we want to do early next week

Current Behavior

Previous KeePassHTTP contributors are listed there, KeePassXC Team is missing.

Cannot access right-click menu in custom credential fields

Expected Behavior

After setting custom credentials fields for a webpage, the user should be able to right click on a newly-designated credential field to access the KeepassXC-Browser dialog. Symmetrically, right clicking on a field no longer designated for credentials should not prompt for the menu (secondary concern).

Current Behavior

Right clicking on "old" credentials fields will always present the KeepassXC-Browser dialog. Right clicking on a newly designated credentials field will not present the KeepassXC-Browser dialog. This is particularly problematic if a page were to contain no preexisting credentials fields (the user would then be unable to access the KeepassXC-Browser dialog at all).

Steps to Reproduce (for bugs)

  1. Open a webrowser to any webpage with at least 3 fields.
  2. Click KeepassXC-Browser extension icon->Choose own credential fields for this page
  3. Select a new username (and/or new password) field.
  4. Right click on old, now defunct username field. Observe right click menu dialog for KeepassXC-Browser is present
  5. Right click a newly-designated username field. Observe right click menu dialog for KeepassXC-Browser is not present

General Info

KeePassXC fork - 2.3.0 (default settings)
keepassxc-browser - 1.0.0 (default settings)

Operating system: macOS 10.13.3
Browser: Firefox 58.0.2 (64 bit)
Proxy used: No

Allow selection of existing keepassxc entry for page

Expected Behavior

This is a feature request.

When encountering a password field, rather than just looking for a matching database entry from URL and/or page title also provide the option to manually select from any entry in the database (and have the option to remember the selection for a particular page).

This is useful where one credential is used across multiple websites (due to shared backends, not poor password reuse). It also allows the user to sort their credentials in names and folders outside of the "KeePassXC-Browser Passwords" group.

This is additionally useful for users of keepassxc who have just installed the browser extension and may not have their existing entries named appropriately enough to match.

Current Behavior

If an entry doesn't match properly I am unable to enter it using the plugin.

HTTP auth dialog multiple credentials

Expected Behavior

If multiple credentials are available on HTTP auth dialogs I should be able to select the right one.

Current Behavior

Currently keepassx-browser chooses one of the saved credentials on HTTP auth dialogs, resulting in using the wrong credentials.

Possible Solution

Show selection if multiple credentials on HTTP auth dialogs are available.

New browser - Firefox plugin forgets connection, reconnects and then errors.

Firstly, great job with the plugin 👍

Error message from keepassxc on pressing the plugin icon.

Cannot encrypt message or public key not found. Is native messaging or support for your browser enabled in KeePassXC?

Pressing the 'Reload' button gives me the following error;

KeePassXC-Browser has been disconnected from KeePassXC.
KeePassXC association failed, try again

Press the reconnect button to establish a new connection.

Expected Behavior

Connection is made and never forgotten until the connection is deleted by the user.

After being asked if I want to replace the connection with the same name, I should still only have one active connection showing in the connections section of the plugin.

I have two showing as active with the same name?

Current Behavior

I have successfully made a connection between keepassxc and the new plugin but after a while the plugin asks again to connect to keepassxc, even though the current one still exists.

I create another connection using the same connection name and it correct asks me if I want to overwite the previous one, to which I say yes.

I start using again, all is well until again it appears to lose connection and give me the above error.

Debug

Firefox Plugin:
KeePassXC-Browser Version: 1.0.1
KeePassXC Version: unknown

KeePassXC - Version 2.3.0-snapshot
Build Type: Snapshot
Revision: a06e85f

Libraries:

  • Qt 5.10.1
  • libgcrypt 1.8.2

Operating system: Arch Linux
CPU architecture: x86_64
Kernel: linux 4.15.6-1-ARCH

Enabled extensions:

  • Auto-Type
  • Browser Integration
  • Legacy Browser Integration (KeePassHTTP)
  • SSH Agent
  • YubiKey

Shows Same Notification (over and over) through libnotify on each autotype

Every single time I use autotype, the following notification appears through libnotify:

(A) KeePassXC-Browser Create or modify the credentials by clicking on the extension icon

Expected Behavior

Do not show this notification every single time autotype is used.

Stop sending this notification each time autotype is used and/or disable notification via libnotify.
This could be a browser issue as opposed to keepassxc-browser extension issue (not sure.)

Could also be keepassxc itself sending the notification (but I doubt it.)

Current Behavior

See above.
Every single type autotype is used, the following notification appears through libnotify:
(A) KeePassXC-Browser Create or modify the credentials by clicking on the extension icon

Remove this notification.

Possible Solution

Reason: just annoying to get this obvious notification over and over again.
Fix: Disable notifications via libnotify?

Steps to Reproduce (for bugs)

Debug info

General Info

KeePassXC fork - VERSION=keepassxc-git 2.2.4.r469.ga5745eee
keepassxc-browser - VERSION=2.3.0-snapshot Revision: a5745ee

Operating system: Linux 4.15.1 (x86_64)
Browser: FF 58.0.2
Proxy used: NO

Credential selection not working for some websites on first visit

Expected Behavior

Credentials should be selectable on first page visit.

Current Behavior

I have to switch to another tab and back on some* websites to get selectable credentials.

* So far these two:
https://signin.ebay.de/ws/eBayISAPI.dll
https://www.huk24.de/login.do

Steps to Reproduce (for bugs)

  1. Add entry for sigin.ebay.de
  2. Disable auto-fill
  3. Go to https://signin.ebay.de/ws/eBayISAPI.dll
  4. No credentials are selectable (but question mark on icon blinks briefly)
  5. Switch to another tab
  6. Switch back to latest tab
  7. Credentials are selectable

Debug info

No errors in console.

General Info

KeePassXC fork - 2.3.0
keepassxc-browser - 1.0.0

Operating system: elemantary OS 0.4.1
Browser: Chromium 64.0.3282.167
Proxy used: No

Browser extension: RAM leak (+1GB) and CPU hogging (100%)

When launching the browser, KeePassXC-Browser extension consumes 22MB of RAM and almost no CPU.
After a few hours running, the RAM consumption goes up to more than 1GB (and it would have kept raising if I didn't killed the extension) and the CPU usage is 100%.

See picture:
image

Expected Behavior

The extension should not leak memory nor hog 100% of CPU.

General Info

KeePassXC Version: 2.3.1
KeePassXC-Browser Version: 1.0.1

Operating system: elementary OS 0.4.1 "Loki" (Linux)
Browser: Chromium Version 64.0.3282.167 (Official Build) Built on Ubuntu , running on elementary 0.4.1 (64-bit)
Proxy used: No

Timeout or not connected to KeePassXC (Windows 7 & 10, chrome & firefox)

On two computers, one under windows 10 and the other Windows 7, the extension very often loses connection with KeepassXC, displaying "Timeout or not connected to KeePassXC" for both chrome (65) and firefox (58 & the just released 59).

Expected Behavior

The extension should stay connected to keepassxc

Current Behavior

The extension very often displays "Timeout or not connected to keepassxc"

Possible Solution

Keep clicking the reload button until it works, but this is often a very short term as it keeps disconnecting very often.

Steps to Reproduce (for bugs)

  1. Open database in keepassxc
  2. Launch firefox or chrome
  3. Try to use the extension to input credentials in a page.

Debug info

Error 5: Timeout or not connected to KeePassXC  keepass.js: 954:5
Connecting to native messaging host org.keepassxc.keepassxc_browser  keepass.js: 870:5
Server public key: kt2Nx4SyG9WziF6UneSIWfaGLydUdHb4SXEKIeju7gE=  keepass.js: 620:17
error occurred while processing 'sources: TypeError: can't access dead object
Stack: createNonSourceMappedActor@resource://devtools/shared/base-loader.js -> resource://devtools/server/actors/utils/TabSources.js: 313:1
createSourceActors/<@resource://devtools/shared/base-loader.js -> resource://devtools/server/actors/utils/TabSources.js: 401:19
process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js: 922:23
walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js: 806:7
scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js: 742:11
Line: 313, column: 1  main.js: 1651
Unchecked lastError value: Error: Frame not found, or missing host permission ExtensionCommon.jsm: 425
	withLastError resource://gre/modules/ExtensionCommon.jsm: 425:9
	wrapPromise/< resource://gre/modules/ExtensionCommon.jsm: 478:11
Erreur dans les liens source : TypeError: NetworkError when attempting to fetch resource.
URL de la ressource : moz-extension://69a2daed-837e-4ad4-9b13-5291a856f337/browser-polyfill.min.js
URL du lien source : browser-polyfill.min.js.map [En savoir plus]  (source inconnue)
Failed to connect: Unknown error  keepass.js: 846:5
Error 5: Timeout or not connected to KeePassXC keepass.js: 954:5
Connecting to native messaging host org.keepassxc.keepassxc_browser  keepass.js: 870:5
Server public key: shjzirl4zNNivb/0V7sCPaekUTSuR9p33M6V0tBzw2I=  keepass.js: 620:17

KeePassXC - 2.3.1
keepassxc-browser - 1.0.1
Operating system: Windows 10 x64 and 7 x64
Browser: Chrome 65.0.3325.162 (64bits), Firefox 58.0.2 (64bits) and Firefox 59.0 (64bits)
Proxy used: tried both On and Off

I followed the instructions in this link:

  1. the registry keys are there and point to the correct path
  2. the corresponding json files both point to the correct path for keepassxc-proxy.exe and the values for allowed_extensions are correct
  3. keepassxc-proxy.exe is running
  4. See debug message posted above

Fill fields using shortcut does not work on Mac

Expected Behavior

I should be able to use the Alt + Shift + U or Alt + Shift + P shortcuts to automatically fill in the username and password or just the password respectively on a macOS system.

Current Behavior

The shortcuts, they do nothing. Instead they insert characters like "¨∏". Using the context menu to fill in the fields does work.

Possible Solution

  • Change the shortcuts to something that works
  • Show the correct shortcuts in the Settings dialog

Steps to Reproduce (for bugs)

  1. Go to a username and password form where normal username and password filling through the context menu works as intended.
  2. Use the Alt + Shift + U/P shortcut

Debug info

No errors/warnings in console.

KeePassXC - 2.3.1
keepassxc-browser - 1.0.1
Operating system: Mac
Browser: Firefox
Proxy used: No

keepassxc-browser doesn't autofill custom placeholders

This issues is not related with "Fill TOTP" from context menu

keepassxc-browser doesn't auto-fill custom placeholders when specified with "Choose own credential fields"

Expected Behavior

When a page have their specified credential fields, should auto-fill all custom fields (username/password/KPH placeholders)

Current Behavior

Only username and password is filled.

Possible Solution

Custom placeholders working without issues with KeePassHttp-Connector

Steps to Reproduce (for bugs)

  1. Create a new entry to https://python-totp.herokuapp.com/
  2. Register and setup TOTP
  3. On new entry go to "Advanced" and create a new attribute KPH: 1 - TOTP, with value {TOTP}
  4. On login page from keepassxc-browser icon "Choose your own credential fields", select username field (skip password) and string field
  5. Reload page (if doesn't fill username try to redetect credential fields)

General Info

KeePassXC - Version 2.3.0 Revision: 4c0ed74
keepassxc-browser - Version: 1.0.0

Operating system: Archlinux
Browser: Firefox 58.0.2
Proxy used: NO

HTTP auth dialog manual selection

Expected Behavior

If "Auto fill HTTP Auth dialogs and send them" is disabled I should be able to select credentials manually, like if "Automatically fill-in single credentials entry" is disabled.

Current Behavior

If "Auto fill HTTP Auth dialogs and send them" is disabled no credential selection is shown on HTTP auth dialogs.

Possible Solution

Show credential selection if "Auto fill HTTP Auth dialogs and send them" is disabled on HTTP auth dialogs.

Request: Compatibility with Firefox ESR (52.6.0)

Expected Behavior

Addon should be marked compatible with Firefox ESR (Currently: 52.6.0)

Current Behavior

Addon reports incompatible with ESR and requires 55+

Possible Solution

Mark compatible with 52.6.0 ESR

Steps to Reproduce (for bugs)

n/a

Debug info

I used Nightly Tester Tools to force addon compatibility to allow the install. The Addon appears functional in this state, so barring any major back end changes, it should already be compatible in everything but the name.

KeePassXC Browser doesn't detect new/changed credentials!

Expected Behavior

Detect credentials change

Current Behavior

Ignores changes

Possible Solution

Detect new/changed credentials

General Info

You are running KeePassXC version: 2.3.1
Latest available version of KeePassXC: 2.3.1

Operating system: WIN7
Browser: FIREFOX 58
Proxy used: NO

Unable to pick the correct fields for credentials in a particular site

Expected Behavior

Do not get trapped in some CSS hell.

Current Behavior

Search field is picked.

Steps to Reproduce (for bugs)

  1. Navigate to https://www.asiakastieto.fi/
  2. Click Choose own credential fields

Strangely the picking controls are also in the login section and you can access them after clicking "Dismiss". But I am unable to make the whole control section visible no matter how hard I tried to tweak the CSS in the dev tools.

General Info

KeePassXC fork - 2.3.0
keepassxc-browser - 1.0.0

Operating system: Arch Linux
Browser: Firefox 58.0.2
Proxy used: NO

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.