keepassxreboot / keepassxc-specs Goto Github PK

Since the kdbx-xml rfc is describing both KDBX3.1 and KDBX4, should be nice adding the HeaderHash field to the Meta data list.

This field is used in KDBX3.1 but not in version 4, also KeePass website recommends to not store it/remove it from a KDBX4 file.

Citing KeePass website

In KDBX 4, the HeaderHash element in the XML part is now obsolete and is not stored anymore.

Section 3.4.2.1 currently has to say about tags:

A list of used-defined tags for this entry separated by semicolons ";".

From what I can see in the code, this isn’t entirely correct. While KeePass and keepass-rs in fact seem to store tags separated by semicolons, both will accept semicolons and commas as tag separators. And KeePassXC stores tags separated by commas, while accepting semicolons, colons and commas as tag separators when reading the database.

What should it say in the spec? Probably something like:

A list of user-defined tags. While an implementation SHOULD use semicolons ";" to separate tags, it is RECOMMENDED that it also accepts commas "," and colons ":" as tag separator.

Btw, KDBX 4.1 added group tags.

The same field MasterKeyChangeRec appears 2 times in the Metadata fields list with 2 different meanings.
I think there is a Typo and the second one should be MasterKeyChangeForce

Page3 line 215

   <MasterKeyChangeRec>  _INTEGER_ indicating the number of days after
      which the password manager SHOULD recommend changing the
      database's master key (-1 means 'never')

Page4 line 229

   <MasterKeyChangeRec>  _INTEGER_ indicating the number of days after
      which the password manager SHOULD force changing the database's
master key (-1 means 'never')

Note: I meant this to be a pull request but I cannot quite figure out the toolchain you use to generate all the formats from rfc.md. The tools I try produce a way too verbose diff.

Section 3.1.1 currently claims _DATETIME_ to be in ISO 8601 format. This actually changed from KDBX 3.1 to KDBX 4.0 however. The new format is a base64-encoded 64 bit LE integer representing a number of seconds since 0001-01-01 00:00:00 UTC. There is a corresponding note at the bottom of https://keepass.info/help/kb/kdbx_4.html.

Some specs on the header would be nice. I found this resource extremely useful (especially the step-by-step part) when I was doing an implementation, so it might serve as an example for how the information should be presented. It's only for KDBX3, though.