keera-studios / haskelloids Goto Github PK

Build logs

Reason:

Graphics/HGL/Internals/Events.hs:23:68: error:
    Module ‘Control.Concurrent.Chan’ does not export ‘isEmptyChan’

isEmptyChan is deprecated and is latest seen in base-4.10.1.0 (compare with base-4.11.0.0)

GHC 8.4 uses base 4.11.0.0

A good template is here: https://github.com/ivanperez-keera/SpaceInvaders/blob/develop/.travis.yml

It would be important to minimize dependencies installed (meaning: do not apt-get install anything that's not needed).

The part about deployment would have to be commented out.

A successful pull request should compile on Travis CI without problems.

Installation error due to changes in hmatrix package.

The "Numeric.LinearAlgebra.Interface" is only available until version 0.9.3.0.

However, with this hmatrix version, a dependency on haskell98 would be needed, but that's not included in hmatrix's own cabal file.

Code should not have trailing spaces.

It would be great to include more detail in this README.

In particular, something that demonstrates a game well is a screenshot or, if possible, a GIF.

So, let's try to get either of those and add them to the README :)

I think this is probably very difficult if not impossible due to the dependencies on BLAS and LAPACK.

This should probably be investigated and may result in a replacement of the dependency on hmatrix.

This implementation uses OPTIONS_GHC to specify language extensions (you can search for it in the file).

There are newer ways of doing this now: https://downloads.haskell.org/~ghc/7.2.1/docs/html/users_guide/pragmas.html#language-pragma

See: https://github.com/ivanperez-keera/SpaceInvaders/blob/develop/.gitignore

The travis file could include newer ghc versions. I guess we could add the following:

• "8.0.2"
• "8.2.2"
• "8.4.4"
• "8.6.1"

Hopefully all of them compile without problems.

It would be great to have a readme for this project.

A good template is here:
https://github.com/ivanperez-keera/SpaceInvaders/blob/develop/README.md

It would be important to be careful as the author name, project name, and screenshot are completely different.

In the cabal file the following line needs to be updated:

The following two files use Bang Patterns but do not declare the extension.

src/Haskelloids/Object/Asteroid.hs
src/Haskelloids/Object/Bullet.hs

@mrehayden1 Could you please send this in a separate PR forking off the current master in keera-studios/Haskelloids if that error was already there?

As a reference see:

https://docs.travis-ci.com/user/languages/haskell/
and
https://github.com/ivanperez-keera/dunai/blob/develop/.travis.yml

That is, use the standard building image for Haskell ("ghc" variable, remove install section, etc.).

The cabal file is missing information about where the repository is located. See, for instance:

https://github.com/ivanperez-keera/SpaceInvaders/blob/develop/SpaceInvaders.cabal#L35

So stack users also can build the project